Re: [Ryu-devel] [PATCH] topology.switches: fix link discovery

2013-09-25 Thread FUJITA Tomonori
On Thu, 26 Sep 2013 15:40:04 +0900 YAMAMOTO Takashi wrote: > fix a regression introduced by text address changes. > > problem reported by Tonh o - Antonio Brasolin > patch tested and fixed by YAMADA Hideki > > Signed-off-by: YAMAMOTO Takashi > --- > ryu/topology/switches.py | 5 +++-- > 1 fil

[Ryu-devel] [PATCH] topology.switches: fix link discovery

2013-09-25 Thread YAMAMOTO Takashi
fix a regression introduced by text address changes. problem reported by Tonh o - Antonio Brasolin patch tested and fixed by YAMADA Hideki Signed-off-by: YAMAMOTO Takashi --- ryu/topology/switches.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ryu/topology/switches.

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-09-25 Thread FUJITA Tomonori
On Thu, 26 Sep 2013 13:09:24 +0900 (JST) [email protected] (YAMAMOTO Takashi) wrote: >> On Wed, 25 Sep 2013 11:14:40 -0400 >> Changbin Liu wrote: >> >>> We used Tcpdump to capture the packets and validated that it is an issue >>> related to "malfold openflow packet" sent by Open vSwitch to

Re: [Ryu-devel] [PATCH] packet lib: icmp: rewrite unittest

2013-09-25 Thread FUJITA Tomonori
On Thu, 26 Sep 2013 09:43:44 +0900 Yuichi Ito wrote: > formerly this module tested only to_string(), so a bug in parser() of > 'TimeExceeded' was overlooked. > this patch will bring the module to test all the methods of all the classes > in 'icmp' module. > > > Signed-off-by: itoyuichi > ---

Re: [Ryu-devel] [PATCH] tests/integrated: fix mac address format

2013-09-25 Thread FUJITA Tomonori
On Thu, 26 Sep 2013 10:31:21 +0900 YAMADA Hideki wrote: > This fix following error. > > $ ./run_tests.sh -i > (...) > ryu-manager: hub: uncaught exception: Traceback (most recent call last): > ryu-manager: File "/home/hideki/git/ryu/ryu/lib/hub.py", line 48, in _launch > ryu-manager: func(*args,

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-09-25 Thread YAMAMOTO Takashi
> On Wed, 25 Sep 2013 11:14:40 -0400 > Changbin Liu wrote: > >> We used Tcpdump to capture the packets and validated that it is an issue >> related to "malfold openflow packet" sent by Open vSwitch to the Ryu >> controller. We also used this patch ( >> http://www.mail-archive.com/ryu-devel@lists.

[Ryu-devel] [PATCH 1/3] ofproto: fix OF1.0 packet_in parser

2013-09-25 Thread YAMAMOTO Takashi
OF1.0 spec says OFP_ASSERT(sizeof(struct ofp_packet_in) == 20). It's quite bogus as it assumes a specific class of C implementations. (well, if it was C. it's unclear from the spec itself.) We just use the real size of the structure as this is not C. This agrees with on-wire messages OpenFlow Ref

[Ryu-devel] [PATCH 3/3] ofproto: remove a bogus comment

2013-09-25 Thread YAMAMOTO Takashi
seems like a copy-and-paste leftover from OF1.0. Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_2.py b/ryu/ofproto/ofproto_v1_2.py index 104c585..652bb10 100644 --- a/ryu/ofproto/ofproto_v

[Ryu-devel] [PATCH 2/3] ofproto: remove unused definitions

2013-09-25 Thread YAMAMOTO Takashi
g/c unused OF1.2/1.3 OFP_PACKET_IN_DATA_OFFSET definitions. they seem to be copy-and-paste leftover from OF1.0. Signed-off-by: YAMAMOTO Takashi --- ryu/ofproto/ofproto_v1_2.py| 1 - ryu/ofproto/ofproto_v1_3.py| 1 - ryu/tests/unit/ofproto/test_ofproto_v12.py | 1 -

[Ryu-devel] [PATCH 1/2] of1.2: set default arguments for FlowStatsRequest

2013-09-25 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_2_parser.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_2_parser.py b/ryu/ofproto/ofproto_v1_2_parser.py index db36ce2..0215903 100644 --- a/ryu/ofproto/ofproto_v1_2_parser.py +++ b/r

[Ryu-devel] [PATCH 2/2] of1.3: set default arguments for FlowStatsRequest

2013-09-25 Thread FUJITA Tomonori
Signed-off-by: FUJITA Tomonori --- ryu/ofproto/ofproto_v1_3_parser.py | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_3_parser.py b/ryu/ofproto/ofproto_v1_3_parser.py index 3bd7e14..e8c11ba 100644 --- a/ryu/ofproto/ofproto_v1_3_parser.py +++ b/r

[Ryu-devel] [PATCH] tests/integrated: fix mac address format

2013-09-25 Thread YAMADA Hideki
This fix following error. $ ./run_tests.sh -i (...) ryu-manager: hub: uncaught exception: Traceback (most recent call last): ryu-manager: File "/home/hideki/git/ryu/ryu/lib/hub.py", line 48, in _launch ryu-manager: func(*args, **kwargs) ryu-manager: File "/home/hideki/git/ryu/ryu/base/app_manager.

Re: [Ryu-devel] [PATCH] packet lib: add get_protocol API

2013-09-25 Thread Satoshi Kobayashi
Looks good to me. It is a nice addition to users. 2013/9/26 FUJITA Tomonori > get_protocols returns the list of protocols. This is useful for a > packet including the same protocol multiple times (e.g. tunneling such > GRE). However, it's a rare use case. Instead of > 'get_protocols(hoge)[0]', l

Re: [Ryu-devel] [PATCH] tests/integrated: fix mac address format

2013-09-25 Thread YAMADA Hideki
OK. I'll resend the patch. (2013/09/26 4:29), FUJITA Tomonori wrote: > On Wed, 25 Sep 2013 18:27:06 +0900 > YAMADA Hideki wrote: > >> This fix following error. >> > > Thanks, can you fix the following pep8 warning and resend? > > ryu/tests/integrated/test_request_reply_v12.py:202:80: E501 line

[Ryu-devel] [PATCH] packet lib: icmp: rewrite unittest

2013-09-25 Thread Yuichi Ito
formerly this module tested only to_string(), so a bug in parser() of 'TimeExceeded' was overlooked. this patch will bring the module to test all the methods of all the classes in 'icmp' module. Signed-off-by: itoyuichi --- ryu/tests/unit/packet/test_icmp.py | 300 +++

[Ryu-devel] [PATCH] packet lib: add get_protocol API

2013-09-25 Thread FUJITA Tomonori
get_protocols returns the list of protocols. This is useful for a packet including the same protocol multiple times (e.g. tunneling such GRE). However, it's a rare use case. Instead of 'get_protocols(hoge)[0]', let's do 'get_protocol(hoge)' simply. Signed-off-by: FUJITA Tomonori --- ryu/lib/pack

Re: [Ryu-devel] [PATCH] Advanced WSGI API

2013-09-25 Thread FUJITA Tomonori
On Tue, 24 Sep 2013 11:52:26 +0900 Satoshi Kobayashi wrote: > HTTP routing and implements will be in the same place. This idea was inspired > from Flask and Bottle of Python and JAX-RS of Java. This modification keeps > backward compatibility. > > Signed-off-by: Satoshi Kobayashi > --- > ryu

Re: [Ryu-devel] ofproto

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 13:33:39 +0900 (JST) [email protected] (YAMAMOTO Takashi) wrote: >> On Wed, 25 Sep 2013 11:45:04 +0900 (JST) >> [email protected] (YAMAMOTO Takashi) wrote: >> >>> i want to reduce differences between 1.2 and 1.3 parsers >>> by substituting >>> from . import ofpro

Re: [Ryu-devel] [PATCH 0/3] bgp-4 streaming parser

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 11:59:47 +0900 YAMAMOTO Takashi wrote: > this set is after bgp patches i posted yesterday. > > YAMAMOTO Takashi (3): > streaming parser base class > implement BGP-4 streaming parser > doc: hook up streaming parser docs > > doc/source/library_packet_ref.rst | 9 +

Re: [Ryu-devel] [PATCH 1/2] packet lib: icmp: correct parser() of TimeExceeded

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 17:42:47 +0900 Yuichi Ito wrote: > Signed-off-by: itoyuichi > --- > ryu/lib/packet/icmp.py |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- October Webinars: Code for

Re: [Ryu-devel] [PATCH] tests/integrated: fix mac address format

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 18:27:06 +0900 YAMADA Hideki wrote: > This fix following error. > Thanks, can you fix the following pep8 warning and resend? ryu/tests/integrated/test_request_reply_v12.py:202:80: E501 line too long (83 > 79 characters) m = dp.ofproto_parser.OFPPortMod(dp, port_no,

Re: [Ryu-devel] [PATCH 0/4] packet lib: ipv6: simplify the operations of __init__() and so on

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 13:57:52 +0900 Yuichi Ito wrote: > itoyuichi (4): > packet lib: ipv6: remove unnecessary import > packet lib: ipv6: support udp > packet lib: ipv6: simplify the operations of __init__() > packet lib: ipv6: avoid dangerous default value [] as argument > > ryu/lib/pack

Re: [Ryu-devel] [PATCH] test_addrconv: add more test

2013-09-25 Thread FUJITA Tomonori
On Tue, 24 Sep 2013 10:18:51 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/tests/unit/lib/test_addrconv.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ryu/tests/unit/lib/test_addrconv.py > b/ryu/tests/unit/lib/test_addrconv.py > index ab55886..00a42d

Re: [Ryu-devel] help

2013-09-25 Thread FUJITA Tomonori
On Sat, 21 Sep 2013 09:49:11 +0800 wrote: > Hi, all, > > > > I am trying to insert flow entries into the openvswitch table 1. And this is > how I do it: > > > > mod = datapath.ofproto_parser.OFPFlowMod( > datapath=datapath, cookie=0, cookie_mask=0, table_id=1, >

Re: [Ryu-devel] [PATCH 0/2] packet lib: icmp: correct parser() of TimeExceeded and rewrite unittest

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 17:42:28 +0900 Yuichi Ito wrote: > itoyuichi (2): > packet lib: icmp: correct parser() of TimeExceeded > packet lib: icmp: rewrite unittest for icmp Can you describe 'why we need to rewrite?' in the patch commit message? In general, 'why you need this change' rather than

Re: [Ryu-devel] Error handling in Ryu

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 11:18:31 +0100 Adam Humphreys wrote: > I am new to using Ryu with Openflow, and am currently trying to familiarise > myself with it in order to run some basic tests on Openflow functionality. > > A problem I have encountered is that error handling does not seem to work. > W

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-09-25 Thread FUJITA Tomonori
On Wed, 25 Sep 2013 11:14:40 -0400 Changbin Liu wrote: > We used Tcpdump to capture the packets and validated that it is an issue > related to "malfold openflow packet" sent by Open vSwitch to the Ryu > controller. We also used this patch ( > http://www.mail-archive.com/[email protected]

Re: [Ryu-devel] Error regarding PACKET_IN event

2013-09-25 Thread Changbin Liu
Ryu-team, We used Tcpdump to capture the packets and validated that it is an issue related to "malfold openflow packet" sent by Open vSwitch to the Ryu controller. We also used this patch ( http://www.mail-archive.com/[email protected]/msg02228.html) to dump the error msg, which is e

[Ryu-devel] Error handling in Ryu

2013-09-25 Thread Adam Humphreys
Hi, I am new to using Ryu with Openflow, and am currently trying to familiarise myself with it in order to run some basic tests on Openflow functionality. A problem I have encountered is that error handling does not seem to work. When the Openflow stack raises an error, it sends this message ou

[Ryu-devel] [PATCH] tests/integrated: fix mac address format

2013-09-25 Thread YAMADA Hideki
This fix following error. $ ./run_tests.sh -i (...) ryu-manager: hub: uncaught exception: Traceback (most recent call last): ryu-manager: File "/home/hideki/git/ryu/ryu/lib/hub.py", line 48, in _launch ryu-manager: func(*args, **kwargs) ryu-manager: File "/home/hideki/git/ryu/ryu/base/app_manager.

[Ryu-devel] [PATCH 2/2] packet lib: icmp: rewrite unittest for icmp

2013-09-25 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/tests/unit/packet/test_icmp.py | 300 +--- 1 file changed, 277 insertions(+), 23 deletions(-) diff --git a/ryu/tests/unit/packet/test_icmp.py b/ryu/tests/unit/packet/test_icmp.py index 75d9702..f93ed73 100644 --- a/ryu/tests/unit

[Ryu-devel] [PATCH 1/2] packet lib: icmp: correct parser() of TimeExceeded

2013-09-25 Thread Yuichi Ito
Signed-off-by: itoyuichi --- ryu/lib/packet/icmp.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/lib/packet/icmp.py b/ryu/lib/packet/icmp.py index 6f2e959..a07a5c7 100644 --- a/ryu/lib/packet/icmp.py +++ b/ryu/lib/packet/icmp.py @@ -260,7 +260,7 @@ class TimeExceeded

[Ryu-devel] [PATCH 0/2] packet lib: icmp: correct parser() of TimeExceeded and rewrite unittest

2013-09-25 Thread Yuichi Ito
itoyuichi (2): packet lib: icmp: correct parser() of TimeExceeded packet lib: icmp: rewrite unittest for icmp ryu/lib/packet/icmp.py |2 +- ryu/tests/unit/packet/test_icmp.py | 300 +--- 2 files changed, 278 insertions(+), 24 deletions(-) --