Re: [Ryu-devel] [PATCH v3] fix bidirectional event confusion

On Thu, 23 Jan 2014 16:05:48 +0900 Satoshi Kobayashi wrote: > EventRequestBase has EventReplyBase > > Signed-off-by: Satoshi Kobayashi > --- > Changes v1 -> v2: > - stop using uuid > - refactoring > Changes v2 -> v3: > - EventRequestBase has EventReplyBase > - remove RyuApp#send_reply()

[Ryu-devel] [PATCH v3] fix bidirectional event confusion

EventRequestBase has EventReplyBase Signed-off-by: Satoshi Kobayashi --- Changes v1 -> v2: - stop using uuid - refactoring Changes v2 -> v3: - EventRequestBase has EventReplyBase - remove RyuApp#send_reply() - update doc doc/source/ryu_app_api.rst |5 +++-- ryu/base/app_m

Re: [Ryu-devel] [PATCH v2] fix bidirectional event confusion

> 2014/1/23 YAMAMOTO Takashi > >> hi, >> >> i meant >> send_request >> req.q = hub.Queue() >> send_event >> return req.q.get() >> >> reply_to_request >> req.q.put(rep) >> > > To be sure, it is simpler. > > RyuApp#send_reply() became unnecessary when I tri

Re: [Ryu-devel] [PATCH v2] fix bidirectional event confusion

2014/1/23 YAMAMOTO Takashi > hi, > > i meant > send_request > req.q = hub.Queue() > send_event > return req.q.get() > > reply_to_request > req.q.put(rep) > To be sure, it is simpler. RyuApp#send_reply() became unnecessary when I tried. May we remove this?

Re: [Ryu-devel] [PATCH 00/23] OF1.4 Actions and Messages

On Thu, Jan 23, 2014 at 01:54:33PM +0900, FUJITA Tomonori wrote: > On Thu, 23 Jan 2014 08:52:22 +0900 > Simon Horman wrote: > > > Simon Horman (23): > > Correct OF1.4 OFP_ACTION_HEADER_PACK_STR > > Correct OF1.4 OFPMatch JSON serialisation and formatting > > Add OF1.4 multipart experimenter

Re: [Ryu-devel] [PATCH v2] packet_data_generator: Add OF1.4

On Thu, 23 Jan 2014 08:41:32 +0900 Simon Horman wrote: > Signed-off-by: Simon Horman > --- > v2 > * Expand tabs > > ryu/tests/packet_data_generator/rebar.config |7 +- > ryu/tests/packet_data_generator/src/x.erl|2 +- > ryu/tests/packet_data_generator/src/x5.erl | 2593 > +++

Re: [Ryu-devel] [PATCH] ofctl_v1_2/3: fix SET_FIELD action and some match fields

On Thu, 23 Jan 2014 13:03:27 +0900 Yuichi Ito wrote: > this patch fixes the following bugs: > > - "SET_FIELD" action caused an exception at mod_flow_entry command. > - following match fields caused an exception at get_flow_stats command: > * mpls_label, arp_spa, arp_tpa > - following f

Re: [Ryu-devel] [PATCH 1/6] bgp: a comment

On Wed, 22 Jan 2014 13:06:31 +0900 YAMAMOTO Takashi wrote: > Signed-off-by: YAMAMOTO Takashi > --- > ryu/lib/packet/bgp.py | 1 + > 1 file changed, 1 insertion(+) Applied all, thanks. -- CenturyLink Cloud: The Leader

Re: [Ryu-devel] [PATCH 00/23] OF1.4 Actions and Messages

On Thu, 23 Jan 2014 08:52:22 +0900 Simon Horman wrote: > Simon Horman (23): > Correct OF1.4 OFP_ACTION_HEADER_PACK_STR > Correct OF1.4 OFPMatch JSON serialisation and formatting > Add OF1.4 multipart experimenter request and reply message support > Add OF1.4 group stats request and reply

Re: [Ryu-devel] About restAPI question for more actions at one flow entry

Okay, Yuichi, I expect the new version release. Thanks for your kindly support. BR, Jalee -Original Message- From: Yuichi Ito [mailto:[email protected]] Sent: Thursday, January 23, 2014 12:03 PM To: jalee Cc: [email protected] Subject: Re: [Ryu-devel] About restAPI ques

Re: [Ryu-devel] [PATCH v2] fix bidirectional event confusion

hi, i meant send_request req.q = hub.Queue() send_event return req.q.get() reply_to_request req.q.put(rep) YAMAMOTO Takashi > manage the pair of a request/reply > > Signed-off-by: Satoshi Kobayashi > --- > Changes v1 -> v2: > - stop using uuid > - r

[Ryu-devel] [PATCH] ofctl_v1_2/3: fix SET_FIELD action and some match fields

this patch fixes the following bugs: - "SET_FIELD" action caused an exception at mod_flow_entry command. - following match fields caused an exception at get_flow_stats command: * mpls_label, arp_spa, arp_tpa - following fields in "SET_FIELD" were displayed as classes: * eth_dst, eth_

Re: [Ryu-devel] About restAPI question for more actions at one flow entry

Hi. > So, ryu controller just do push mpls ethertype right? the set-field actions > can we do that? yes. "PUSH_MPLS" only pushes the mpls header. to set a new mpls label on it, use "SET_FIELD". > curl -d '{"cookie": 1, > "dpid": "0034", > "priority": "101", >

[Ryu-devel] [PATCH 23/23] Add OF1.4 role request and reply message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 99 ++ 1 file changed, 99 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index eb5bb88..559536a 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 18/23] Add OF1.4 SetNwTtl action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 29 + 1 file changed, 29 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 226e6f3..8428821 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++

[Ryu-devel] [PATCH 21/23] Add OF1.4 experimenter message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py| 5 + ryu/ofproto/ofproto_v1_4_parser.py | 40 ++ 2 files changed, 45 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 49d8341..1ccd843 100644 --

[Ryu-devel] [PATCH 22/23] Add OF1.4 barrier request and reply message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 40 ++ 1 file changed, 40 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index cc9c24c..eb5bb88 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 12/23] Add OF1.4 PopMpls action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 23 +++ 1 file changed, 23 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 983a4c2..e7e3f75 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/ryu

[Ryu-devel] [PATCH 19/23] Add OF1.4 echo request and reply message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 91 ++ 1 file changed, 91 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 8428821..05b6c08 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 08/23] Add OF1.4 CopyTtlOut action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 770816d..7a57123 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/ryu/ofp

[Ryu-devel] [PATCH 20/23] Add OF1.4 error message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 81 ++ 1 file changed, 81 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 05b6c08..8cbe3f1 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 11/23] Add OF1.4 PushPbb action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 29 + 1 file changed, 29 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 2fdf0eb..983a4c2 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++

[Ryu-devel] [PATCH 10/23] Add OF1.4 PopPbb action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 25 + 1 file changed, 25 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index e0c3c17..2fdf0eb 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/r

[Ryu-devel] [PATCH 09/23] Add OF1.4 CopyTtlIn action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 7a57123..e0c3c17 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/ryu/ofp

[Ryu-devel] [PATCH 00/23] OF1.4 Actions and Messages

Hi, the purpose of this series is to enhance the OF1.4 action and message support of Ryu by correcting some existing support and adding support for a number of messages and actions. This work is not complete and I plan to post follow-up series to further increase ryu's OF1.4 coverage. These patc

[Ryu-devel] [PATCH 17/23] Add OF1.4 DecNwTtl action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 47 ++ 1 file changed, 47 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 2eaf6cd..226e6f3 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 05/23] Add OF1.4 desc stats request and reply message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 82 ++ 1 file changed, 82 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index c03e261..0b1cd47 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 14/23] Add OF1.4 PopVlan action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index c83f332..b07228b 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/ryu/ofpr

[Ryu-devel] [PATCH 04/23] Add OF1.4 group stats request and reply message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 113 + 1 file changed, 113 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index aae6a21..c03e261 100644 --- a/ryu/ofproto/ofproto_v1_4_par

[Ryu-devel] [PATCH 15/23] Add OF1.4 PushVlan action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 29 + 1 file changed, 29 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index b07228b..21cffbe 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++

[Ryu-devel] [PATCH 07/23] Add OF1.4 SetField action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 123 + 1 file changed, 123 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index facfab3..770816d 100644 --- a/ryu/ofproto/ofproto_v1_4_par

[Ryu-devel] [PATCH 16/23] Add OF1.4 DecMplsTtl action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 18 ++ 1 file changed, 18 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index 21cffbe..2eaf6cd 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++ b/ryu/ofpr

[Ryu-devel] [PATCH 13/23] Add OF1.4 PushMpls action support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 29 + 1 file changed, 29 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index e7e3f75..c83f332 100644 --- a/ryu/ofproto/ofproto_v1_4_parser.py +++

[Ryu-devel] [PATCH 02/23] Correct OF1.4 OFPMatch JSON serialisation and formatting

Prior to this patch the code serialises an OFPMatch as: "OFPMatch": { "oxm_fields": { "arp_op": 1, ... } } But the parser fails, complaining that "oxm_fields" is an unknown field name. Resolve this by using the same JSON format as OF1.3: "OFPMatch": {

[Ryu-devel] [PATCH 06/23] Add OF1.4 OFPMatchField support

This covers fields that are also present in OF1.3. In particular it does not cover PBB_UCA. I plan to address this in a subsequent patch. Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py| 2 + ryu/ofproto/ofproto_v1_4_parser.py | 560 + 2

[Ryu-devel] [PATCH 03/23] Add OF1.4 multipart experimenter request and reply message support

Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4_parser.py | 91 ++ 1 file changed, 91 insertions(+) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index b366d9f..aae6a21 100644 --- a/ryu/ofproto/ofproto_v1_4_pars

[Ryu-devel] [PATCH 01/23] Correct OF1.4 OFP_ACTION_HEADER_PACK_STR

As per parsers for earlier OF versions, include 4 trailing bytes in the header. Signed-off-by: Simon Horman --- ryu/ofproto/ofproto_v1_4.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_4.py b/ryu/ofproto/ofproto_v1_4.py index 11408a7..d987835 100

Re: [Ryu-devel] About restAPI question for more actions at one flow entry

Hi Yuichi, So, ryu controller just do push mpls ethertype right? the set-field actions can we do that? Such as: If I want to push new mpls label "777", could you tell me how can edit the restAPI as below. Thanks, Jalee curl -d '{"cookie": 1, "dpid": "0034", "prior

[Ryu-devel] [PATCH v2] fix bidirectional event confusion

manage the pair of a request/reply Signed-off-by: Satoshi Kobayashi --- Changes v1 -> v2: - stop using uuid - refactoring ryu/base/app_manager.py | 17 ++--- ryu/controller/event.py |1 + 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/ryu/base/app_manager.

Re: [Ryu-devel] [PATCH] Fix a bidirectional event confusion between modules

2014/1/22 YAMAMOTO Takashi > > Hi, > > > > Can not we apply in the following patch? > > > > I have the following issue. > > > https://www.mail-archive.com/[email protected]/msg04532.html > > > > The patch fixes the issue by giving an identifier to an event. Influence > is > > restri

Re: [Ryu-devel] About restAPI question for more actions at one flow entry

Hi. PUSH_MPLS requires the ethertype '0x8847' or '0x8848' that mean MPLS. they are 34887 and 34888 in decimal. {"type": "PUSH_MPLS", "ethertype": "34887"} please see below: https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.3.pdf