Re: [Ryu-devel] [PATCH 1/3] bgp: add parameter for site_of_origins to neighbor_add and vrf_add method

2014-07-30 Thread FUJITA Tomonori
On Thu, 31 Jul 2014 14:59:48 +0900 Hiroshi Yokoi wrote: > Fujita-san, > thank you for your comment and finding the bug that causes test case failure. > I fixed the second and resend the whole patch. > > The first is the addition of site_of_origins parameter to neighbor_add and > vrf_add method a

[Ryu-devel] [PATCH 2/3] bgp: add code to handle RD 0:0 at the head of nexthop network address in MP_REACH_NLRI path attribute

2014-07-30 Thread Hiroshi Yokoi
The second is patch to add or skip RD 0:0 label for the next_hop address in MP_REACH_NLRI attribute. According to RFC, next_hop address seems to be required to contain RD of 0 when advertise VPN prefix. This is defined in RFC 4659(3.2.1.1. BGP Speaker Requesting IPv6 Transport) for VPN-IPv6 a

[Ryu-devel] [PATCH 3/3] bgp: fix conflict of PEER_NEXT_HOP and NEXT_HOP value

2014-07-30 Thread Hiroshi Yokoi
The third is fix to a conflict of PEER_NEXT_HOP value in neighbors.py. There is a conflict between PEER_NEXT_HOP in neighbors.py and NEXT_HOP in api/base.py. As a result of the conflict, the correct validator for PEER_NEXT_HOP is not used when neighbir_add is executed. Signed-off-by: Hiroshi Yo

[Ryu-devel] [PATCH 1/3] bgp: add parameter for site_of_origins to neighbor_add and vrf_add method

2014-07-30 Thread Hiroshi Yokoi
Fujita-san, thank you for your comment and finding the bug that causes test case failure. I fixed the second and resend the whole patch. The first is the addition of site_of_origins parameter to neighbor_add and vrf_add method and fixes to some import error. Signed-off-by: Hiroshi Yokoi --- ryu

Re: [Ryu-devel] [PATCH 1/3] bgp: add parameter for site_of_origins to neighbor_add and vrf_add method

2014-07-30 Thread FUJITA Tomonori
On Thu, 31 Jul 2014 10:21:22 +0900 Hiroshi Yokoi wrote: > I will check the test case and my patch. The following patch for your second patch works for me. diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/packet/bgp.py index cf7076a..b91ece7 100644 --- a/ryu/lib/packet/bgp.py +++ b/ryu/lib/packet/bg

Re: [Ryu-devel] About meter/qos support real OFS

2014-07-30 Thread jalee
Okay, Thanks Takahashi. Best Regards, Jalee -Original Message- From: Minoru TAKAHASHI [mailto:[email protected]] Sent: Thursday, July 31, 2014 9:56 AM To: jalee Cc: [email protected] Subject: Re: [Ryu-devel] About meter/qos support real OFS (2014年07月30日 17:28), j

Re: [Ryu-devel] About meter/qos support real OFS

2014-07-30 Thread Minoru TAKAHASHI
(2014年07月30日 17:28), jalee wrote: > Sorry, Takahashi, > I mean, I set rate(1024kbps)into the switch and apply one flow-entry, then > use tester send traffic(1480byte) to this flow entry. > I use tester receive this traffic just only 512kbps. So problem is ? SW... > BR, > > Jalee Thank you for re

Re: [Ryu-devel] [PATCH 1/3] bgp: add parameter for site_of_origins to neighbor_add and vrf_add method

2014-07-30 Thread Hiroshi Yokoi
sorry... I will check the test case and my patch. (2014/07/31 8:04), FUJITA Tomonori wrote: > On Wed, 30 Jul 2014 18:27:43 +0900 > Hiroshi Yokoi wrote: > >> added parameter for site_of_origins to neighbor_add and vrf_add method, >> and fixed some import error. >> >> Signed-off-by: Hiroshi Yokoi

Re: [Ryu-devel] [PATCH 1/3] bgp: add parameter for site_of_origins to neighbor_add and vrf_add method

2014-07-30 Thread FUJITA Tomonori
On Wed, 30 Jul 2014 18:27:43 +0900 Hiroshi Yokoi wrote: > added parameter for site_of_origins to neighbor_add and vrf_add method, > and fixed some import error. > > Signed-off-by: Hiroshi Yokoi > --- > ryu/services/protocols/bgp/bgpspeaker.py| 13 - > ryu/services/protocols/bgp

[Ryu-devel] BGP implementation & openstack contribution

2014-07-30 Thread Digambar Patil
Hi FUJITA, I am also reading BGP protocol for SDN & interested here to contribute to RYU BGP implementation. http://ryu.readthedocs.org/en/latest/library_bgp_speaker.html https://github.com/osrg/ryu/tree/master/ryu/services/protocols/bgp Please let me know about

[Ryu-devel] [PATCH 2/3] bgp: add RD of 0 at the head of nexthop network address in MP_REACH_NLRI path attribute

2014-07-30 Thread Hiroshi Yokoi
added code to add or skip RD of 0 label into the next_hop adress when send and receive MP_REACH_NLRI attribute. According to RFC, next_hop address seems to be required to contain RD of 0 when advertise VPN prefix. This is defined in RFC 4659(3.2.1.1. BGP Speaker Requesting IPv6 Transport) for

[Ryu-devel] [PATCH 1/3] bgp: add parameter for site_of_origins to neighbor_add and vrf_add method

2014-07-30 Thread Hiroshi Yokoi
added parameter for site_of_origins to neighbor_add and vrf_add method, and fixed some import error. Signed-off-by: Hiroshi Yokoi --- ryu/services/protocols/bgp/bgpspeaker.py| 13 - ryu/services/protocols/bgp/info_base/vrf.py | 2 +- ryu/services/protocols/bgp/peer.py |

[Ryu-devel] [PATCH 3/3] bgp: fix conflict of PEER_NEXT_HOP and NEXT_HOP value

2014-07-30 Thread Hiroshi Yokoi
changed the value of PEER_NEXT_HOP in neighbors.py. There is a conflict between PEER_NEXT_HOP in neighbors.py and NEXT_HOP in api/base.py. As a result of the conflict, the correct validator for PEER_NEXT_HOP is not used when neighbir_add is executed. Signed-off-by: Hiroshi Yokoi --- ryu/servi

Re: [Ryu-devel] [PATCH 4/5] app: add simple bmp station application

2014-07-30 Thread FUJITA Tomonori
On Wed, 30 Jul 2014 16:03:56 +0900 ISHIDA Wataru wrote: > > Signed-off-by: ISHIDA Wataru > --- > ryu/app/bmpstation.py | 48 > 1 file changed, 48 insertions(+) > create mode 100644 ryu/app/bmpstation.py I added copyright. >From 6630328fcc65

Re: [Ryu-devel] [PATCH 1/5] packet lib: add bmp(BGP Monitoring Protocol)

2014-07-30 Thread FUJITA Tomonori
On Wed, 30 Jul 2014 16:03:53 +0900 ISHIDA Wataru wrote: > implements I-D grow-bmp-07 > > Signed-off-by: ISHIDA Wataru > --- > ryu/lib/packet/bmp.py | 746 > + > 1 file changed, 746 insertions(+) > create mode 100644 ryu/lib/packet/bmp.py Appl

Re: [Ryu-devel] [PATCH 1/5] packet lib: ipv4: fix default arguments

2014-07-30 Thread FUJITA Tomonori
On Wed, 30 Jul 2014 14:31:46 +0900 Minoru TAKAHASHI wrote: > Reported-by: Arne Goetje > Signed-off-by: Minoru TAKAHASHI > --- > ryu/lib/packet/ipv4.py | 4 ++-- > ryu/tests/unit/packet/test_packet.py | 20 ++-- > 2 files changed, 12 insertions(+), 12 deletions(-)

Re: [Ryu-devel] About meter/qos support real OFS

2014-07-30 Thread jalee
Sorry, Takahashi, I mean, I set rate(1024kbps)into the switch and apply one flow-entry, then use tester send traffic(1480byte) to this flow entry. I use tester receive this traffic just only 512kbps. So problem is ? SW... BR, Jalee -Original Message- From: Minoru TAKAHASHI [mailto:takaha

Re: [Ryu-devel] About meter/qos support real OFS

2014-07-30 Thread Minoru TAKAHASHI
(2014年07月24日 19:57), jalee wrote: > Hi Takahashi, > Thanks for your explanation. > Another question, if the rate not exact, do you think what's problems? On the > SW or not. > such as: "set rate to 1024Kbps but receive rate is 512Kbps." What do you mean "receive rate"? Please give me a little mor

[Ryu-devel] [PATCH 1/5] packet lib: add bmp(BGP Monitoring Protocol)

2014-07-30 Thread ISHIDA Wataru
implements I-D grow-bmp-07 Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bmp.py | 746 + 1 file changed, 746 insertions(+) create mode 100644 ryu/lib/packet/bmp.py diff --git a/ryu/lib/packet/bmp.py b/ryu/lib/packet/bmp.py new file mode 100644

[Ryu-devel] [PATCH 4/5] app: add simple bmp station application

2014-07-30 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/app/bmpstation.py | 48 1 file changed, 48 insertions(+) create mode 100644 ryu/app/bmpstation.py diff --git a/ryu/app/bmpstation.py b/ryu/app/bmpstation.py new file mode 100644 index 000..e90abc1 --- /

[Ryu-devel] [PATCH 3/5] bgp: add bmp client function

2014-07-30 Thread ISHIDA Wataru
now ryu bgp can send internal information through BGP monitoring protocol Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/api/rtconf.py | 16 +++ ryu/services/protocols/bgp/bgpspeaker.py | 14 ++ ryu/services/protocols/bgp/bmp.py | 204

[Ryu-devel] [PATCH 2/5] bmp: add unit test

2014-07-30 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/tests/unit/packet/test_bmp.py | 124 + 1 file changed, 124 insertions(+) create mode 100644 ryu/tests/unit/packet/test_bmp.py diff --git a/ryu/tests/unit/packet/test_bmp.py b/ryu/tests/unit/packet/test_bmp.py new file m

[Ryu-devel] [PATCH 5/5] bgp: fix pep8

2014-07-30 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/info_base/ipv4.py |1 + ryu/services/protocols/bgp/info_base/ipv6.py |1 + 2 files changed, 2 insertions(+) diff --git a/ryu/services/protocols/bgp/info_base/ipv4.py b/ryu/services/protocols/bgp/info_base/ipv4.py index d3bfd03