[Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread Victor Orlikowski
Correcting a unit test failure. Signed-off-by: Victor J. Orlikowski diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py index 3d5d895..eac2c42 100644 --- a/ryu/base/app_manager.py +++ b/ryu/base/app_manager.py @@ -37,6 +37,7 @@ from ryu.controller.handler import register_instance, ge

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread Victor Orlikowski
On Feb 10, 2016, at 1:38 AM, Victor Orlikowski wrote: > > Either way, I will address this in the morning; it's well past midnight > here... ;) Never mind; patch to cover the unit test incoming. It's the "MagicMock" object that doesn't have the requisite attribute; I'll have to have a default

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread FUJITA Tomonori
Hi, On Wed, 10 Feb 2016 06:38:34 + Victor Orlikowski wrote: > I see it; the DummyOpenFlowApp needs a handler_execution_timeout field added. > > Do you need me to re-submit the entire patch, or just a fix for the test case? Please send the entire patch. > Either way, I will address this in

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread Victor Orlikowski
I see it; the DummyOpenFlowApp needs a handler_execution_timeout field added. Do you need me to re-submit the entire patch, or just a fix for the test case? Either way, I will address this in the morning; it's well past midnight here... ;) Best, Victor -- Victor J. Orlikowski <> vjo@[cs.]duke.e

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread FUJITA Tomonori
On Wed, 10 Feb 2016 06:02:05 + Victor Orlikowski wrote: > Per Fujita-San's request, the echo request loop is off by default. > It is easily enabled by setting the "maximum-unreplied-echo-requests" > configuration option to a non-zero value. Thanks, I cleanly applied it. The remaining probl

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread Victor Orlikowski
Fujita-San, I've re-sent this patch to the list, with the attachment. The version with patch attached has the echo-request loop disabled by default, as asked. Best, Victor -- Victor J. Orlikowski <> vjo@[cs.]duke.edu > On Feb 10, 2016, at 12:20 AM, FUJITA Tomonori wrote: > > Hi, > > On Wed,

Re: [Ryu-devel] [PATCH 0/3] Implement NXActionRegLoad

2016-02-09 Thread FUJITA Tomonori
On Wed, 3 Feb 2016 18:02:18 +0900 IWAMOTO Toshihiro wrote: > This set of patches are sort of low priority as Ryu 3.30 has > a fix for NXActionUnknown and OpenStack Neutron no longer > generates exceptions. > > IWAMOTO Toshihiro (3): > Implement NXActionRegLoad > packet_data_generator3: gene

[Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread Victor Orlikowski
Re-sending... Per Fujita-San's request, the echo request loop is off by default. It is easily enabled by setting the "maximum-unreplied-echo-requests" configuration option to a non-zero value. Signed-off-by: Victor J. Orlikowski diff --git a/ryu/base/app_manager.py b/ryu/base/app_manager.py in

[Ryu-devel] [PATCH] drop python2.6 support

2016-02-09 Thread FUJITA Tomonori
The Python core team[*1] stopped supporting python 2.6. Some Python libraries started following the same path and trying to support 2.6 becomes painful... For example, most of you already noticed, oslo.config dropped 2.6 support. I tried to work around it with the following commit: https://github

Re: [Ryu-devel] [PATCH] Stability improvements to the core of Ryu, without requiring user application changes

2016-02-09 Thread FUJITA Tomonori
Hi, On Wed, 27 Jan 2016 05:38:29 + Victor Orlikowski wrote: > Per Iwase-San’s request, here is a re-worked stabilty patch that does *not* > require patching user applications. > Instead, the Datapath class grows a new loop for sending echo requests, and > the ofp_handler class grows a new

Re: [Ryu-devel] [PATCH 0/4] Add missing test cases for test_parser with OpenFlow 1.5

2016-02-09 Thread FUJITA Tomonori
On Wed, 10 Feb 2016 13:58:06 +0900 IWASE Yusuke wrote: > Currently, some test cases for test_parser with OpenFlow 1.5 are missing, > because the packet data for OpenFlow 1.5 are not present. > The followings add the missing packet data and includes some bug fix. > With these patches, the coverag

Re: [Ryu-devel] [PATCH] tox: Adapt to PyPy interpreter

2016-02-09 Thread FUJITA Tomonori
On Wed, 10 Feb 2016 13:47:04 +0900 IWASE Yusuke wrote: > Note: Though tests may not be enough, as far as running unit test, > this patch makes compatible with PyPy interpreter. > > Signed-off-by: IWASE Yusuke > --- > .travis.yml | 1 + > ryu/lib

Re: [Ryu-devel] [PATCH] of12/3/4/5: fix to_jsondict of OFPActionSetField

2016-02-09 Thread FUJITA Tomonori
On Wed, 10 Feb 2016 13:10:12 +0900 Minoru TAKAHASHI wrote: > Some fields missing in the JSON dict that to_jsondict of OFPActionSetField is > returnd. > This patch fixes this problem. > > Signed-off-by: Minoru TAKAHASHI > --- > ryu/ofproto/ofproto_v1_2_parser.py | 4

Re: [Ryu-devel] [PATCH] protocols/bgp: Log socket creation error

2016-02-09 Thread FUJITA Tomonori
On Mon, 8 Feb 2016 17:02:56 + Jason Kölker wrote: > Helpful to track down why the bgp server is stopping when the user > running ryu does not have CAP_NET_BIND_SERVICE. > > Signed-off-by: Jason Kölker > --- > ryu/services/protocols/bgp/base.py | 4 +++- > 1 file changed, 3 insertions(+),

[Ryu-devel] [PATCH 2/4] ofproto_v1_5_parser: Fix unresolved structure references

2016-02-09 Thread IWASE Yusuke
Signed-off-by: IWASE Yusuke --- ryu/ofproto/ofproto_v1_5_parser.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_5_parser.py b/ryu/ofproto/ofproto_v1_5_parser.py index ac91af9..863606a 100644 --- a/ryu/ofproto/ofproto_v1_5_parser.py +++ b/ryu/of

[Ryu-devel] [PATCH 1/4] test_parser: Add missing packet data for OFP15

2016-02-09 Thread IWASE Yusuke
Signed-off-by: IWASE Yusuke --- .../of15/libofproto-OFP15-barrier_reply.packet | Bin 0 -> 8 bytes .../packet_data/of15/libofproto-OFP15-desc_reply.packet | Bin 0 -> 1072 bytes .../of15/libofproto-OFP15-desc_request.packet| Bin 0 -> 16 bytes .../of15/libofproto-OFP15-erro

[Ryu-devel] [PATCH 3/4] ofproto_v1_5_parser: Add missing field in OFPMeterFeaturesStats

2016-02-09 Thread IWASE Yusuke
"features" field is introduced in OpenFlow 1.5, but this field is not defined in ofproto_v1_5_parser.py. This patch adds this missing field. Signed-off-by: IWASE Yusuke --- ryu/ofproto/ofproto_v1_5_parser.py | 2 +- .../ofproto/json/of15/libofproto-OFP15-met

[Ryu-devel] [PATCH 4/4] test_parser: Fix ofp_multipart_type in OFPFlowStatsRequest

2016-02-09 Thread IWASE Yusuke
Signed-off-by: IWASE Yusuke --- .../ofproto/json/of15/libofproto-OFP15-flow_stats_request.packet.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/tests/unit/ofproto/json/of15/libofproto-OFP15-flow_stats_request.packet.json b/ryu/tests/unit/ofproto/json/of15/libofp

[Ryu-devel] [PATCH 0/4] Add missing test cases for test_parser with OpenFlow 1.5

2016-02-09 Thread IWASE Yusuke
Currently, some test cases for test_parser with OpenFlow 1.5 are missing, because the packet data for OpenFlow 1.5 are not present. The followings add the missing packet data and includes some bug fix. With these patches, the coverage of ofproto_v1_5_parser.py are improved from 69% to 87%. IWASE

[Ryu-devel] [PATCH] tox: Adapt to PyPy interpreter

2016-02-09 Thread IWASE Yusuke
Note: Though tests may not be enough, as far as running unit test, this patch makes compatible with PyPy interpreter. Signed-off-by: IWASE Yusuke --- .travis.yml | 1 + ryu/lib/ofctl_v1_3.py | 4 ++-- ryu/lib

[Ryu-devel] [PATCH] of12/3/4/5: fix to_jsondict of OFPActionSetField

2016-02-09 Thread Minoru TAKAHASHI
Some fields missing in the JSON dict that to_jsondict of OFPActionSetField is returnd. This patch fixes this problem. Signed-off-by: Minoru TAKAHASHI --- ryu/ofproto/ofproto_v1_2_parser.py | 4 +++- ryu/ofproto/ofproto_v1_3_parser.py | 4 +++