Re: [Ryu-devel] Qos with custom topology and spanning treee

2016-07-10 Thread Shinpei Muraoka
Hi, > but the problem is still > and I modification the file of (simple_switch_stp_13.py) you can the > error in attachment > and I attachment the file after modification Are you running a command in the file(simple_switch_stp_13.py) that is attached to an e-mail? "table_id=1" has been two s

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-10 Thread Shinpei Muraoka
Hi Fujita-San > We should have really good reason to break the API compatibility with > the older versions. I don't think that this is the case. > > Seems that better to revert this. Can we cleanly revert this? Any > other side effect? I think it have side effect and it need some patches. I

[Ryu-devel] [PATCH v2 4/8] ofproto/nx_actions: Support missing NXAction

2016-07-10 Thread Shinpei Muraoka
Actions to be added are as following. - NXActionDecTtlCntIds - NXActionStackPush - NXActionStackPop - NXActionSample - NXActionOutputReg2 - NXActionRegLoad2 - NXActionController2 Signed-off-by: Shinpei Muraoka --- ryu/ofproto/nicira_ext.py | 14 ++ ryu/ofproto/nx_actions.py | 474 +++

[Ryu-devel] [PATCH v2 0/8] Support some NXAction

2016-07-10 Thread Shinpei Muraoka
Currently, there is NXAction that is not supported by Ryu. The following patches add NXActions that is not supported by Ryu, and Update the parameter of Some NxAction. Additionally, add test cases and documents are updated. Also, for Iwamoto-San comments, the followings are fix to remove the ofpr

[Ryu-devel] [PATCH v2 3/8] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-10 Thread Shinpei Muraoka
This patch, update the methods that are to be specified in the NXM or OXM. Update the oxm_types specified in the bit format to the string. Update the following NXAction. - NXActionOutputReg - NXActionMultipath - NXActionBundle - NXActionBundleLoad Signed-off-by: Shinpei Muraoka --- ryu/ofpr

[Ryu-devel] [PATCH v2 5/8] test_parser: Add test data for missing NXAction

2016-07-10 Thread Shinpei Muraoka
Note: The following actions are not implemented yet, because ovs-ofctl command is not supported. - NXActionRegLoad2 - NXActionOutputReg2 Signed-off-by: Shinpei Muraoka --- .../of13/ovs-ofctl-of13-action_controller2.packet | Bin 0 -> 128 bytes .../ovs-ofctl-of13-action_dec_ttl_cnt_ids.packet

[Ryu-devel] [PATCH v2 8/8] test_parser: Add test data for some NXAction

2016-07-10 Thread Shinpei Muraoka
Signed-off-by: Shinpei Muraoka --- .../of13/ovs-ofctl-of13-action_output_trunc.packet | Bin 0 -> 80 bytes .../of13/ovs-ofctl-of13-action_sample2.packet | Bin 0 -> 96 bytes ryu/tests/packet_data_generator3/gen.py| 12 ++ .../ovs-ofctl-of13-action_output_trunc.packet.json |

[Ryu-devel] [PATCH v2 6/8] ofproto/nx_actions: Add comment for Ryu documents

2016-07-10 Thread Shinpei Muraoka
Signed-off-by: Shinpei Muraoka --- doc/source/nicira_ext_ref.rst | 42 +- ryu/ofproto/nx_actions.py | 1242 + 2 files changed, 1280 insertions(+), 4 deletions(-) diff --git a/doc/source/nicira_ext_ref.rst b/doc/source/nicira_ext_ref.rst index 562e12a

[Ryu-devel] [PATCH v2 1/8] ofproto/nx_actions: Add NXAction used only in OpenFlow1.0

2016-07-10 Thread Shinpei Muraoka
There is NXAction to be used only in OpenFlow1.0. These actions are supported by default in OpenFlow1.2 or later. Therefore, it becomes unnecessary as the NXAction. But, to add the NXAction in order to be able to use in OpenFlow1.0. Actions to be added are as following. - NXActionSetQueue - NXAct

[Ryu-devel] [PATCH v2 7/8] ofproto/nx_actions: Support some NXAction

2016-07-10 Thread Shinpei Muraoka
Actions to be added are as following. - NXActionSample2 - NXActionOutputTrunc Signed-off-by: Shinpei Muraoka --- doc/source/nicira_ext_ref.rst | 2 + ryu/ofproto/nicira_ext.py | 2 + ryu/ofproto/nx_actions.py | 138 ++ 3 files changed, 142 in

[Ryu-devel] [PATCH v2 2/8] test_parser: Add test data for NXAction used only in OpenFlow1.0

2016-07-10 Thread Shinpei Muraoka
Signed-off-by: Shinpei Muraoka --- .../of10/ovs-ofctl-of10-action_dec_mpls_ttl.packet | Bin 0 -> 88 bytes .../of10/ovs-ofctl-of10-action_dec_nw_ttl.packet | Bin 0 -> 88 bytes .../of10/ovs-ofctl-of10-action_pop_mpls.packet | Bin 0 -> 88 bytes .../of10/ovs-ofctl-of10-action_push_mpls.packe

Re: [Ryu-devel] Ryu tests

2016-07-10 Thread Iwase Yusuke
Hi, Which Ryu package are you using? (Sorry, I don't know about the Ryu package on Fedora...) To execute the tests of Ryu, the following python packages are required. https://github.com/osrg/ryu/blob/master/tools/test-requires If you have installed pip, you can install them as following:

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-10 Thread FUJITA Tomonori
On Fri, 08 Jul 2016 11:04:46 +0900 IWAMOTO Toshihiro wrote: > At Thu, 7 Jul 2016 15:51:10 +0900, > Takashi YAMAMOTO wrote: >> >> [1 ] >> [1.1 ] >> this change broke dragonflow. >> https://bugs.launchpad.net/dragonflow/+bug/1599367 >> >> i thought we aimed to align with on-wire fields rather t

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-10 Thread Shinpei Muraoka
Hi Yamamoto-San > i don't feel start/end is any easier to understand than ofs/nbits. but > probably it's a matter of taste. > i guess consistency (ie. be similar to on-wire) is more important here. > > you can add start/end as optional arguments and if specified convert > them to ofs/nbits.