Re: [Ryu-devel] [PATCH] adding DHCPv6 support

Hi Olivier, Thank you for submitting your patch! First, the patch seems to be wrapped unexpectedly when line exceeds 80(?) characters or so. Please confirm you mailer settings. https://git-scm.com/docs/git-format-patch#_mua_specific_hints And, the following is some modest comments I found. O

[Ryu-devel] [PATCH 0/2] pip: Tests for requirements for pip install

For OpenStack, Ryu should be comapitble to be installed with "pip install" command. OTOH, the requirements for Ryu are separeted: - tools/pip-requires (referred by pip) - tools/optional-requires (NOT referred by pip) - tools/test-requires) (NOT referred by pip) This make it complex to check t

[Ryu-devel] [PATCH 1/2] tox: Test ryu-manager without additional requirements

Signed-off-by: IWASE Yusuke --- tox.ini | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/tox.ini b/tox.ini index f87480a..6454af3 100644 --- a/tox.ini +++ b/tox.ini @@ -2,19 +2,27 @@ envlist = py27,py34,py35,pypy26,pep8 [testenv] -deps = -U - -r{to

[Ryu-devel] [PATCH 2/2] test_requirements: Test cases for checking requirements

This patch adds the test cases for checking whether the requirements of Ryu has no conflict with that of other projects (e.g., the global requirements of OpenStack) Signed-off-by: IWASE Yusuke --- ryu/tests/unit/test_requirements.py | 85 + 1 file changed, 85

[Ryu-devel] [PATCH 0/4] bgp: Support multiple next_hop in BGPPathAttributeMpReachNLRI

In case of the IPv6 address family in MP-BGP, NLRI might has multipule next_hop addresses (e.g., one is global unicast address and the other is link local unicast address). The following patches fix to support multipule next_hop addresses in MP-BGP NLRIs. IWASE Yusuke (4): packet/bgp: Support m

[Ryu-devel] [PATCH 3/4] packet/bgp: Unpack mpls_label in BGPPathAttributePmsiTunnel

The decoded mpls_labe should be return as a tuple of (mpls_labe, is_bos). This patch fixes to unpack the returned tuple. Signed-off-by: IWASE Yusuke --- ryu/lib/packet/bgp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/packet/bgp.py index c

[Ryu-devel] [PATCH 2/4] stringify: Add optional attributes list to be displayed

Currently, propery type attributes are ignored in the str and json representations. If we want to include them, it is required to override to_jsondict() and from_jsondict() methods. This patch adds the optional attributes list to specify the addtional attributes included in the str and json repres

[Ryu-devel] [PATCH 4/4] packet/bgp: Support multiple next_hop in BGPPathAttributeMpReachNLRI

In case of the IPv6 address family in MP-BGP, NLRI might has multipule next_hop addresses (e.g., one is global unicast address and the other is link local unicast address). This patch fixes to support multipule next_hop addresses in MP-BGP NLRIs. For the backward compatibility, this patch make it

[Ryu-devel] [PATCH 1/4] packet/bgp: Support multiple BGP messages in a packet

This patch fixes to BGPMessage.parser() to return the reference to its own class and to support multiple BGP messages in a single packet. Signed-off-by: IWASE Yusuke --- ryu/lib/packet/bgp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/pack

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

At Fri, 18 Nov 2016 20:07:38 +, Olivier Desnoë wrote: > > This patch adds the ability to dissect and generate DHCPv6 packets. I > needed it to develop a simple LDRA app (as defined in RFC 6221). > > Signed-off-by: Olivier DESNOE > --- > diff --git a/ryu/lib/packet/dhcp6.py b/ryu/lib/packet/d