Hi Bryon,
Thank you for reporting this issue!
On 2017年02月27日 06:11, Bryon Gloden, CISSP wrote:
> Greetings!
>
> In set_ovsdb_addr, there may be an exception on line# 588, or else the
> comparison against None on line# 593 is unnecessary [0].
>
> rest_qos.py:586: def set_ovsdb_addr(self, dpid, ovsdb_addr):
> rest_qos.py:587: # easy check if the address format valid
> rest_qos.py:588: _proto, _host, _port = ovsdb_addr.split(':')
> rest_qos.py:589:
> rest_qos.py:590: old_address = self.ovsdb_addr
> rest_qos.py:591: if old_address == ovsdb_addr:
> rest_qos.py:592: return
> rest_qos.py:593: if ovsdb_addr is None:
The route "if ovsdb_addr is None" seems to be used in case of
"delete_ovsdb_addr" method.
https://github.com/osrg/ryu/blob/master/ryu/app/rest_qos.py#L425-L428
But, as you pointed out, if "delete_ovsdb_addr" called, rest_qos.py will
exception at
line 588...
We would highly appreciate if you could send a patch for this issue!
Thanks,
Iwase
>
> [0] CWE-476: NULL Pointer Dereference
>
> Signed-off-by: Bryon Gloden, CISSP® <[email protected]>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Ryu-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/ryu-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Ryu-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ryu-devel
