[Ryu-devel] [PATCH v2 0/3] BGPSpeaker: Advertise local routes to RR clients

2018-06-12 Thread IWASE Yusuke
The following patches update v2 patches for Iwamoto-San's comments to drop ignoring W605 because W605 would be a syntax error in python 3.10. https://bugs.python.org/issue32912 With this update, the following patches should be applied with Iwamoto-San's patches: [Ryu-devel] [PATCH 1/2] Fix pyc

[Ryu-devel] [PATCH v2 1/3] BGPSpeaker: Advertise local routes to RR clients

2018-06-12 Thread IWASE Yusuke
The current implementation misses the mandatory attributes when sending locally generated routes to its Route Reflector (RR) clients, then the clients will reject the received routes. This patch fixes to add or update attributes to for sending locally generated routes its RR clients. Signed-off-b

[Ryu-devel] [PATCH v2 3/3] BGPSpeaker: Fix BGP state string conversion

2018-06-12 Thread IWASE Yusuke
The constants BGP_FSM_* are str type values and not callable. Signed-off-by: IWASE Yusuke --- ryu/services/protocols/bgp/peer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ryu/services/protocols/bgp/peer.py b/ryu/services/protocols/bgp/peer.py index 2a0e2a9f..2c6e38

[Ryu-devel] [PATCH v2 2/3] pycodestyle: Ignore W504

2018-06-12 Thread IWASE Yusuke
Signed-off-by: IWASE Yusuke --- tox.ini | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tox.ini b/tox.ini index 758d1661..c1759acb 100644 --- a/tox.ini +++ b/tox.ini @@ -52,14 +52,15 @@ commands = [pycodestyle] exclude = pbr-*,.venv,.tox,.git,doc,dist,tools,vcsversion.

Re: [Ryu-devel] [PATCH 2/3] pycodestyle: Ignore W504 and W605

2018-06-12 Thread Iwase Yusuke
Hi, Thank you for reviewing my patches! W605 would be a syntax error in python 3.10. https://bugs.python.org/issue32912 There are tens of docstrings like this in nx_actions.py, which violates W605. .. set_field:value[/mask]->dst .. +-

Re: [Ryu-devel] Nicira Extension Matches in ofctl

2018-06-12 Thread IWAMOTO Toshihiro
On Sat, 09 Jun 2018 01:44:04 +0900, Tommy Romano wrote: > > [1 ] > [1.1 ] > Hello all, > > We are using the Ryu ofctl_rest app for testing and we noticed that using > Nicira Extension fields in a match structure returns an error (‘Unknown match > field’). We found that this is because when of

Re: [Ryu-devel] Query BGP speaker

2018-06-12 Thread knet solutions
Thanks. the patch works fine. On Tue, Jun 12, 2018 at 11:38 AM, Iwase Yusuke wrote: > Hi, > > Hmmm... the current implementation seems not to suppose to have the locally > generated routes when configured itself as a Route Reflector. Only > supposed to > reflect the received routes. > > The atta

Re: [Ryu-devel] [PATCH 2/3] pycodestyle: Ignore W504 and W605

2018-06-12 Thread IWAMOTO Toshihiro
On Tue, 12 Jun 2018 17:26:50 +0900, IWAMOTO Toshihiro wrote: > > On Tue, 12 Jun 2018 15:17:35 +0900, > IWASE Yusuke wrote: > > > > Signed-off-by: IWASE Yusuke > > --- > > tox.ini | 6 -- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/tox.ini b/tox.ini > > index 75

[Ryu-devel] [PATCH 2/2] nx_actions: Fix NXActionSetTunnel docstring

2018-06-12 Thread IWAMOTO Toshihiro
set_tunnel and set_field:xxx->tun_id are different actions. Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nx_actions.py | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/ryu/ofproto/nx_actions.py b/ryu/ofproto/nx_actions.py index 5fe0d545.

[Ryu-devel] [PATCH 1/2] Fix pycodestyle W605 warnings

2018-06-12 Thread IWAMOTO Toshihiro
W605 invalid escape sequence, which was recently added in pycodestyle, would be a syntax error in future python3 versions. Signed-off-by: IWAMOTO Toshihiro --- ryu/app/rest_qos.py | 6 +-- ryu/lib/ofctl_string.py | 4 +- ryu/lib/ovs/vsctl.py

Re: [Ryu-devel] BGP Speakers

2018-06-12 Thread knet solutions
Hi Iwase, The use case is like below, Rtr1---SDN-Rtr1---Rtr2--SDN-Rtr2-Rtr3 Rtr1, Rtr2, Rtr3 are traditional BGP Routers SDN-Rtr1, and SDN-Rtr2 are BGP Speakers. SDN-Rtr1(RYU Bgp speaker) connects to two neighbors Rtr1 and Rtr2. SDN-Rtr2(RYU Bgp speaker) connects to two nei

Re: [Ryu-devel] Query regarding Ryu

2018-06-12 Thread Vidhu Baggan
Dear Sir Kindly guide that in which file, we can assign IP addresses to interfaces in a RYU-BGP router. Thanking you in anticipation. *Vidhu Baggan* Associate Professor | School of Computer Sciences Chitkara Institute of Engineering & Technology . [image: Mail] CAMPUS Chandigarh - Patiala N

Re: [Ryu-devel] [PATCH 2/3] pycodestyle: Ignore W504 and W605

2018-06-12 Thread IWAMOTO Toshihiro
On Tue, 12 Jun 2018 15:17:35 +0900, IWASE Yusuke wrote: > > Signed-off-by: IWASE Yusuke > --- > tox.ini | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tox.ini b/tox.ini > index 758d1661..5d8712e1 100644 > --- a/tox.ini > +++ b/tox.ini > @@ -52,14 +52,16 @@ comman