Re: [Ryu-devel] Bug in dhcp.hlen calculation

2015-02-19 Thread Sam Russell
2:33:44:55") would return 6. On 19 February 2015 at 16:51, Minoru TAKAHASHI wrote: > Hi, > > On 2015年02月17日 19:36, Sam Russell wrote: >> I've been working with ryu.lib.packet.dhcp and I believe hlen is being >> calculated incorrectly. > > I think so too. >

[Ryu-devel] Bug in dhcp.hlen calculation

2015-02-17 Thread Sam Russell
I've been working with ryu.lib.packet.dhcp and I believe hlen is being calculated incorrectly. If I create a dhcp() object without passing hlen, it attempts to set this to len(chaddr) - but this gets the length of the string (17 chars for a MAC address) instead of measuring the 6 octets. The code

[Ryu-devel] [PATCH] OpenFlow 1.2 learning switch

2013-07-16 Thread Sam Russell
Signed-off-by: Sam Russell --- ryu/app/simple_switch_12.py | 120 +++ 1 file changed, 120 insertions(+) create mode 100644 ryu/app/simple_switch_12.py diff --git a/ryu/app/simple_switch_12.py b/ryu/app/simple_switch_12.py new file mode 100644 index

[Ryu-devel] [PATCH] two openflow 1.2 example apps - learning switch, and learning switch with ARP policing

2013-07-16 Thread Sam Russell
port_no, reason) diff --git a/ryu/app/simple_switch_12.py b/ryu/app/simple_switch_12.py new file mode 100644 index 000..f50bd0f --- /dev/null +++ b/ryu/app/simple_switch_12.py @@ -0,0 +1,142 @@ +# Copyright (C) 2011 Nippon Telegraph and Telephone Corporation. +# OpenFlow 1.2 upgrade by Sam Ru

[Ryu-devel] [PATCH] two openflow 1.2 example apps - learning switch, and learning switch with ARP policing

2013-07-16 Thread Sam Russell
raph and Telephone Corporation. +# OpenFlow 1.2 upgrade by Sam Russell +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +#http://www.apache.org/licen

Re: [Ryu-devel] OpenFlow 1.2 learning switch

2013-07-16 Thread Sam Russell
Hi, Just wanted to check - is the patch in my last email okay, or does it need to be formatted differently? Is it a patch that you're interested in incorporating into Ryu? 有難うございました Sam On Tue, Jul 16, 2013 at 2:52 PM, Sam Russell wrote: > Thanks for your help, is this patch okay?

[Ryu-devel] OpenFlow 1.2 learning switch

2013-07-15 Thread Sam Russell
Do you guys like my app? There's a nice OpenFlow 1.0 learning switch as a sample in ryu/app, and I thought for completeness we should have an OpenFlow 1.2 app too https://github.com/osrg/ryu/pull/13 -- See everything from