Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-25 Thread IWAMOTO Toshihiro
At Thu, 21 Jul 2016 22:00:21 +0900 (JST), FUJITA Tomonori wrote: > > On Thu, 21 Jul 2016 15:56:07 +0900 > Shinpei Muraoka wrote: > > > Hi Fujita-San > > > >> The patch can't be cleanly reverted. So let's forget this point. > > > > I got it. > > I will include it in the patch. > > > > > >> Ke

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-21 Thread FUJITA Tomonori
On Thu, 21 Jul 2016 15:56:07 +0900 Shinpei Muraoka wrote: > Hi Fujita-San > >> The patch can't be cleanly reverted. So let's forget this point. > > I got it. > I will include it in the patch. > > >> Keeping the jsondict outputs is nice but it's optional for me. > > I think the simple source

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-20 Thread Shinpei Muraoka
Hi Fujita-San > The patch can't be cleanly reverted. So let's forget this point. I got it. I will include it in the patch. > Keeping the jsondict outputs is nice but it's optional for me. I think the simple source is good. I modify the format to be set the zone_src a string. If you want to s

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-20 Thread FUJITA Tomonori
On Thu, 21 Jul 2016 10:19:07 +0900 Shinpei Muraoka wrote: > > I think it's better to separate this into the pure revert patch and > > the other changes in order to make git history more readable. > > Separate this into the revert patch and the other changes. > However, revert patch has an impa

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-20 Thread Shinpei Muraoka
Hi Iwamoto-San > You meant commit 3c3896fd77f274ce953dcb78795aa5cc4fde6c65? Sorry it was my mistake. Modify commit ID to 3c3896fd77f274ce953dcb78795aa5cc4fde6c65. > I think it's better to separate this into the pure revert patch and > the other changes in order to make git history more read

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-20 Thread IWAMOTO Toshihiro
At Wed, 20 Jul 2016 13:36:41 +0900, Shinpei Muraoka wrote: > > This patch will revert the API of NXAction for the following report. > https://bugs.launchpad.net/dragonflow/+bug/1599367 > revert commit id: a01f8f0aa03cd85df2fc07e7217c2a79e7f0 You meant commit 3c3896fd77f274ce953dcb78795aa5cc4f

[Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-19 Thread Shinpei Muraoka
This patch will revert the API of NXAction for the following report. https://bugs.launchpad.net/dragonflow/+bug/1599367 revert commit id: a01f8f0aa03cd85df2fc07e7217c2a79e7f0 Add the utility method for ofs_nbits. Since the zone_src in NXActionCT was not possible to specify string, update zone