Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-14 Thread YAMAMOTO Takashi
>> On Fri, 10 May 2013 09:31:55 +0900 (JST) >> yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: >> > +class Client(object): > +"""a convenient class for a pure rpc client > +*sock* is a socket-like. it should be blocking. > +""" I'm not sure about having pur

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-09 Thread YAMAMOTO Takashi
> On Fri, 10 May 2013 09:31:55 +0900 (JST) > yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: > +class Client(object): +"""a convenient class for a pure rpc client +*sock* is a socket-like. it should be blocking. +""" >>> >>> I'm not sure about having pure 'Client

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-09 Thread FUJITA Tomonori
On Fri, 10 May 2013 09:31:55 +0900 (JST) yamam...@valinux.co.jp (YAMAMOTO Takashi) wrote: >>> +class Client(object): >>> +"""a convenient class for a pure rpc client >>> +*sock* is a socket-like. it should be blocking. >>> +""" >> >> I'm not sure about having pure 'Client' class. Bot

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-09 Thread YAMAMOTO Takashi
>> +class Client(object): >> +"""a convenient class for a pure rpc client >> +*sock* is a socket-like. it should be blocking. >> +""" > > I'm not sure about having pure 'Client' class. Both end can be client > and server once a connection is established. i think a pure synchronous cl

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-09 Thread FUJITA Tomonori
On Wed, 8 May 2013 15:32:36 +0900 YAMAMOTO Takashi wrote: > - make create_request returns msgid > - fix msgid wrap around > - rename classes > - convenient transport classes for socket-like > - update requirements > - copyright notice, comments, and assertions > > Signed-off-by: YAMAMOTO Takash

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-08 Thread YAMAMOTO Takashi
>> +from collections import deque > > Doesn't pep8 complain? > I understand why you'd like to put import here, though. pep8 didn't complain. i guess i should separate this module into two. >> +res = self._endpoint.get_response(msgid) >> +if res: >> +result

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-08 Thread YAMAMOTO Takashi
>> +def send_request(self, method, params): >> +"""Send a request >> +""" >> +msg, msgid = self._encoder.create_request(method, params) >> +self._send_message(msg) >> +self._pending_requests.add(msgid) > > Is this order safe? > What if response arriving

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-08 Thread Isaku Yamahata
On Wed, May 08, 2013 at 03:32:36PM +0900, YAMAMOTO Takashi wrote: > - make create_request returns msgid > - fix msgid wrap around > - rename classes > - convenient transport classes for socket-like > - update requirements > - copyright notice, comments, and assertions > > Signed-off-by: YAMAMOTO T

Re: [Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-08 Thread Isaku Yamahata
On Wed, May 08, 2013 at 03:32:36PM +0900, YAMAMOTO Takashi wrote: > - make create_request returns msgid > - fix msgid wrap around > - rename classes > - convenient transport classes for socket-like > - update requirements > - copyright notice, comments, and assertions > > Signed-off-by: YAMAMOTO T

[Ryu-devel] [PATCH 2/3] msgpack-rpc fixes and improvements

2013-05-07 Thread YAMAMOTO Takashi
- make create_request returns msgid - fix msgid wrap around - rename classes - convenient transport classes for socket-like - update requirements - copyright notice, comments, and assertions Signed-off-by: YAMAMOTO Takashi --- ryu/lib/rpc.py | 277