Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-12-19 Thread Olivier Desnoë
I tried with Outlook in raw text mode and it seems to be fixing the line wrapping issue. Just tell me if something's wrong with the 2nd version of the patch. Olivier Le lun. 19 déc. 2016 à 01:54, Iwase Yusuke a écrit : > Hi, > > Thank you for updating your patch! > > > On 2016年12月16日 17:17, Oli

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-12-18 Thread Iwase Yusuke
Hi, Thank you for updating your patch! On 2016年12月16日 17:17, Olivier Desnoë wrote: > > First, the patch seems to be wrapped unexpectedly when line exceeds > 80(?) characters or so. > Please confirm you mailer settings. > https://git-scm.com/docs/git-format-patch#_mua_specific_

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-12-16 Thread Olivier Desnoë
> > > First, the patch seems to be wrapped unexpectedly when line exceeds > 80(?) characters or so. > Please confirm you mailer settings. > https://git-scm.com/docs/git-format-patch#_mua_specific_hints > > I used Gmail web app, so I understand I have to change. I'll experiment a bit on this befor

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-12-16 Thread Olivier Desnoë
Thanks. It will be taken into account in the next version of the patch. Le lun. 21 nov. 2016 à 08:59, IWAMOTO Toshihiro a écrit : > At Fri, 18 Nov 2016 20:07:38 +, > Olivier Desnoë wrote: > > > > This patch adds the ability to dissect and generate DHCPv6 packets. I > > needed it to develop a

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-11-24 Thread Olivier Desnoë
You may be right. I'll check it soon. Thanks for your comments. Olivier Le mar. 22 nov. 2016 à 06:50, Iwase Yusuke a écrit : > Hi Olivier, > > Thank you for submitting your patch! > > First, the patch seems to be wrapped unexpectedly when line exceeds > 80(?) characters or so. > Please confirm

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-11-21 Thread Iwase Yusuke
Hi Olivier, Thank you for submitting your patch! First, the patch seems to be wrapped unexpectedly when line exceeds 80(?) characters or so. Please confirm you mailer settings. https://git-scm.com/docs/git-format-patch#_mua_specific_hints And, the following is some modest comments I found. O

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-11-21 Thread IWAMOTO Toshihiro
At Fri, 18 Nov 2016 20:07:38 +, Olivier Desnoë wrote: > > This patch adds the ability to dissect and generate DHCPv6 packets. I > needed it to develop a simple LDRA app (as defined in RFC 6221). > > Signed-off-by: Olivier DESNOE > --- > diff --git a/ryu/lib/packet/dhcp6.py b/ryu/lib/packet/d

[Ryu-devel] [PATCH] adding DHCPv6 support

2016-11-18 Thread Olivier Desnoë
This patch adds the ability to dissect and generate DHCPv6 packets. I needed it to develop a simple LDRA app (as defined in RFC 6221). Signed-off-by: Olivier DESNOE --- diff --git a/ryu/lib/packet/dhcp6.py b/ryu/lib/packet/dhcp6.py new file mode 100644 index 000..1102305 --- /dev/null +++ b/r