Re: [Ryu-devel] Bug in dhcp.hlen calculation

2015-02-19 Thread Minoru TAKAHASHI
Hi, On 2015年02月20日 06:37, Sam Russell wrote: > That looks correct to me - in any case the test you've changed will > pick it up. I can confirm that setting hlen=6 is working as part of my > dhcp server for linux clients > (https://github.com/samrussell/trekin/blob/master/trekin/app/trekin.py), > a

Re: [Ryu-devel] Bug in dhcp.hlen calculation

2015-02-19 Thread Sam Russell
That looks correct to me - in any case the test you've changed will pick it up. I can confirm that setting hlen=6 is working as part of my dhcp server for linux clients (https://github.com/samrussell/trekin/blob/master/trekin/app/trekin.py), and would expect that mac.text_to_bin("00:11:22:33:44:55"

Re: [Ryu-devel] Bug in dhcp.hlen calculation

2015-02-18 Thread Minoru TAKAHASHI
Hi, On 2015年02月17日 19:36, Sam Russell wrote: > I've been working with ryu.lib.packet.dhcp and I believe hlen is being > calculated incorrectly. I think so too. > > If I create a dhcp() object without passing hlen, it attempts to set > this to len(chaddr) - but this gets the length of the string

[Ryu-devel] Bug in dhcp.hlen calculation

2015-02-17 Thread Sam Russell
I've been working with ryu.lib.packet.dhcp and I believe hlen is being calculated incorrectly. If I create a dhcp() object without passing hlen, it attempts to set this to len(chaddr) - but this gets the length of the string (17 chars for a MAC address) instead of measuring the 6 octets. The code