Re: [Ryu-devel] Trouble parsing DHCP packets

2016-12-25 Thread Shinpei Muraoka
lto:[email protected]] > Sent: Thursday, December 22, 2016 12:15 AM > To: [email protected] > Cc: [email protected] > Subject: Re: [Ryu-devel] Trouble parsing DHCP packets > > Hi, > > I am thinking of creating a patch using your source code. > > I have a question for

Re: [Ryu-devel] Trouble parsing DHCP packets

2016-12-22 Thread Jacob Cox
[email protected]] Sent: Thursday, December 22, 2016 12:15 AM To: [email protected] Cc: [email protected] Subject: Re: [Ryu-devel] Trouble parsing DHCP packets Hi, I am thinking of creating a patch using your source code. I have a question for your source code. The size of "

Re: [Ryu-devel] Trouble parsing DHCP packets

2016-12-21 Thread Shinpei Muraoka
Hi, I am thinking of creating a patch using your source code. I have a question for your source code. The size of "sname" and "file" are defined by RFC 2131. ("sname" size is 64 bytes, "file" size is 128 bytes) In your source code there are cases where "sname" is 40 bytes and "file" does not e

Re: [Ryu-devel] Trouble parsing DHCP packets

2016-12-21 Thread Jacob Cox
To make this work, I had to modify Ryu's dhcp.py file. I just placed my solution on stackoverflow, and I'm placing the complete file on https://github.com/Ryuretic/RyureticLabs/tree/master/ryu/ryu/app/Ryuretic/Su pport_Files shortly. Folks should be able to save their current dhcp.py file as a back

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-29 Thread Jeff Rasley
Thanks Benny for checking back with me! I haven't actually been able to test it yet, I've been out of town and now dealing with other higher priority issues. I'll definitely let you know once I get back to it though. Thanks, Jeff On Tue Oct 28 2014 at 8:10:13 PM Benjamin Eggerstedt < benjamin.eg

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-28 Thread Benjamin Eggerstedt
Hi Jeff, I hope you're doing fine and the issue is already resolved. I'd really like to know if it was what we expected, or something else ... Meanwhile I used the time to dig into the Ryu Framework a little more ... In my "virtual lab" (Mininet VM (vBox) + Ryu-GitHub) I found that there is an i

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-27 Thread FUJITA Tomonori
On Sun, 26 Oct 2014 20:26:38 +0900 (JST) FUJITA Tomonori wrote: > On Thu, 23 Oct 2014 14:23:27 -0400 > Jeff Rasley wrote: > >> More specifically I am getting an "error: 'unpack_from requires a buffer of >> at least 233 bytes'" error from the unpack call on 185 (my buffer appears >> to be 91 byt

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-26 Thread FUJITA Tomonori
On Thu, 23 Oct 2014 14:23:27 -0400 Jeff Rasley wrote: > More specifically I am getting an "error: 'unpack_from requires a buffer of > at least 233 bytes'" error from the unpack call on 185 (my buffer appears > to be 91 bytes long). Which makes me think that the unpack string is not > representati

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Nitin Sharma
If you have the rule that exports default actions=CONTROLLER , try actions=CONTROLLER:1024 so that 1024 bytes of DHCP packet goes as Packet-IN. It could be sending truncated packets as Packet-IN, I think 255 bytes is the default. Nitin Sharma On Thu, Oct 23, 2014 at 2:23 PM, Jeff Rasley wrote:

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Jeff Rasley
Wonderful, thanks Benny. I'll have to look into this further but this definitely sounds similar to the issues I am dealing with. Jeff On Thu, Oct 23, 2014 at 3:28 PM, Benjamin Eggerstedt < [email protected]> wrote: > Hi Jeff, > > When I read your first mail I immediately felt reminde

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Benjamin Eggerstedt
Hi Jeff, When I read your first mail I immediately felt reminded on the issue I'm currently working on. If you create a tcpdump -s 0 -lnni ethX capture on the device running Ryu, I'm almost certain that the DHCP DISCOVER in question will show up as "Truncated" with regards to the "DATA" portion (c

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Jeff Rasley
More specifically I am getting an "error: 'unpack_from requires a buffer of at least 233 bytes'" error from the unpack call on 185 (my buffer appears to be 91 bytes long). Which makes me think that the unpack string is not representative of my DHCP Discover packet. On Thu, Oct 23, 2014 at 2:19 PM,

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Jeff Rasley
Sorry Benny, I should have went into more detail in my previous email. I have definitely been using the library you pointed to however it is not actually parsing my DHCP Discover packets correctly. Here's a sample of some code I have reduced my problem down to: https://gist.github.com/jeffra/aa6cf

Re: [Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Benjamin Eggerstedt
Hi Jeff, Looking at https://github.com/osrg/ryu/blob/master/ryu/lib/packet/dhcp.py I'd say "yes" :) Benny On Thu, Oct 23, 2014 at 7:22 PM, Jeff Rasley wrote: > I seem to be having trouble parsing DHCP Discover packets in Ryu. I see > there is a test for DHCP Offer messages > in ryu/tests/unit/

[Ryu-devel] Trouble parsing DHCP packets

2014-10-23 Thread Jeff Rasley
I seem to be having trouble parsing DHCP Discover packets in Ryu. I see there is a test for DHCP Offer messages in ryu/tests/unit/packet/test_dhcp.py. Has DHCP Discover parsing been implemented? Thanks, Jeff Rasley http://cs.brown.edu/~jeffra ---