Re: [Ryu-devel] rest_router.py mac-address

2013-10-29 Thread FUJITA Tomonori
On Tue, 29 Oct 2013 11:24:43 +0900 "watanabe.fumitaka" wrote: > Hi, yamamoto. > > Is correction below correct with the new API? > If satisfactory now, I will try test. > > > --- a/ryu/app/rest_router.py > +++ b/ryu/app/rest_router.py > @@ -1764,13 +1764,9 @@ class OfCtl_v1_2(OfCtl): >

Re: [Ryu-devel] rest_router.py mac-address

2013-10-29 Thread wataru yamamoto
I tried the following patche. It checked working correctly also OpenFlow1.0 switch. Thank you. >It was regarded as the list because of the unnecessary comma. > > >Signed-off-by: WATANABE Fumitaka >--- > ryu/app/rest_router.py |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread watanabe.fumitaka
I also checked the patch working correctly. However, it seems that another bug still remains in the case of openflow1.0. I will correct it later as another patch. File "/home/ryu/OFC/src/router/rest_router.py", line 1575, in set_packetin_flow nw_proto=nw_proto, actions=actions) File

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread wataru yamamoto
I tried the following patches. It checked working correctly. Thank you. (2013/10/29 (火) 11:34), YAMAMOTO Takashi wrote: >> Hi, yamamoto. >> >> Is correction below correct with the new API? > > yes. > > YAMAMOTO Takashi > >> If satisfactory now, I will try test. >> >> >> --- a/ryu/app/rest_router.

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread YAMAMOTO Takashi
> Hi, yamamoto. > > Is correction below correct with the new API? yes. YAMAMOTO Takashi > If satisfactory now, I will try test. > > > --- a/ryu/app/rest_router.py > +++ b/ryu/app/rest_router.py > @@ -1764,13 +1764,9 @@ class OfCtl_v1_2(OfCtl): > if dec_ttl: > actions.a

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread watanabe.fumitaka
Hi, yamamoto. Is correction below correct with the new API? If satisfactory now, I will try test. --- a/ryu/app/rest_router.py +++ b/ryu/app/rest_router.py @@ -1764,13 +1764,9 @@ class OfCtl_v1_2(OfCtl): if dec_ttl: actions.append(ofp_parser.OFPActionDecNwTtl())

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread YAMAMOTO Takashi
>> On Tue, 29 Oct 2013 11:04:30 +0900 (JST) >> [email protected] (YAMAMOTO Takashi) wrote: >> >>> - for OF1.2 and 1.3, the recommended way is to compose set-field actions >>> is "OFPActionSetField(eth_src='11:22:33:44:55:66')". >>> >>> - OFPMatchField.make is an internal api and it should

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread YAMAMOTO Takashi
> On Tue, 29 Oct 2013 11:04:30 +0900 (JST) > [email protected] (YAMAMOTO Takashi) wrote: > >> - for OF1.2 and 1.3, the recommended way is to compose set-field actions >> is "OFPActionSetField(eth_src='11:22:33:44:55:66')". >> >> - OFPMatchField.make is an internal api and it should not hav

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread FUJITA Tomonori
On Tue, 29 Oct 2013 11:04:30 +0900 (JST) [email protected] (YAMAMOTO Takashi) wrote: > - for OF1.2 and 1.3, the recommended way is to compose set-field actions > is "OFPActionSetField(eth_src='11:22:33:44:55:66')". > > - OFPMatchField.make is an internal api and it should not have been >

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread YAMAMOTO Takashi
- for OF1.2 and 1.3, the recommended way is to compose set-field actions is "OFPActionSetField(eth_src='11:22:33:44:55:66')". - OFPMatchField.make is an internal api and it should not have been used by apps in the first place. it was kept only for compat reasons. - OFPMatchField.make takes b

Re: [Ryu-devel] rest_router.py mac-address

2013-10-28 Thread FUJITA Tomonori
CC'ed the author On Mon, 28 Oct 2013 15:14:49 +0900 wataru yamamoto wrote: > I tried to execute rest_router.py. > > However, the MAC Address of the packet which acts as a forward is inaccurate. > Specifically, the MAC Address is ASCII-Code instead of Binary-Code. > > Then, I corrected as follo

[Ryu-devel] rest_router.py mac-address

2013-10-27 Thread wataru yamamoto
I tried to execute rest_router.py. However, the MAC Address of the packet which acts as a forward is inaccurate. Specifically, the MAC Address is ASCII-Code instead of Binary-Code. Then, I corrected as follows. === start === --- rest_router.py.org 2013-10-28 14:51:15.0 +0900 +++ rest_r