Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-07-10 Thread Iwase Yusuke
Hi Kakuma-San, Thank you very much! Sure, I will update v2 patch! Thanks, Iwase On 2017年07月10日 12:53, fumihiko kakuma wrote: Hi Iwase-San, Thank you for explanations. We discussed with fujita-san about this topic last week and we concluded that it will be better to move ryu/tests/integrated

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-07-09 Thread fumihiko kakuma
Hi Iwase-San, Thank you for explanations. We discussed with fujita-san about this topic last week and we concluded that it will be better to move ryu/tests/integrated/common to ryu/lib. Can you add my previous patch to your v2 patch? After the new version with this patch was released, I am goin

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-07-09 Thread Iwase Yusuke
Hi Kakuma-San, Sorry for the delay. On 2017年07月06日 21:58, fumihiko kakuma wrote: Hi Iwase-San, I have one question for your patch. Why do you not move ryu/tests/switch as well? I guess that is because it is rferenced in the ryu-book. Or do you have an another reason? As you guessed, just be

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-07-06 Thread fumihiko kakuma
Hi Iwase-San, I have one question for your patch. Why do you not move ryu/tests/switch as well? I guess that is because it is rferenced in the ryu-book. Or do you have an another reason? Thank you, Kakuma On Mon, 03 Jul 2017 08:53:39 +0900 fumihiko kakuma wrote: > Hi Iwase-San, > > Thank you

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-07-02 Thread fumihiko kakuma
Hi Iwase-San, Thank you for your updates. The v2 patch looks good to me. Thanks, Kakuma On Sat, 1 Jul 2017 22:42:59 +0900 Iwase Yusuke wrote: > Hi Kakuma-San, > > Thank you for your confirmation! > > I've just updated my patch to include scripts you mentioned. > Could you review my v2 patch?

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-07-01 Thread Iwase Yusuke
Hi Kakuma-San, Thank you for your confirmation! I've just updated my patch to include scripts you mentioned. Could you review my v2 patch? Thanks, Iwase On 2017年06月30日 22:04, fumihiko kakuma wrote: > Hi Iwase-San, > > Sorry, I had overlooked. > Could you include script files to this patch too

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-06-30 Thread fumihiko kakuma
Hi Iwase-San, Sorry, I had overlooked. Could you include script files to this patch too? $ ls -1 tests/integrated/common/ install_docker_test_pkg_common.sh install_docker_test_pkg_for_travis.sh install_docker_test_pkg.sh $ Thanks, Kakuma On Fri, 30 Jun 2017 14:52:50 +0900 fumihiko kakuma wrot

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-06-29 Thread fumihiko kakuma
Hi Iwase-San, Thank you for reply. I think that the patch will fix the issue, as nrutron-dynamic-routing imports only ryu.tests.integrated.common. Thank you, Kakuma On Fri, 30 Jun 2017 13:31:27 +0900 Iwase Yusuke wrote: > Hi Kakuma-San, > > The following patch can fix this issue? >[Ryu-

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-06-29 Thread Iwase Yusuke
Hi Kakuma-San, The following patch can fix this issue? [Ryu-devel] [PATCH] tests: Revert some test files Thanks, Iwase On 2017年06月30日 11:53, Iwase Yusuke wrote: Hi Kakuma-San, All modules are required to be reverted? Or which modules should be reverted? Thanks, Iwase On 2017年06月30日 10:2

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-06-29 Thread Iwase Yusuke
Hi Kakuma-San, All modules are required to be reverted? Or which modules should be reverted? Thanks, Iwase On 2017年06月30日 10:29, fumihiko kakuma wrote: Hi Fujita-san, neutron-dynamic-routing in Openstack project uses ryu.tests module in scenario test. Could you revert this commit? Thank yo

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-06-29 Thread fumihiko kakuma
Hi Fujita-san, neutron-dynamic-routing in Openstack project uses ryu.tests module in scenario test. Could you revert this commit? Thank you, Fumihiko Kakuma On Tue, 27 Jun 2017 09:55:25 +0900 (JST) FUJITA Tomonori wrote: > On Mon, 26 Jun 2017 15:04:43 +0900 > IWASE Yusuke wrote: > > > To pr

Re: [Ryu-devel] [PATCH] tests: Separate test files from Ryu module

2017-06-26 Thread FUJITA Tomonori
On Mon, 26 Jun 2017 15:04:43 +0900 IWASE Yusuke wrote: > To prevent redundant files (e.g., pcap files, json files for tests, > packet data generator) to be installed, this patch separates test > directory from Ryu module. > > Signed-off-by: IWASE Yusuke Sounds good. Pushed, thanks. --