Re: [Ryu-devel] Problems when a BGP speaker is being shutdown

2018-04-11 Thread Fujimoto Satoshi
Hi, Sorry for delay. When we shutdown the BGPSpeaker, threads associated with each neighbors don't seem to be stopped. I think this causes the problem. I wrote the patch for this: diff --git a/ryu/services/protocols/bgp/base.py b/ryu/services/protocols/bgp/base.py index 8b69aa3..37d42a9 10064

Re: [Ryu-devel] Problems when a BGP speaker is being shutdown

2018-04-05 Thread Jens Harbott
2018-04-05 0:12 GMT+00:00 Fujimoto Satoshi : > Hi, Jens > > Could you check whether you have reinstalled Ryu after applying the patch. > > # At Ryu top directory: > $ python setup.py install I did patch the installed version, but forgot to remove the matching .pyc file, so your patch was indeed no

Re: [Ryu-devel] Problems when a BGP speaker is being shutdown

2018-04-04 Thread Fujimoto Satoshi
Hi, Jens Could you check whether you have reinstalled Ryu after applying the patch. # At Ryu top directory: $ python setup.py install Thanks, Fujimoto On 2018年04月04日 20:14, Jens Harbott wrote: 2018-04-03 5:22 GMT+00:00 Fujimoto Satoshi : Hi, I just sent the patch for your issue: subject: [

Re: [Ryu-devel] Problems when a BGP speaker is being shutdown

2018-04-04 Thread Jens Harbott
2018-04-03 5:22 GMT+00:00 Fujimoto Satoshi : > Hi, > > I just sent the patch for your issue: > > subject: [PATCH] bgp/peer: Don't stop BGPProtocol instance which already > stops > > Currently, when a connection is lost, BGP Speaker tries to > stop BGPProtocol instance, even if it already stops. > T

Re: [Ryu-devel] Problems when a BGP speaker is being shutdown

2018-04-02 Thread Fujimoto Satoshi
Hi, I just sent the patch for your issue: subject: [PATCH] bgp/peer: Don't stop BGPProtocol instance which already stops Currently, when a connection is lost, BGP Speaker tries to stop BGPProtocol instance, even if it already stops. This commit fixes this by checking the status of BGPProtocol

Re: [Ryu-devel] Problems when a BGP speaker is being shutdown

2018-03-22 Thread Fujimoto Satoshi
Hi, Sorry for delay. I reproduced the situation. The cause may be that the disconnection is incomplete when the speaker is being shutdown while the connection is existing. Let me investigate this problem. In the meantime, please delete all peers before shutting down. Thanks, Fujimoto On 2018年0