Re: [Ryu-devel] [PATCH 1/1] rename ryu-client under ryu/tests

2013-06-30 Thread FUJITA Tomonori
On Sat, 29 Jun 2013 11:14:16 +0900 Isaku Yamahata wrote: > Since it is debugging tool for developer, don't install it. > and move it under ryu/rests directory. > > Signed-off-by: Isaku Yamahata > --- > run_tests.sh |2 +- > {bin => ryu/tests/bin}/ryu-client |0 > s

[Ryu-devel] Ryu 2.1 released

2013-06-30 Thread FUJITA Tomonori
Hi, Bug fixes, packet library updates, etc. Thanks! = Aeschlimann Philipp (1): of13: Added InstructionMeter FUJITA Tomonori (12): Add config file for Travis fix travis config file of1.2: fix OFPSetConfig default arguments packet lib: icmp support time exceeded ty

Re: [Ryu-devel] [PATCH v2] lib/packet: teach packet library to truncate padding octet

2013-06-30 Thread Isaku Yamahata
On Fri, Jun 28, 2013 at 10:42:13PM +0900, FUJITA Tomonori wrote: > On Mon, 10 Jun 2013 11:00:18 +0900 > Isaku Yamahata wrote: > > > The patch teaches packet library to truncate padding octets. > > The protocol class that knows its payload length should set its payload > > length as payload_length

[Ryu-devel] [PATCH] lib/packet: teach packet library to truncate padding octet

2013-06-30 Thread Isaku Yamahata
The patch teaches packet library to truncate padding octets. The protocol class that knows its payload length should set its payload length as payload_length > 0 attributes. Then, the packet.parser truncates its payload. If payload_length = 0, do nothing. Cc: YAMAMOTO Takashi Cc: Shaun Crampton

Re: [Ryu-devel] [PATCH v2] lib/packet: teach packet library to truncate padding octet

2013-06-30 Thread YAMAMOTO Takashi
> On Fri, Jun 28, 2013 at 10:42:13PM +0900, FUJITA Tomonori wrote: >> On Mon, 10 Jun 2013 11:00:18 +0900 >> Isaku Yamahata wrote: >> >> > The patch teaches packet library to truncate padding octets. >> > The protocol class that knows its payload length should set its payload >> > length as payloa

[Ryu-devel] [PATCH] openstack copyright notice

2013-06-30 Thread YAMAMOTO Takashi
restore openstack copyright notice for the code taken from them. > commit f2c6dfe1066aeecb5fdf2fb1cd5ce6476565fd24 > Author: FUJITA Tomonori > Date: Fri Nov 30 15:54:12 2012 +0900 > > set setup.py install_requires properly > > Let's enable pip to solve the dependency. > > The code i

[Ryu-devel] [PATCH 05/13] add a method to import a system (non ryu/contrib) module

2013-06-30 Thread YAMAMOTO Takashi
will be used for rpc library. Signed-off-by: YAMAMOTO Takashi --- ryu/contrib/__init__.py | 31 +++ 1 file changed, 31 insertions(+) diff --git a/ryu/contrib/__init__.py b/ryu/contrib/__init__.py index 7faed78..9540297 100644 --- a/ryu/contrib/__init__.py +++ b/ryu/c

[Ryu-devel] [PATCH 10/13] rpc: prefix closed_by_peer with _ as it's private

2013-06-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/lib/rpc.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ryu/lib/rpc.py b/ryu/lib/rpc.py index 0322e8e..42abe70 100644 --- a/ryu/lib/rpc.py +++ b/ryu/lib/rpc.py @@ -127,7 +127,7 @@ class EndPoint(object): self._notifica

[Ryu-devel] [PATCH 04/13] import msgpack into ryu/contrib

2013-06-30 Thread YAMAMOTO Takashi
0.3.0 (commit df6449f17366b9d608895766cc1a151167460ae0) only pure python code for now because: - we don't want to worry about cython setup.py stuff - cython version has a known bug cf. https://github.com/msgpack/msgpack-python/pull/64 why do we want to have this private copy? - in order to avoi

[Ryu-devel] [PATCH 02/13] msgpack-rpc fixes and improvements

2013-06-30 Thread YAMAMOTO Takashi
- make create_request returns msgid - fix msgid wrap around - rename classes - convenient transport classes for socket-like - update requirements - copyright notice, comments, and assertions Signed-off-by: YAMAMOTO Takashi --- ryu/lib/rpc.py | 295

[Ryu-devel] [PATCH 07/13] msgpack-rpc: unit tests

2013-06-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/lib/test_rpc.py | 352 + 1 file changed, 352 insertions(+) create mode 100644 ryu/tests/unit/lib/test_rpc.py diff --git a/ryu/tests/unit/lib/test_rpc.py b/ryu/tests/unit/lib/test_rpc.py new file mode 100

[Ryu-devel] [PATCH 11/13] rpc: test case

2013-06-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/lib/test_rpc.py | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/ryu/tests/unit/lib/test_rpc.py b/ryu/tests/unit/lib/test_rpc.py index 779a85d..735e049 100644 --- a/ryu/tests/unit/lib/test_rpc.py +++ b/ryu

[Ryu-devel] [PATCH 08/13] rpc: add a test for https://github.com/yamt/ryu/pull/1

2013-06-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/tests/unit/lib/test_rpc.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ryu/tests/unit/lib/test_rpc.py b/ryu/tests/unit/lib/test_rpc.py index 599081e..779a85d 100644 --- a/ryu/tests/unit/lib/test_rpc.py +++ b/ryu/tests/unit/lib/test_rpc.py @@

[Ryu-devel] [PATCH 13/13] a simple command line msgpack-rpc client

2013-06-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- bin/rpc-cli | 237 +++ run_tests.sh | 2 +- setup.py | 3 +- 3 files changed, 240 insertions(+), 2 deletions(-) create mode 100755 bin/rpc-cli diff --git a/bin/rpc-cli b/bin/rpc-cli new file mo

[Ryu-devel] [PATCH 00/13] simple rpc library and client

2013-06-30 Thread YAMAMOTO Takashi
this set includes msgpack-rpc library and command line client. changes from the previous: - incorporated feedbacks - rebase FUJITA Tomonori (1): msgpack rpc helper YAMAMOTO Takashi (11): msgpack-rpc fixes and improvements remove msgpack-python from pip-requires for now import msgpack int

[Ryu-devel] [PATCH 12/13] add rpc.Client.peek_notification

2013-06-30 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- ryu/lib/rpc.py | 8 1 file changed, 8 insertions(+) diff --git a/ryu/lib/rpc.py b/ryu/lib/rpc.py index 42abe70..769cc0d 100644 --- a/ryu/lib/rpc.py +++ b/ryu/lib/rpc.py @@ -316,3 +316,11 @@ class Client(object): raise EOFError("EOF")

[Ryu-devel] [PATCH 01/13] msgpack rpc helper

2013-06-30 Thread YAMAMOTO Takashi
From: FUJITA Tomonori Signed-off-by: FUJITA Tomonori Signed-off-by: YAMAMOTO Takashi --- ryu/lib/rpc.py | 37 + 1 file changed, 37 insertions(+) create mode 100644 ryu/lib/rpc.py diff --git a/ryu/lib/rpc.py b/ryu/lib/rpc.py new file mode 100644 index 0

[Ryu-devel] [PATCH 06/13] rpc: use system msgpack library if available

2013-06-30 Thread YAMAMOTO Takashi
the system version of the msgpack library might be a performance-wise better choice than ryu/contrib one because of cython. on the other hand, the cython version of the code has known bugs. use the system msgpack library only if it seems to work without the bug. Signed-off-by: YAMAMOTO Takashi --

[Ryu-devel] [PATCH 09/13] rpc: If the socket is closed by peer, endpoint stop the serve.

2013-06-30 Thread YAMAMOTO Takashi
From: yuta-hamada If client does socket.close() the serve will be non-wait looping. So must stop the serve of endpoint that received 0 byte packet. Signed-off-by: YAMAMOTO Takashi --- ryu/lib/rpc.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ryu/lib/rpc.py b/ryu/l

[Ryu-devel] [PATCH 03/13] remove msgpack-python from pip-requires for now

2013-06-30 Thread YAMAMOTO Takashi
msgpack-python makes quantum stop working. https://bugs.launchpad.net/quantum/+bug/1178512 https://review.openstack.org/#/c/28504/ https://review.openstack.org/#/c/29182/ Signed-off-by: YAMAMOTO Takashi --- tools/pip-requires | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/pip-requires

[Ryu-devel] [PATCH v4 1/3] lib/packet: make protocol_name property instead of attributes

2013-06-30 Thread Isaku Yamahata
Because it is read-only and to prevent accidental over-write. Signed-off-by: Isaku Yamahata --- ryu/lib/packet/packet_base.py |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index b0aeca0..847e5ce 100644 ---

[Ryu-devel] [PATCH v4 2/3] lib/packet: make packet_base.parser abstract method

2013-06-30 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- ryu/lib/packet/packet_base.py |4 1 file changed, 4 insertions(+) diff --git a/ryu/lib/packet/packet_base.py b/ryu/lib/packet/packet_base.py index 847e5ce..c3f76e3 100644 --- a/ryu/lib/packet/packet_base.py +++ b/ryu/lib/packet/packet_base.py @@ -13,9 +

[Ryu-devel] [PATCH v4 3/3] lib/packet: teach packet library to truncate padding octet

2013-06-30 Thread Isaku Yamahata
The patch teaches packet library to truncate padding octets. Change packet_base.parser() to return (header, next_type, rest_of_packet) The protocol class that knows its payload length should rest_of_packet where padding octets at the last of packet is truncated. As bonus, - fix ipv6 parser as ipv6