[Ryu-devel] [PATCH 1/5] bgp: fix bug when restart neighbor

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/core.py|2 +- ryu/services/protocols/bgp/peer.py| 14 -- ryu/services/protocols/bgp/speaker.py |4 ++-- 3 files changed, 15 insertions(+), 5 deletions(-) diff --git a/ryu/services/protocols/bgp/core.py b/

[Ryu-devel] [PATCH 4/5] bgp: remove an unused variable from bgpspeaker

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/bgpspeaker.py |2 -- 1 file changed, 2 deletions(-) diff --git a/ryu/services/protocols/bgp/bgpspeaker.py b/ryu/services/protocols/bgp/bgpspeaker.py index 8e852ff..1f3bd43 100644 --- a/ryu/services/protocols/bgp/bgpspeaker.py +++

[Ryu-devel] [PATCH 3/5] bgpspeaker: refine logs

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/peer.py| 14 ++ ryu/services/protocols/bgp/speaker.py |1 - 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/ryu/services/protocols/bgp/peer.py b/ryu/services/protocols/bgp/peer.py index 9c511dc..141

[Ryu-devel] [PATCH 2/5] bgp: make marker private variable

2014-07-28 Thread ISHIDA Wataru
stop showing when stringified because it's noisy Signed-off-by: ISHIDA Wataru --- ryu/lib/packet/bgp.py |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/packet/bgp.py index c65e154..b077be3 100644 --- a/ryu/lib/packet/bgp.py +++ b/ryu

[Ryu-devel] [PATCH 5/5] bgp: add neighbor_reset method to bgpspeaker

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/bgpspeaker.py | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ryu/services/protocols/bgp/bgpspeaker.py b/ryu/services/protocols/bgp/bgpspeaker.py index 1f3bd43..e1d6a41 100644 --- a/ryu/services/protocols/bgp/bgpspea

[Ryu-devel] [PATCH 1/2] ofctl_v1_2/3: fix tcp_dst/src match fields

2014-07-28 Thread Minoru TAKAHASHI
when enclosed the value of "ip_proto" in double quotes, following match fields is not set at mod_flow_stats command: * tcp_dst, tcp_src this patch fixes this problem. Reported-by: jalee Signed-off-by: Minoru TAKAHASHI --- ryu/lib/ofctl_v1_2.py | 4 ++-- ryu/lib/ofctl_v1_3.py | 4 ++-- 2 fil

[Ryu-devel] [PATCH 2/2] ofctl_v1_2/3: fix unsuitable log

2014-07-28 Thread Minoru TAKAHASHI
when using action type below, the log unsuitable is outputted: Unknown action type: [action type] * GOTO_TABLE, WRITE_METADATA, METER(only ofctl_v1_3.py) this patch fixes this problem. Reported-by: jalee Signed-off-by: Minoru TAKAHASHI --- ryu/lib/ofctl_v1_2.py | 3 +-- ryu/lib/ofctl_v1_3.p

[Ryu-devel] How to decode switch error messages into human readable form?

2014-07-28 Thread arne_goetje
Hi list, the example code in ofproto_v1_3_parser.py to log error messages only logs hex numbers. Example: @set_ev_cls(ofp_event.EventOFPErrorMsg, [HANDSHAKE_DISPATCHER, CONFIG_DISPATCHER, MAIN_DISPATCHER]) def error_msg_handler(self, ev): msg = ev

[Ryu-devel] [PATCH 2/8] bgp: enable filter configuration via configuration file

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/rtconf/base.py |5 +-- ryu/services/protocols/bgp/rtconf/neighbors.py | 51 +--- 2 files changed, 47 insertions(+), 9 deletions(-) diff --git a/ryu/services/protocols/bgp/rtconf/base.py b/ryu/services/pr

[Ryu-devel] [PATCH 4/8] bgp: create adjacent rib in peer instance

2014-07-28 Thread ISHIDA Wataru
this will be used when in-bound and out-bound filter changed at runtime and to implement BMP(BGP monitering protocol) client Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/model.py| 35 +++- ryu/services/protocols/bgp/peer.py | 40

[Ryu-devel] [PATCH 7/8] bgp: add show neighbor command to ssh client

2014-07-28 Thread ISHIDA Wataru
looks like, bgpd> show neighbor IP Address AS NumberBGP State 10.0.0.1 64514Established Signed-off-by: ISHIDA Wataru --- .../bgp/operator/commands/show/neighbor.py | 31 1 file changed, 31 insertions(+) diff --git a/ryu/services/protocols/bgp/

[Ryu-devel] [PATCH 8/8] bgp: add show neighbor filter command to ssh client

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- .../bgp/operator/commands/show/neighbor.py | 31 +++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/ryu/services/protocols/bgp/operator/commands/show/neighbor.py b/ryu/services/protocols/bgp/operator/commands/show/neighb

[Ryu-devel] [PATCH 3/8] bgp: add in-filter function

2014-07-28 Thread ISHIDA Wataru
Signed-off-by: ISHIDA Wataru --- ryu/services/protocols/bgp/api/rtconf.py |9 +++ ryu/services/protocols/bgp/bgpspeaker.py | 29 ++ ryu/services/protocols/bgp/peer.py | 70 +++- ryu/services/protocols/bgp/rtconf/neighbors.py | 27

[Ryu-devel] [PATCH 5/8] bgp: manage filter in a peer instance instead of rtconf

2014-07-28 Thread ISHIDA Wataru
rtconf is basically for static configuration and filter is dynamic and also specific configuration for peer instance. move filter things under peer instance, and change rtconf to do only static configuration things from a configuration file Signed-off-by: ISHIDA Wataru --- ryu/services/protocol

[Ryu-devel] [PATCH 1/8] bgp: move filter class under info_base/

2014-07-28 Thread ISHIDA Wataru
move filter class from bgpspeaker.py to info_base/base.py to fix the error shown below. $ sudo env PYTHONPATH=/home/wataru/ryu ~/ryu/bin/ryu run --config-file=~/etc/ryu01.conf ./application.py loading app ./application.py instantiating app ./application.py of RyuBGPSpeaker INFO 2014-07-21 06:14:

[Ryu-devel] [PATCH 0/8] Ryu BGP filter improvement

2014-07-28 Thread ISHIDA Wataru
I refined the patches I sent on 22 Jul (not the patches I sent today). Please discard the past patches. The following patches fix some bugs related to out-bound filter and improve the filter function of Ryu BGP. - fix the bug when use Ryu BGP as RyuApp - filter function is now configurable throug

[Ryu-devel] [PATCH 6/8] bgp: refine and fix filter code

2014-07-28 Thread ISHIDA Wataru
- change the name of the filter class from PrefixList to PrefixFilter to make it easy to understand the role of this class. - update docs - fix bugs Signed-off-by: ISHIDA Wataru --- doc/source/library_bgp_speaker_ref.rst |2 +- ryu/services/protocols/bgp/bgpspeaker.py | 94

[Ryu-devel] About wildcard in Ryu

2014-07-28 Thread Yuliang Li
Hi all, I want to use wildcard in Ryu. But when I typed "match=parser.OFPMatch(ipv4_dst='10.0.0.0/24',eth_type=0x800)", I got "ValueError: IPAddress() does not support netmasks or subnet prefixes! See documentation for details". Could anyone tell me how to use wildcard in Ryu? Thanks a lo

Re: [Ryu-devel] About wildcard in Ryu

2014-07-28 Thread Wei-Li Tang
Hello, You can use a tuple to specify an IP network instead. For example, match = parser.OFPMatch(ipv4_dst=('10.0.0.0', '255.255.255.0'), eth_type=0x0800) 2014-07-28 17:34 GMT+08:00 Yuliang Li : > Hi all, > > I want to use wildcard in Ryu. But when I typed > "match=parser.OFPMatch(ipv4_dst

Re: [Ryu-devel] [PATCH 1/2] ofctl_v1_2/3: fix tcp_dst/src match fields

2014-07-28 Thread FUJITA Tomonori
On Mon, 28 Jul 2014 16:21:38 +0900 Minoru TAKAHASHI wrote: > when enclosed the value of "ip_proto" in double quotes, > following match fields is not set at mod_flow_stats command: > > * tcp_dst, tcp_src > > this patch fixes this problem. > > Reported-by: jalee > Signed-off-by: Minoru TAKAHA

Re: [Ryu-devel] [PATCH] unit test for ofctl_v1_2/3

2014-07-28 Thread FUJITA Tomonori
On Mon, 28 Jul 2014 13:26:04 +0900 Minoru TAKAHASHI wrote: > Signed-off-by: Minoru TAKAHASHI > --- > ryu/tests/unit/lib/test_ofctl.py | 617 > +++ > 1 file changed, 617 insertions(+) > create mode 100644 ryu/tests/unit/lib/test_ofctl.py Great, thanks a lot

Re: [Ryu-devel] [PATCH 1/5] bgp: fix bug when restart neighbor

2014-07-28 Thread FUJITA Tomonori
On Mon, 28 Jul 2014 16:15:26 +0900 ISHIDA Wataru wrote: > > Signed-off-by: ISHIDA Wataru > --- > ryu/services/protocols/bgp/core.py|2 +- > ryu/services/protocols/bgp/peer.py| 14 -- > ryu/services/protocols/bgp/speaker.py |4 ++-- > 3 files changed, 15 insertions

Re: [Ryu-devel] [PATCH 0/8] Ryu BGP filter improvement

2014-07-28 Thread FUJITA Tomonori
On Mon, 28 Jul 2014 18:22:54 +0900 ISHIDA Wataru wrote: > I refined the patches I sent on 22 Jul (not the patches I sent today). > Please discard the past patches. > > The following patches fix some bugs related to out-bound filter and > improve the filter function of Ryu BGP. > > - fix the bug

Re: [Ryu-devel] How to decode switch error messages into human readable form?

2014-07-28 Thread FUJITA Tomonori
On Mon, 28 Jul 2014 17:11:48 +0800 arne_goetje wrote: > Hi list, > > the example code in ofproto_v1_3_parser.py to log error messages only logs > hex numbers. > Example: > > @set_ev_cls(ofp_event.EventOFPErrorMsg, > [HANDSHAKE_DISPATCHER, CONFIG_DISPATCHER, > MAIN_

Re: [Ryu-devel] OpenStack Grizzly with Ryu plugin

2014-07-28 Thread FUJITA Tomonori
Hi, On Sun, 27 Jul 2014 23:15:52 +0200 Thulasi ram Valleru wrote: > What about open flow enabled physical switches Unfortunately, not too. Of course, I'm very happy if someone could add such feature to our OpenStack plugin. Thanks, -

Re: [Ryu-devel] TableFeatureStats not implemented yet

2014-07-28 Thread FUJITA Tomonori
Hi, On Fri, 25 Jul 2014 18:00:02 +0800 arne_goetje wrote: > OFPTableFeatureStats are not implemented yet in ofproto_v1_3_parser.py and > ofproto_v1_4_parser.py. I thought that there are: https://github.com/osrg/ryu/blob/master/ryu/ofproto/ofproto_v1_3_parser.py#L5193 Please let us know if th

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread FUJITA Tomonori
On Thu, 17 Jul 2014 18:18:32 +0900 Minoru TAKAHASHI wrote: > (2014年07月17日 17:41), FUJITA Tomonori wrote: >> On Thu, 17 Jul 2014 17:32:17 +0900 >> Minoru TAKAHASHI wrote: >> >>> Hi,thank you for reporting again. >>> If possible, please send me a log of the test results. >> >> https://github.com

Re: [Ryu-devel] About wildcard in Ryu

2014-07-28 Thread Yuliang Li
It works! Thanks! 2014-07-28 17:59 GMT+08:00 Wei-Li Tang : > Hello, > > You can use a tuple to specify an IP network instead. For example, > > match = parser.OFPMatch(ipv4_dst=('10.0.0.0', '255.255.255.0'), > eth_type=0x0800) > > > 2014-07-28 17:34 GMT+08:00 Yuliang Li : > >> Hi all, >> >> I wan

Re: [Ryu-devel] OpenStack Grizzly with Ryu plugin

2014-07-28 Thread Digambar Patil
Hi FUJITA, Now I am very much familiar with RYU code & its implementation, I have RYU setup ready with openvswitch & debugged all the code. Should I proceed with ryu plugin support for openstack on this blueprint - https://blueprints.launchpad.net/neutron/+spec/ofagent-merge-bridges.

[Ryu-devel] [ANNOUNCE] OF1.4 switch automated test

2014-07-28 Thread FUJITA Tomonori
Hi, We added OF1.4 support to our automated test suite last month. Now the results of our automated tests for OF1.4 are also available at: http://osrg.github.io/ryu/certification.html Thanks, -- Infragistics Professiona

[Ryu-devel] Problem about flow statistics request

2014-07-28 Thread Bo Hu
Hi, When I call the OFPFlowStatsRequest function, I will get several batches of reply from the switch. Are these batches sent altogether after the switch has already find all the matching flow entries? Or each of them is sent instantly when they each is produced? Is there any document to clarify th

Re: [Ryu-devel] Problem about flow statistics request

2014-07-28 Thread FUJITA Tomonori
On Mon, 28 Jul 2014 16:25:03 -0700 Bo Hu wrote: > When I call the OFPFlowStatsRequest function, I will get several batches of > reply from the switch. Are these batches sent altogether after the switch > has already find all the matching flow entries? Or each of them is sent > instantly when they

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread arne_goetje
Fujita-san, src_port and dst_port cannot be empty either. Best Regards! Arne Goetje (???) From: FUJITA Tomonori To: takahashi.mino...@gmail.com, Cc: arne_goe...@accton.com, ryu-devel@lists.sourceforge.net Date: 07/28/2014 08:16 PM Subject:Re: [Ryu-devel] sw test tool: Met

Re: [Ryu-devel] OpenStack Grizzly with Ryu plugin

2014-07-28 Thread YAMAMOTO Takashi
hi, > Hi FUJITA, > > Now I am very much familiar with RYU code & its implementation, > I have RYU setup ready with openvswitch & debugged all the code. Should I > proceed with ryu plugin support for openstack on this blueprint - > https://blueprints.launchpad.net/neutron/+spec/ofagent

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread FUJITA Tomonori
On Tue, 29 Jul 2014 08:56:19 +0800 arne_goetje wrote: > src_port and dst_port cannot be empty either. Oops, how about this? diff --git a/ryu/lib/packet/ipv4.py b/ryu/lib/packet/ipv4.py index a252c70..4da0bcc 100644 --- a/ryu/lib/packet/ipv4.py +++ b/ryu/lib/packet/ipv4.py @@ -79,8 +79,8 @@ clas

Re: [Ryu-devel] How to decode switch error messages into human readable form?

2014-07-28 Thread arne_goetje
Fujita-san, yes, something like that... although using the OpenFlow type and code names (OFPET_HELLO_FAILED, OFPHFC_INCOMPATIBLE) would be enough for me. That's easier to look up in the OpenFlow spec. ;) Maybe consider this as a feature request... bonus points for an additional simple descript

Re: [Ryu-devel] bug report for Ryu-bgp

2014-07-28 Thread ISHIDA Wataru
Hi, Thanks for the report. I sent the patch to fix reset neighbor and already merged. Please try it out. thanks (2014/07/27 17:31), Toshiki Tsuboi wrote: > Hi > > I’ve tested again after adapting the following patch code . > But, this issue has not resolved now . > -> I’m not sure why RPC has d

Re: [Ryu-devel] sw test tool: Meter tests send buggy packets

2014-07-28 Thread Minoru TAKAHASHI
Thank you for comments! I think also modify the ipv6.py as follows. Now, I will create a patch. diff --git a/ryu/lib/packet/ipv4.py b/ryu/lib/packet/ipv4.py index a252c70..4da0bcc 100644 --- a/ryu/lib/packet/ipv4.py +++ b/ryu/lib/packet/ipv4.py @@ -79,8 +79,8 @@ class ipv4(packet_base.PacketBase)

Re: [Ryu-devel] bug report for Ryu-bgp

2014-07-28 Thread Toshiki Tsuboi
Hi I’ve tested in latest master branch . But, it looks this issue has occurred again . regards Toshiki Tsuboi — test result as following - (1) starting My sampleApp ( changes log level from info to debug ) $ sudo ./start_RyuBGPSpeaker.sh ...(snip) DEBUG 2014-07-29 12:18:02,525