[sage-combinat-devel] Re: fast vector partitions algorithm

On Thursday, February 20, 2020 at 2:13:23 PM UTC+1, Denis Sunko wrote: > > > > On Thursday, February 20, 2020 at 2:46:37 AM UTC+1, Travis Scrimshaw wrote: >> >> >> >>> there is nothing wrong with pushing a non-working branch somewhere. >>> This way it's very easy to see what's going wrong there.

[sage-combinat-devel] Re: fast vector partitions algorithm

On Thursday, February 20, 2020 at 2:46:37 AM UTC+1, Travis Scrimshaw wrote: > > > >> there is nothing wrong with pushing a non-working branch somewhere. >> This way it's very easy to see what's going wrong there. >> (I guess it's something to do with importing things) >> > > Also linking it to

[sage-combinat-devel] Re: fast vector partitions algorithm

> >> I have opened a trac ticket >> now. Unfortunately something weird is happening with my local git branch. I >> have copied a file fast_vector_partitions.py with all the source code (it >> works in ordinary Python with 'import

[sage-combinat-devel] Re: fast vector partitions algorithm

On Wednesday, February 19, 2020 at 5:50:46 PM UTC+1, Denis Sunko wrote: > > > I have opened a trac ticket now. > Unfortunately something weird is happening with my local git branch. I have > copied a file fast_vector_partitions.py with all the source

[sage-combinat-devel] Re: fast vector partitions algorithm

I have opened a trac ticket now. Unfortunately something weird is happening with my local git branch. I have copied a file fast_vector_partitions.py with all the source code (it works in ordinary Python with 'import fast_vector_partitions') and

[sage-combinat-devel] Re: fast vector partitions algorithm

I forgot to say you need to work on the "develop" branch. So the steps would be: - open an account on gitlab.com - connect to gitlab.com - fork this project: https://gitlab.com/sagemath/sage/ - modify the "develop" branch in your fork - send a merge request against the "develop" branch

[sage-combinat-devel] Re: fast vector partitions algorithm

Thu 2020-02-13 19:29:57 UTC, Denis Sunko: > > I read some of the developer's guide but it all seemed > rather intimidating, especially for a small change. Alternatively to pushing a branch to Sage's Trac server, you can - open an account on gitlab.com - fork this project on GitLab

[sage-combinat-devel] Re: fast vector partitions algorithm

Thanks to everybody for the friendly replies. > > I could paste the code right here, is that the proper way to do it? How is > the license transferred to Sage? > The way to submit code is to push a git branch to our trac server and then update the ticket to include that branch name under the

[sage-combinat-devel] Re: fast vector partitions algorithm

Thanks to everybody for the friendly replies. I could paste the code right here, is that the proper way to do it? How is the license transferred to Sage? I have a trac account because I once contributed a small bugfix but nothing happened with it, so

[sage-combinat-devel] Re: fast vector partitions algorithm

Hi Denis, That is great that it can have a faster implementation. Do you have the code available for us somewhere? Some thing to also note is that VectorPartitions creates a Sage Element instance instead of a simple Pyhton list, which has extra overhead. However, this should not account for

[sage-combinat-devel] Re: fast vector partitions algorithm

PS: Sorry, I just notice that you did answer my question: It is 60 lines of python code. That shouldn't be a problem to include in the Sage library (i.e., in relevant parts of src/sage/..., maybe in the same location than the current implementation. Do you have a trac account? Best regards,

[sage-combinat-devel] Re: fast vector partitions algorithm

Hi Denis, in the past, sage-combinat-devel was a very active list and certainly the topic of your post fits well, but it seems to me that it would be a good idea to re-post on sage-devel. Did you read the developer's guide? Certainly people could help you contributing the code. In particular