[sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-27 Thread Erik Bray
On Mon, Sep 3, 2018 at 3:53 PM Erik Bray wrote: > > On Tue, Aug 21, 2018 at 10:43 AM Erik Bray wrote: > > > > Hi all, > > > > Earlier this spring Julian Rüth and I sat down and created a mirror of > > Sage's repository over at GitLab: > > > > https://gitlab.com/sagemath/sage > > > > This is in

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-04 Thread Erik Bray
On Tue, Sep 4, 2018 at 3:02 PM Daniel Krenn wrote: > > On 09/04/2018 02:33 PM, Jeroen Demeyer wrote: > > Let me make one important comment (something that I've said before > > though): a large part of what makes the current workflow work is not so > > much Trac itself but our git server and the

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-04 Thread Erik Bray
Keeping in mind that this is still sort of off-topic, in my mind, from the subject at hand which is allowing merge request submissions from GitLab, which still get turned into Trac tickets... On Tue, Sep 4, 2018 at 2:33 PM Jeroen Demeyer wrote: > > Let me make one important comment (something

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-04 Thread Daniel Krenn
On 09/04/2018 02:33 PM, Jeroen Demeyer wrote: > Let me make one important comment (something that I've said before > though): a large part of what makes the current workflow work is not so > much Trac itself but our git server and the "git trac" scripts. > > For example, I very much like the fact

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-04 Thread Dima Pasechnik
On Tue, Sep 4, 2018 at 2:33 PM Jeroen Demeyer wrote: > > Let me make one important comment (something that I've said before > though): a large part of what makes the current workflow work is not so > much Trac itself but our git server and the "git trac" scripts. > > For example, I very much like

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-04 Thread Jeroen Demeyer
Let me make one important comment (something that I've said before though): a large part of what makes the current workflow work is not so much Trac itself but our git server and the "git trac" scripts. For example, I very much like the fact that we have a single git repo where all pull

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-04 Thread Erik Bray
On Mon, Sep 3, 2018 at 5:04 PM Jeroen Demeyer wrote: > > On 2018-09-03 15:53, Erik Bray wrote: > > P.S. If anyone has additional comments, positive or negative, on > > https://trac.sagemath.org/ticket/25914 they would be most appreciated > > That doesn't seem the right ticket. No, that's the

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-03 Thread Dima Pasechnik
On Mon, 3 Sep 2018, 16:54 Erik Bray, wrote: > On Tue, Aug 21, 2018 at 10:43 AM Erik Bray wrote: > > > > Hi all, > > > > Earlier this spring Julian Rüth and I sat down and created a mirror of > > Sage's repository over at GitLab: > > > > https://gitlab.com/sagemath/sage > > > > This is in

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-03 Thread Jeroen Demeyer
On 2018-09-03 15:53, Erik Bray wrote: P.S. If anyone has additional comments, positive or negative, on https://trac.sagemath.org/ticket/25914 they would be most appreciated That doesn't seem the right ticket. -- You received this message because you are subscribed to the Google Groups

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-03 Thread Timo Kaufmann
The unfamiliar trac workflow was a barrier of entry for me, definitely delaying my first contribution. It has some advantages but having gitlab as an option for newcomers would be nice. +1 from me. -- You received this message because you are subscribed to the Google Groups "sage-devel"

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-03 Thread David Roe
On Mon, Sep 3, 2018 at 9:54 AM Erik Bray wrote: > On Tue, Aug 21, 2018 at 10:43 AM Erik Bray wrote: > > What does everyone think? Is there anyone opposed to going ahead and > > opening up merge requests? > > 4x +1 (not including myself, which is an additional +1) > 1x +0 (how I am

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-09-03 Thread Erik Bray
On Tue, Aug 21, 2018 at 10:43 AM Erik Bray wrote: > > Hi all, > > Earlier this spring Julian Rüth and I sat down and created a mirror of > Sage's repository over at GitLab: > > https://gitlab.com/sagemath/sage > > This is in addition to the existing mirror at GitHub, for which we > have no

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-23 Thread Erik Bray
On Wed, Aug 22, 2018 at 10:25 PM Simon King wrote: > > Hi Erik, > > On 2018-08-22, Erik Bray wrote: > > Really the workflow is meant to be you create an issue first, and then > > you create one or more pull requests to resolve that issue. I am also > > a fan of being able to "elevate" an issue

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-23 Thread Daniel Krenn
On 08/23/2018 11:15 AM, Dima Pasechnik wrote: > github has a command line tool, called hub, allowing one to e.g. create pull > requests and issues, without using a browser. > https://hub.github.com/hub-pull-request.1.html > https://hub.github.com/hub-issue.1.html > > I don't know whether gitlab

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-23 Thread Dima Pasechnik
Simon, a very quick correspondence between trac and github/lab terms is as follows: trac ticket, no git branch - issue trac ticket, with a git branch - pull (merge, on gitlab) request github has a command line tool, called hub, allowing one to e.g. create pull requests and issues, without

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-22 Thread Simon King
Hi Erik, On 2018-08-22, Erik Bray wrote: > Really the workflow is meant to be you create an issue first, and then > you create one or more pull requests to resolve that issue. I am also > a fan of being able to "elevate" an issue to a pull request. This is > possible to do on GitHub through

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-22 Thread Erik Bray
On Wed, Aug 22, 2018 at 11:08 AM Simon King wrote: > > Tue 2018-08-21 08:43:19 UTC, Erik Bray: > > What does everyone think? Is there anyone opposed to going ahead and > > opening up merge requests? > > Is the plan to successively reduce the usage of our current trac system > and completely move

Re: [sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-22 Thread Erik Bray
On Tue, Aug 21, 2018 at 6:47 PM Eric Gourgoulhon wrote: > > Hi, > > Le mardi 21 août 2018 10:43:19 UTC+2, Erik Bray a écrit : >> >> >> Why GitLab? In short, we felt it would likely be more acceptable to >> most members of the Sage community; this was a feeling we had even >> before the

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-22 Thread Dima Pasechnik
No, I don't think this is the plan. Note also that "moving to gitlab" might mean two rather different things (on the surface they might look similar) * using gitlab's servers * self-host gitlab The latter case this would mean replacing trac, which does not age too well, as we see, with

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-22 Thread Simon King
Tue 2018-08-21 08:43:19 UTC, Erik Bray: > What does everyone think? Is there anyone opposed to going ahead and > opening up merge requests? Is the plan to successively reduce the usage of our current trac system and completely move to gitlab? In that case I would be rather reluctant. Best

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-21 Thread Samuel Lelievre
Tue 2018-08-21 08:43:19 UTC, Erik Bray: > What does everyone think? Is there anyone opposed to going ahead and > opening up merge requests? Big +1 to going ahead with this. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-21 Thread Eric Gourgoulhon
Hi, Le mardi 21 août 2018 10:43:19 UTC+2, Erik Bray a écrit : > > Why GitLab? In short, we felt it would likely be more acceptable to > most members of the Sage community; this was a feeling we had even > before the Microsoft's acquisition of GitHub was announced. First of > all, GitLab is

[sage-devel] Re: Enabling Merge Requests from GitLab

2018-08-21 Thread Erik Bray
Forgot to attach screenshot. On Tue, Aug 21, 2018 at 10:43 AM Erik Bray wrote: > > Hi all, > > Earlier this spring Julian Rüth and I sat down and created a mirror of > Sage's repository over at GitLab: > > https://gitlab.com/sagemath/sage > > This is in addition to the existing mirror at GitHub,