Re: [sage-devel] Re: computing a graph diameter

2013-12-10 Thread Nathann Cohen
Yooo !! Ahahaha. Okay okay. Well, then tell me when you feel sufficiently at ease with git to review patches, and you'll have that patch two hours from then :-D Okay, even though I didn't hear anything from you since, the ticket is there and ready :

[sage-devel] Re: computing a graph diameter

2013-12-06 Thread Christian Stump
Hi Nathann, So yeah. This stupid problem with the diameter will go away, I swear. A couple of patches, things like that. I thought 65536 would be okay for Sage but even I need to create larger graphs sometimes. Plus it's shameful to have errors like that. I do see that you are

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Nathann Cohen
Y !! I do see that you are constantly working hard on patches, and also that the switch to git is holding things off a bit (I must confess that I haven't written or reviewed a patch in the past months, so I am the last to push things forward currently...). Anyway, do you see a

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Christian Stump
Hi, - Try networkx : sage: import networkx sage: g=graphs.PetersenGraph().networkx_graph() sage: networkx.diameter(g) 2 - You tell me that you will review the patch, and you have it in a couple of hours at most. Of course the second way out is the only one that actually

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Nathann Cohen
Yoo !! Thanks for offering -- I can try to review it. (In the old world, I'd say I can certainly review it,) But I first have to dig through the documentation of how to review a patch. But I will try doing so then... HMm... It's not exactly a yes, nor exactly a no... :-P

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Christian Stump
HMm... It's not exactly a yes, nor exactly a no... :-P This is the most certain yes you can hope for from someone who doesn't know how to achieve the task bouded to the yes. timeit repeats many times the same command, and sees gives you an idea of the average time. But given what

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Nathann Cohen
Yo !! This is the most certain yes you can hope for from someone who doesn't know how to achieve the task bouded to the yes. Ahahaha. Okay okay. Well, then tell me when you feel sufficiently at ease with git to review patches, and you'll have that patch two hours from then :-D As in

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Nathann Cohen
Yep, that's the problem indeed. The input is converted to a dictionary first, then the graph is created, and that's what eats all this time ^^; Nathann On 6 December 2013 14:17, Nathann Cohen nathann.co...@gmail.com wrote: Yo !! This is the most certain yes you can hope for from

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Andrew
Ahahaha. Okay okay. Well, then tell me when you feel sufficiently at ease with git to review patches, and you'll have that patch two hours from then :-D Actually, reviewing git tickets is easier than in the old world. You need to: 1. Install sage-git: (assuming linux/macosx and

Re: [sage-devel] Re: computing a graph diameter

2013-12-06 Thread Nathann Cohen
To answer a bit more precisely, the behaviour of Graph(edges) and g=Graph; g.add_edges(edges) is not exactly the same. For instance, if you run the second there will never be any multiple edge in your graph, for that is the default behaviour of a Graph() object, built without argument. If, on the

[sage-devel] Re: computing a graph diameter

2013-12-05 Thread Christian Stump
while playing a big with Nathann's implementation http://www.sagemath.org/doc/reference/graphs/sage/graphs/distances_all_pairs.html, I also saw: sage: len(cov) 24024 sage: %time Graph(cov) CPU times: user 3.00 s, sys: 0.04 s, total: 3.04 s Wall time: 2.97 s Graph on 6006 vertices sage: G =

[sage-devel] Re: computing a graph diameter

2013-12-05 Thread Nathann Cohen
Yoo !! Yeah, sorry about this 65536 nodes limitation, it's meaningless (at least for the diameter). This is because the code that computes the diameter also computes larger things, and these largers things have absolutely no meaning for graphs with more than n=65536 nodes