Re: [sage-devel] When is a test not a valid test?

2010-12-06 Thread David Kirkby
On 4 December 2010 05:32, William Stein wst...@gmail.com wrote: On Thu, Dec 2, 2010 at 6:40 PM, David Kirkby david.kir...@onetel.net wrote: It's clear you have the ability to write decent tests, but I think its fair to say there are a lot of Sage developers who have less knowledge of this

Re: [sage-devel] When is a test not a valid test?

2010-12-06 Thread Robert Bradshaw
On Mon, Dec 6, 2010 at 8:01 AM, David Kirkby david.kir...@onetel.net wrote: On 4 December 2010 05:32, William Stein wst...@gmail.com wrote: On Thu, Dec 2, 2010 at 6:40 PM, David Kirkby david.kir...@onetel.net wrote: It's clear you have the ability to write decent tests, but I think its fair

Re: [sage-devel] When is a test not a valid test?

2010-12-03 Thread William Stein
On Friday, December 3, 2010, Johan S. R. Nielsen j.s.r.niel...@mat.dtu.dk wrote: On the topic of verifying tests, I think internal consistency checks are much better, both pedagogically and for verifiability, than external checks against other (perhaps inaccessible) systems. For example, the

Re: [sage-devel] When is a test not a valid test?

2010-12-03 Thread William Stein
On Thu, Dec 2, 2010 at 6:40 PM, David Kirkby david.kir...@onetel.net wrote: On 2 December 2010 18:20, Robert Bradshaw rober...@math.washington.edu wrote: On the topic of verifying tests, I think internal consistency checks are much better, both pedagogically and for verifiability, than

Re: [sage-devel] When is a test not a valid test?

2010-12-02 Thread Robert Bradshaw
On Wed, Dec 1, 2010 at 2:36 PM, William Stein wst...@gmail.com wrote: On Wed, Dec 1, 2010 at 2:25 PM, David Kirkby david.kir...@onetel.net wrote: I do think it would be good to start using nosetest (http://somethingaboutorange.com/mrl/projects/nose/0.11.2/) to automatically run all functions

Re: [sage-devel] When is a test not a valid test?

2010-12-02 Thread David Kirkby
On 2 December 2010 18:20, Robert Bradshaw rober...@math.washington.edu wrote: On the topic of verifying tests, I think internal consistency checks are much better, both pedagogically and for verifiability, than external checks against other (perhaps inaccessible) systems. For example, the

[sage-devel] When is a test not a valid test?

2010-12-01 Thread David Kirkby
I'm somewhat unimpressed by the way some doc tests are constrained. An example was at http://trac.sagemath.org/sage_trac/ticket/10187 where I raised an issue. There was this test: sage: taylor(gamma(1/3+x),x,0,3) -1/432*((36*(pi*sqrt(3) + 9*log(3))*euler_gamma^2 + 27*pi^2*log(3) +

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread David Roe
I disagree that doctests should need to be independently verified. Of course, if we had an arbitrarily large amount of time to write doctests, then it would be a laudible goal. Even now, I think there are situations where it would be reasonable to ask this of the author of a patch: if there was

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread David Kirkby
On 1 December 2010 18:18, David Roe r...@math.harvard.edu wrote: I disagree that doctests should need to be independently verified. I think we will have to agree to differ then. Of course, if we had an arbitrarily large amount of time to write doctests, then it would be a laudible goal.  Even

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread David Roe
So you admit it would improve stage to check the tests. Of course. My argument is that imposing the requirement to have such consistency checks in order to get a positive review will make me less likely to contribute to Sage. If you are going to give an example, how much longer does it take

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread William Stein
On Wed, Dec 1, 2010 at 11:32 AM, David Kirkby david.kir...@onetel.net wrote: On 1 December 2010 18:18, David Roe r...@math.harvard.edu wrote: I disagree that doctests should need to be independently verified. I think we will have to agree to differ then. I agree with David Roe. I also would

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread David Kirkby
On 1 December 2010 20:01, William Stein wst...@gmail.com wrote: On Wed, Dec 1, 2010 at 11:32 AM, David Kirkby david.kir...@onetel.net wrote: On 1 December 2010 18:18, David Roe r...@math.harvard.edu wrote: I disagree that doctests should need to be independently verified. I think we will have

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread William Stein
On Wed, Dec 1, 2010 at 2:25 PM, David Kirkby david.kir...@onetel.net wrote: I do think it would be good to start using nosetest (http://somethingaboutorange.com/mrl/projects/nose/0.11.2/) to automatically run all functions that start with test_ in all files, I suggested 'nose' was added a

Re: [sage-devel] When is a test not a valid test?

2010-12-01 Thread David Kirkby
On 1 December 2010 22:36, William Stein wst...@gmail.com wrote: On Wed, Dec 1, 2010 at 2:25 PM, David Kirkby david.kir...@onetel.net wrote: I do think it would be good to start using nosetest (http://somethingaboutorange.com/mrl/projects/nose/0.11.2/) to automatically run all functions that