Re: [sage-devel] Re: positively reviewed tickets on trac - do they need PRs?

On Thu, 9 Feb 2023, 06:46 'Travis Scrimshaw' via sage-devel, < sage-devel@googlegroups.com> wrote: > So we don't have PR for all of the positive reviewed tickets. They are > just going to be merged? What happens if we found a problem with one of the > +rev tickets and want to change something? >

[sage-devel] GH Notifications

I liked getting emails from trac when changes to tickets I cared about happened. However, I only want emails from notifications related to SageMath. I see that there is a routing to chose which account it will go to. Yet, I don't see a way to say "only from Sage I want email notifications".

[sage-devel] Re: positively reviewed tickets on trac - do they need PRs?

So we don't have PR for all of the positive reviewed tickets. They are just going to be merged? What happens if we found a problem with one of the +rev tickets and want to change something? Best, Travis On Thursday, February 9, 2023 at 8:43:28 AM UTC+9 Volker Braun wrote: > But also: Please

Re: [sage-devel] Github Discussions

Personal feeling is that a lot of people who have Sage *questions* are less likely to have GH accounts. I mean, some will. But a lot won't. So the friction for them would be similar to the other options - though sage-support maybe less so, as probably more people have Google accounts. And

Re: [sage-devel] Re: New wiki at sagemath/sage hosted by GitHub

No, it has not been migrated. We have a ticket for the migration: https://github.com/sagemath/sage/issues/33725 On Wednesday, February 8, 2023 at 5:10:54 PM UTC-8 David Roe wrote: > Has any content from https://wiki.sagemath.org/ been moved to the github > wiki, or is that planned? > David >

Re: [sage-devel] Re: New wiki at sagemath/sage hosted by GitHub

On Thursday, February 9, 2023 at 10:10:54 AM UTC+9 David Roe wrote: Has any content from https://wiki.sagemath.org/ been moved to the github wiki, or is that planned? No. As far as I know, it's lingering at the state of https://github.com/sagemath/sage/issues/33725 David On Thu, Feb 9,

Re: [sage-devel] Re: New wiki at sagemath/sage hosted by GitHub

Has any content from https://wiki.sagemath.org/ been moved to the github wiki, or is that planned? David On Thu, Feb 9, 2023 at 2:08 AM Kwankyu Lee wrote: > The url is > > https://github.com/sagemath/sage/wiki > > -- > You received this message because you are subscribed to the Google Groups >

[sage-devel] Re: New wiki at sagemath/sage hosted by GitHub

The url is https://github.com/sagemath/sage/wiki -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion

[sage-devel] New wiki at sagemath/sage hosted by GitHub

For those who haven't heard the news, We also migrated the wiki pages from Trac to GitHub. The new wiki needs your care and love! -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it,

[sage-devel] Re: positively reviewed tickets on trac - do they need PRs?

But also: Please don't merge branches into develop until it is absolutely necessary for the github transition (issue templates or ci setup) On Tuesday, February 7, 2023 at 6:23:54 PM UTC+1 Dima Pasechnik wrote: > We have positively reviewed tickets on trac - do we need to do > anything, or just

[sage-devel] Re: positively reviewed tickets on trac - do they need PRs?

I'll try to get them merged On Tuesday, February 7, 2023 at 6:23:54 PM UTC+1 Dima Pasechnik wrote: > We have positively reviewed tickets on trac - do we need to do > anything, or just wait for the release manager to merge them? > > Dima > -- You received this message because you are subscribed

Re: [sage-devel] Github Discussions

On 08/02/2023 20:10, Oscar Benjamin wrote: Personally I prefer for user support and discussion fora to be clearly separated from GitHub and to happen somewhere where there is a larger pool of people who can engage more recreationally rather than feeling any burden to respond. Those fora can

Re: [sage-devel] Github Discussions

On Wed, 8 Feb 2023 at 20:20, William Stein wrote: > > Many thanks for sharing this from the *developer* point of view. I'm very > much thinking about this problem entirely from the end-user-of-sage point > of view (i.e., me right now).Did you also encounter problems using > discussions with

Re: [sage-devel] Github Discussions

Oscar, Many thanks for sharing this from the *developer* point of view. I'm very much thinking about this problem entirely from the end-user-of-sage point of view (i.e., me right now).Did you also encounter problems using discussions with sympy from the end user point of view? Glancing at

Re: [sage-devel] fetch from draft PR not working

Thanks! I've just updated the instructions that you linked to. David On Wed, Feb 8, 2023 at 8:56 PM brettpim wrote: > So is this a typo on the > Provisional > workflow on GitHub >

Re: [sage-devel] fetch from draft PR not working

So is this a typo on the Provisional workflow on GitHub instructions? thanks brett

Re: [sage-devel] fetch from draft PR not working

You probably want ```git fetch upstream pull/35008/head:covering_array``` Your fork of Sage (origin) doesn't include all of the PRs from the upstream repository. David On Wed, Feb 8, 2023 at 8:40 PM brettpim wrote: > I have followed the Provisional workflow on GitHub >

[sage-devel] fetch from draft PR not working

I have followed the Provisional workflow on GitHub and I think I have my remotes set up correctly. ```git remote -v``` gives > origing...@github.com:brettpim/sage.git (fetch) > origin

Re: [sage-devel] Github Discussions

On Wed, 8 Feb 2023 at 16:47, William Stein wrote: > > Hi Sage Devs, > > Any thoughts about enabling "Github Discussions" for SageMath on > Github now? I just want to share my experience of this feature being used in the SymPy GitHub repo because I personally think that enabling it was a mistake.

[sage-devel] Github Discussions

Hi Sage Devs, Any thoughts about enabling "Github Discussions" for SageMath on Github now? The tab is already visible, but somebody has to I think fully enable it and do some configuration. https://github.com/sagemath/sage/discussions/landing This can be used much like ask.sagemath.org or

Re: [sage-devel] Merging fix for github CI

On Wed, 8 Feb 2023 at 13:10, David Roe wrote: > > On Wed, Feb 8, 2023 at 12:23 PM 'Martin R' via sage-devel > wrote: >> >> Why would I need write access to the sagemath repo? >> >> I would have thought that I'd "somehow" (no idea how) take over the branch >> and modify it. Or are pull

Re: [sage-devel] Merging fix for github CI

cool, yes! Thank you for your patience! Martin On Wednesday, 8 February 2023 at 14:10:42 UTC+1 David Roe wrote: > On Wed, Feb 8, 2023 at 12:23 PM 'Martin R' via sage-devel < > sage-...@googlegroups.com> wrote: > >> Why would I need write access to the sagemath repo? >> >> I would have thought

Re: [sage-devel] Merging fix for github CI

On Wed, Feb 8, 2023 at 12:23 PM 'Martin R' via sage-devel < sage-devel@googlegroups.com> wrote: > Why would I need write access to the sagemath repo? > > I would have thought that I'd "somehow" (no idea how) take over the branch > and modify it. Or are pull requests directly tied to a specific

[sage-devel] Adding labels to github issues

Yesterday I manually added a bunch of people that I recognized to the sagemath organization triage team on github, which gives people the ability to edit labels. I don't intend to exclude any active Sage developers, so if you want to be able to

Re: [sage-devel] online talk about the github workflow

My recording of the talk is now available at: https://www.youtube.com/watch?v=p3-W43ijTUg Great, thanks! See https://github.com/sagemath/website/issues/453 -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and

Re: [sage-devel] online talk about the github workflow

For people who for some reason cannot get such an address, we can make an exception, on an individual basis (we are not in business of providing free email access, you know) and provide such persons with @sagemath.org emails - email server runs on Unix VM, accessible via ssh and hosted in

Re: [sage-devel] Merging fix for github CI

There must be some misunderstanding, I assume on my part. I *am* on the sagemath/triage team. But for trying and modifying a pull request, I certainly do not want write access to any of the "official" sage branches. I guess it will be best for me

Re: [sage-devel] Question about real names in the new github workflow

On Wed, Feb 8, 2023 at 10:18 AM 'Martin R' via sage-devel wrote: > > (and I am, but I am not willing to invest time into my orcid, unless > convinced otherwise) IIRC, anyone can get an ORCID, it's not for academics only. I have two uses for my own ORCID: 1) easier to handle reviewer

Re: [sage-devel] Merging fix for github CI

On Wed, Feb 8, 2023 at 11:23 AM 'Martin R' via sage-devel wrote: > > Why would I need write access to the sagemath repo? you need to be on certain sagemath org team (in GitHub sense) called "triage" to be able to do meaningful things, such a reviewing/updating, with PRs. At the moment not all

Re: [sage-devel] Merging fix for github CI

Why would I need write access to the sagemath repo? I would have thought that I'd "somehow" (no idea how) take over the branch and modify it. Or are pull requests directly tied to a specific user? In other words, what is the replacement for the following? Alice: git trac create "make sage

Re: [sage-devel] Merging fix for github CI

You need to use upstream (the official sage repo) instead of origin (your fork) to fetch the PR: git fetch upstream pull/PULL-REQUEST-ID/head:LOCAL-BRANCH-NAME see https://github.com/sagemath/trac-to-github/blob/master/docs/Migration-Trac-to-Github.md#for-reviewing-a-change If you don't have

Re: [sage-devel] Merging fix for github CI

Interesting, because the PR page is still the same.for me. I feel so stupid, I'm sorry, I need more help. In particular, I get: martin@convex63:~/sage$ LANG=en git fetch origin pull/34974/head fatal: couldn't find remote ref pull/34974/head (Note that this is not *my* pull request, but

[sage-devel] please give meaningful titles to PRs

please give meaningful titles to PRs - this would allow potential reviewers to see much quicker whether they are qualified to review! -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from

Re: [sage-devel] Merging fix for github CI

On Wed, Feb 8, 2023 at 10:23 AM 'Martin R' via sage-devel wrote: > > Since the failures are > > sage -t --random-seed=130442615951932153031063473470828108756 > sage/schemes/elliptic_curves/ell_curve_isogeny.py # 1 doctest failed > sage -t --random-seed=130442615951932153031063473470828108756 >

Re: [sage-devel] Merging fix for github CI

Since the failures are sage -t --random-seed=130442615951932153031063473470828108756 sage/schemes/elliptic_curves/ell_curve_isogeny.py # 1 doctest failed sage -t --random-seed=130442615951932153031063473470828108756 sage/schemes/elliptic_curves/ell_number_field.py # 2 doctests failed I assume

Re: [sage-devel] Question about real names in the new github workflow

(and I am, but I am not willing to invest time into my orcid, unless convinced otherwise) On Wednesday, 8 February 2023 at 11:16:43 UTC+1 Martin R wrote: > Not every contributor to sage is a researcher. > > On Wednesday, 8 February 2023 at 10:33:12 UTC+1 François Bissey wrote: > >> Never mind

Re: [sage-devel] Question about real names in the new github workflow

Not every contributor to sage is a researcher. On Wednesday, 8 February 2023 at 10:33:12 UTC+1 François Bissey wrote: > Never mind names, in a perfect world I want the orcid of all the > contributors who have one. In that same perfect world all sage > contributors have one. > This is

Re: [sage-devel] Merging fix for github CI

On Wed, 8 Feb 2023, 08:41 'Martin R' via sage-devel, < sage-devel@googlegroups.com> wrote: > I cannot see any "update branch" button on > https://github.com/sagemath/sage/pull/34974 > > Where should I look for it? > This button is somewhere near the ticket status at the bottom - if your base is

Re: [sage-devel] Question about real names in the new github workflow

Never mind names, in a perfect world I want the orcid of all the contributors who have one. In that same perfect world all sage contributors have one. This is scientific output and authorship and uniquely identifying authors is what orcid is for. https://orcid.org/ On 8/02/23 22:16, Dima

Re: [sage-devel] Question about real names in the new github workflow

On Wed, 8 Feb 2023, 08:28 Tobias Diez, wrote: > Wouldn't it be easier to automate (and more respectful to the privacy > concerns of contributors) to simply link to the github handle/profile? > GitHub profiles don't always have real names. > > On Wednesday, 8 February 2023 at 04:51:30 UTC+8

Re: [sage-devel] Merging fix for github CI

I cannot see any "update branch" button on https://github.com/sagemath/sage/pull/34974 Where should I look for it? Martin On Wednesday, 8 February 2023 at 00:32:49 UTC+1 dim...@gmail.com wrote: > On Tue, Feb 7, 2023 at 10:42 PM David Roe wrote: > > > > Thanks Dima! > > > > There is now an

Re: [sage-devel] Question about real names in the new github workflow

I feel that it does make sense to have real names in a scientific environment. I realise that I do not have an argument in favour of this feeling. As Dima pointed out, real names in github are optional. I guess that requesting real names in the github account is a bit of a stretch. On the

Re: [sage-devel] Question about real names in the new github workflow

Wouldn't it be easier to automate (and more respectful to the privacy concerns of contributors) to simply link to the github handle/profile? On Wednesday, 8 February 2023 at 04:51:30 UTC+8 Matthias Koeppe wrote: > We have collected these mappings in >