[sage-devel] Re: Final stretch for 3.1.2 reviews

2008-09-02 Thread John Cremona

I hope I didn't kill #1115's chances by relabelling it from a bug fix
to an enhancement, since I didn't just fix the bug...

The only problem with the current patch is that we found a call to
dumps() crashes on a 64-bit machine but is fine on a 32-bit machine.
Anyone have any idea what might cause that?

John

2008/9/2 mabshoff [EMAIL PROTECTED]:

 Hello folks,

 the end of the 3.1.2 release cycle is near - at least the point where
 we will only merge bug fixes or even critical bug fixes. So if you
 have things sitting in trac waiting to make it in please find somebody
 to review the patch. Please also make sure that the positively
 reviewed patch shows up at report 11 since that is what I use to
 find them. One issue I found today is that that report does not pick
 up ticket if there is more than one space between positive and
 reviewed.

 Report 12 in trac are tickets that need work and many of them have
 been sitting there for a while. So if one of those belongs to you
 please have a look.

 Cheers,

 Michael
 


--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---



[sage-devel] Re: Final stretch for 3.1.2 reviews

2008-09-02 Thread mabshoff

On Sep 2, 6:43 am, John Cremona [EMAIL PROTECTED] wrote:

Hi John,

 I hope I didn't kill #1115's chances by relabelling it from a bug fix
 to an enhancement, since I didn't just fix the bug...

Nope, code from that area is high level and usually does introduce no
failures that are platform specific. And we are still pre-rc0, which
will probably take 24 or so hours to get out.

 The only problem with the current patch is that we found a call to
 dumps() crashes on a 64-bit machine but is fine on a 32-bit machine.
 Anyone have any idea what might cause that?

No clue. Can you do a sage -ba on the tree and see of the problem
goes away? What does the backtrace from gdb say? Are there any weak
references involved in that code? We have been seeing oddities with
weak references and Cython.

 John

Cheers,

Michael
--~--~-~--~~~---~--~~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~--~~~~--~~--~--~---