Re: [sage-devel] Re: What is the correct way to patch packages that use autotools?

[Erik Bray]

On Thu, Nov 17, 2016 at 5:28 PM, Jean-Pierre Flori  wrote:
>
>
> On Thursday, November 17, 2016 at 5:27:15 PM UTC+1, Erik Bray wrote:
>>
>> Hmm, okay.  I am using my system's autoreconf.  For the sage autotools
>> is that just an optional package I need to install?
>
> Yes.

Okay, well, it turns out Singular requires automake 1.15 which is
*not* included yet in the Sage autotools spkg.  So now the question
becomes: How do I update the package to include automake 1.15?

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Re: [sage-devel] Re: What is the correct way to patch packages that use autotools?

[Erik Bray]

On Mon, Nov 21, 2016 at 4:09 PM, Erik Bray  wrote:
> On Thu, Nov 17, 2016 at 5:28 PM, Jean-Pierre Flori  wrote:
>>
>>
>> On Thursday, November 17, 2016 at 5:27:15 PM UTC+1, Erik Bray wrote:
>>>
>>> Hmm, okay.  I am using my system's autoreconf.  For the sage autotools
>>> is that just an optional package I need to install?
>>
>> Yes.
>
> Okay, well, it turns out Singular requires automake 1.15 which is
> *not* included yet in the Sage autotools spkg.  So now the question
> becomes: How do I update the package to include automake 1.15?

(Answering my own question: By updating the version-list file and
re-running spkg-src to make a new upstream tarball I think I can do
this.  So I'll ask back here if I have any further questions.
Meanwhile, assuming that works, should I make a ticket to update this
package?)

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Re: [sage-devel] Re: What is the correct way to patch packages that use autotools?

[Erik Bray]

On Thu, Nov 17, 2016 at 5:28 PM, Jean-Pierre Flori  wrote:
>
>
> On Thursday, November 17, 2016 at 5:27:15 PM UTC+1, Erik Bray wrote:
>>
>> Hmm, okay.  I am using my system's autoreconf.  For the sage autotools
>> is that just an optional package I need to install?
>
> Yes.

This turned out to be less than straightforward since the config.guess
scripts on some of the older autotools did not work on 64-bit Cygwin:

https://trac.sagemath.org/ticket/21896

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Re: [sage-devel] Re: What is the correct way to patch packages that use autotools?

[Jean-Pierre Flori]

On Thursday, November 17, 2016 at 5:27:15 PM UTC+1, Erik Bray wrote:

> Hmm, okay.  I am using my system's autoreconf.  For the sage autotools 
> is that just an optional package I need to install? 
>
Yes. 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

Re: [sage-devel] Re: What is the correct way to patch packages that use autotools?

[Erik Bray]

On Thu, Nov 17, 2016 at 5:25 PM, Jean-Pierre Flori  wrote:
>
>
> On Thursday, November 17, 2016 at 5:11:23 PM UTC+1, Erik Bray wrote:
>>
>> Hi,
>>
>> I'm in the process of patching a couple spkgs that use autotools build
>> systems.  I've done this in the past in Sage but it's never been quite
>> clear to me what the correct process should be.  In this particular
>> case I am patching both confgure.ac and Makefile.am files.
>>
>> Should I add just patches for the input files, or should I also
>> include patches for the output files (configure, Makefile(.in), etc.)?
>
> I'd say both...
>>
>>  Should I merge them all together or keep them separate?
>>
> ...in separate patches, the one to "source" files not being applied.

Ok, that's what I thought.  I think in the past I was asked to do the same.

>> Further, for patching the generated files, what's a good way to go
>> about that?  If I don't have the exact versions of autoconf and
>> automake as were used in the upstream sources then I can wind up with
>> a lot of unrelated changes in the generated files.  How are you
>> normally dealing with that?
>>
> There is a autotools spkg.
> If you  autoreconf from a sage shell it should then use matching versions of
> the autostuff.

Hmm, okay.  I am using my system's autoreconf.  For the sage autotools
is that just an optional package I need to install?

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: What is the correct way to patch packages that use autotools?

[Jean-Pierre Flori]

On Thursday, November 17, 2016 at 5:26:39 PM UTC+1, Jean-Pierre Flori wrote:
>
>
>
> On Thursday, November 17, 2016 at 5:25:24 PM UTC+1, Jean-Pierre Flori 
> wrote:
>>
>>
>>
>> On Thursday, November 17, 2016 at 5:11:23 PM UTC+1, Erik Bray wrote:
>>>
>>> Hi, 
>>>
>>> I'm in the process of patching a couple spkgs that use autotools build 
>>> systems.  I've done this in the past in Sage but it's never been quite 
>>> clear to me what the correct process should be.  In this particular 
>>> case I am patching both confgure.ac and Makefile.am files. 
>>>
>>> Should I add just patches for the input files, or should I also 
>>> include patches for the output files (configure, Makefile(.in), etc.)? 
>>>
>> I'd say both... 
>>
>>>  Should I merge them all together or keep them separate? 
>>>
>>> ...in separate patches, the one to "source" files not being applied.
>>
> But submitted upstream :)
>
(And put it in a subdirectory of the patch directory in the sage tree.) 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: What is the correct way to patch packages that use autotools?

[Jean-Pierre Flori]

On Thursday, November 17, 2016 at 5:25:24 PM UTC+1, Jean-Pierre Flori wrote:
>
>
>
> On Thursday, November 17, 2016 at 5:11:23 PM UTC+1, Erik Bray wrote:
>>
>> Hi, 
>>
>> I'm in the process of patching a couple spkgs that use autotools build 
>> systems.  I've done this in the past in Sage but it's never been quite 
>> clear to me what the correct process should be.  In this particular 
>> case I am patching both confgure.ac and Makefile.am files. 
>>
>> Should I add just patches for the input files, or should I also 
>> include patches for the output files (configure, Makefile(.in), etc.)? 
>>
> I'd say both... 
>
>>  Should I merge them all together or keep them separate? 
>>
>> ...in separate patches, the one to "source" files not being applied.
>
But submitted upstream :)

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.

[sage-devel] Re: What is the correct way to patch packages that use autotools?

[Jean-Pierre Flori]

On Thursday, November 17, 2016 at 5:11:23 PM UTC+1, Erik Bray wrote:
>
> Hi, 
>
> I'm in the process of patching a couple spkgs that use autotools build 
> systems.  I've done this in the past in Sage but it's never been quite 
> clear to me what the correct process should be.  In this particular 
> case I am patching both confgure.ac and Makefile.am files. 
>
> Should I add just patches for the input files, or should I also 
> include patches for the output files (configure, Makefile(.in), etc.)? 
>
I'd say both... 

>  Should I merge them all together or keep them separate? 
>
> ...in separate patches, the one to "source" files not being applied.
 

> Further, for patching the generated files, what's a good way to go 
> about that?  If I don't have the exact versions of autoconf and 
> automake as were used in the upstream sources then I can wind up with 
> a lot of unrelated changes in the generated files.  How are you 
> normally dealing with that? 
>
> There is a autotools spkg.
If you  autoreconf from a sage shell it should then use matching versions 
of the autostuff.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.