Re: [sage-devel] Trac downtime for upgrades

2018-05-16 Thread Sébastien Labbé
Thanks for the explanation.

Sébastien

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] Trac downtime for upgrades

2018-05-16 Thread Erik Bray
On Wed, May 16, 2018 at 11:49 AM, Sébastien Labbé  wrote:
>
>
> On Wednesday, May 16, 2018 at 11:16:59 AM UTC+2, Jeroen Demeyer wrote:
>>
>> Thanks Erik!
>>
>> After using it for just a few days, the git Trac plugin seems to work
>> very well and it's a clear improvement.
>
>
> Sorry, I just can't see what is the improvement. Erik just said "This is
> part of a performance enhancement that delays creating merge
> previews until the merge preview is actually visited." Before and after, the
> merge preview is done with the latest beta right? So what is the
> improvement?

Well, if it's not *worse* at least then why even ask? :)  (In fact I
have already found a few bugs in the new version of the plugin, but
thankfully I seem to have caught them myself and pushed patches before
anyone else bothered me about it :)

A lot of the improvement is internal and not immediately user-visible.
The caching of merge previews is more fine-grained in such a way that
cache invalidation leads to less overall performance degradation.

At the user-visible level you can see that you have to actually click
on the merge preview link before it gets generated--this means faster
page loads.  As a second stage I was going to add some JS to still
asynchronously request the merge preview, so that by the time one
clicks the link it's already ready (or found to be me unmergeable).
That would still be better than the previous situation where page
loads of tickets were always slowed down by merge preview generation
any time some new changes were pushed to a branch, or the develop
branch was updated.

Also on the internal end the new version of the plugin laid the
groundwork for merge previews against different base branches (part of
the reason for the database upgrade; the other reason was a new schema
for storing SSH keys better which itself lays the groundwork for a
better UI for managing SSH keys).  Those features will come in another
update soon, which will be quick an easy since I think all the
necessary database migration is done for now.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] Trac downtime for upgrades

2018-05-16 Thread Sébastien Labbé


On Wednesday, May 16, 2018 at 11:16:59 AM UTC+2, Jeroen Demeyer wrote:
>
> Thanks Erik! 
>
> After using it for just a few days, the git Trac plugin seems to work 
> very well and it's a clear improvement. 
>

Sorry, I just can't see what is the improvement. Erik just said "This is 
part of a performance enhancement that delays creating merge 
previews until the merge preview is actually visited." Before and after, 
the merge preview is done with the latest beta right? So what is the 
improvement?

Sébastien

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] Trac downtime for upgrades

2018-05-16 Thread Jeroen Demeyer

Thanks Erik!

After using it for just a few days, the git Trac plugin seems to work 
very well and it's a clear improvement.


--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-devel] Trac downtime for upgrades

2018-05-11 Thread Jeroen Demeyer
I wouldn't worry about it too much especially if you expect the downtime 
to be relatively short. Just do the upgrade...


--
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To post to this group, send email to sage-devel@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-devel.
For more options, visit https://groups.google.com/d/optout.