Re: [sage-release] Sage 8.3.beta0 released

2018-05-16 Thread John Cremona
On 16 May 2018 at 12:06, Samuel Lelièvre  wrote:

> Would changing the doctest from
>
> sage: pol.roots(multiplicities=False, proof=False)
>
> to
>
> sage: sorted(pol.roots(multiplicities=False, proof=False))
>
> solve this?
>

I think that in other places where roots are returned, the functino which
computes the roots does the sorting, so then it is not neccessary to use
sorted() in the doctest; this also has the advantage that if the
root-finding algorithm changes, that output does not change even when the
roots are now found in a different order.


>
> 2018-05-16 10:16 GMT+02:00 Dima Pasechnik :
>
>> in this case doctest basically compares strings,
>> obtained from the list of roots.
>> Order of the latter is not important.
>> By right, one should compare sets, not lists.
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "sage-release" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to sage-release+unsubscr...@googlegroups.com.
>> To post to this group, send email to sage-release@googlegroups.com.
>> Visit this group at https://groups.google.com/group/sage-release.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-release" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-release+unsubscr...@googlegroups.com.
> To post to this group, send email to sage-release@googlegroups.com.
> Visit this group at https://groups.google.com/group/sage-release.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-release] Sage 8.3.beta0 released

2018-05-16 Thread Samuel Lelièvre
Would changing the doctest from

sage: pol.roots(multiplicities=False, proof=False)

to

sage: sorted(pol.roots(multiplicities=False, proof=False))

solve this?

2018-05-16 10:16 GMT+02:00 Dima Pasechnik :

> in this case doctest basically compares strings,
> obtained from the list of roots.
> Order of the latter is not important.
> By right, one should compare sets, not lists.
>
> --
> You received this message because you are subscribed to the Google Groups
> "sage-release" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sage-release+unsubscr...@googlegroups.com.
> To post to this group, send email to sage-release@googlegroups.com.
> Visit this group at https://groups.google.com/group/sage-release.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-release] Sage 8.3.beta0 released

2018-05-16 Thread Dima Pasechnik
in this case doctest basically compares strings,
obtained from the list of roots.
Order of the latter is not important.
By right, one should compare sets, not lists.

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-release] Sage 8.3.beta0 released

2018-05-15 Thread Justin C. Walker

> On May 15, 2018, at 17:07 , Dima Pasechnik  wrote:
> 
> 
> 
> On Tuesday, May 15, 2018 at 9:34:55 PM UTC+1, Justin C. Walker wrote:
> 
> > On May 9, 2018, at 11:44 , Volker Braun  wrote: 
> > 
> > As always, you can get the latest beta version from the "develop" git 
> > branch. Alternatively, the self-contained source tarball is at 
> > http://www.sagemath.org/download-latest.html 
> 
> Built from a fresh clone/update of the develop branch on macOS 10.11.6 
> (Quad-core Core i7) w/o problems,.  One problem in testing (‘ptestlong’): 
> 
> sage -t --warn-long 89.1 src/sage/rings/complex_arb.pyx  # 1 dockets failed 
> 
> When run by hand, I got the same failure.  Log from the single run attached. 

> Looks OK, just a different order of data in the output, no?

Almost - there’s a slight difference in wording, it appears.  Also, is the 
doctest apparatus supposed to detect order differences?

Justin

--
Justin C. Walker
Curmudgeon-at-large
Director
Institute for the Absorption of Federal Funds

186,000 Miles per Second
Not just a good idea:
  it's the law!


-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-release] Sage 8.3.beta0 released

2018-05-15 Thread Dima Pasechnik


On Tuesday, May 15, 2018 at 9:34:55 PM UTC+1, Justin C. Walker wrote:
>
>
> > On May 9, 2018, at 11:44 , Volker Braun  > wrote: 
> > 
> > As always, you can get the latest beta version from the "develop" git 
> branch. Alternatively, the self-contained source tarball is at 
> http://www.sagemath.org/download-latest.html 
>
> Built from a fresh clone/update of the develop branch on macOS 10.11.6 
> (Quad-core Core i7) w/o problems,.  One problem in testing (‘ptestlong’): 
>
> sage -t --warn-long 89.1 src/sage/rings/complex_arb.pyx  # 1 dockets 
> failed 
>
> When run by hand, I got the same failure.  Log from the single run 
> attached. 
>
> Looks OK, just a different order of data in the output, no?

> Justin
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.


Re: [sage-release] Sage 8.3.beta0 released

2018-05-15 Thread Justin C. Walker

> On May 9, 2018, at 11:44 , Volker Braun  wrote:
> 
> As always, you can get the latest beta version from the "develop" git branch. 
> Alternatively, the self-contained source tarball is at 
> http://www.sagemath.org/download-latest.html

Built from a fresh clone/update of the develop branch on macOS 10.11.6 
(Quad-core Core i7) w/o problems,.  One problem in testing (‘ptestlong’):

sage -t --warn-long 89.1 src/sage/rings/complex_arb.pyx  # 1 dockets failed

When run by hand, I got the same failure.  Log from the single run attached.

Justin

-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.


complex_arb.log
Description: Binary data


--
Justin C. Walker, Curmudgeon-At-Large
Director
Institute for the Enhancement of the Director's Income

"Weaseling out of things is what separates us from the animals.
 Well, except the weasel."
  - Homer J Simpson



-- 
You received this message because you are subscribed to the Google Groups 
"sage-release" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-release+unsubscr...@googlegroups.com.
To post to this group, send email to sage-release@googlegroups.com.
Visit this group at https://groups.google.com/group/sage-release.
For more options, visit https://groups.google.com/d/optout.