Re: [Samba] (Trying) to understand Print properties saving
From: Alessandro Dentella [mailto:san...@e-den.it] Sent: 01 January 2013 17:01 Hi, some weeks ago I wrote to this list about a problem I have saving print properties (samba 3.4.7 - ubuntu-lucid + XP-pro) I never managed to solve it, I also tried with samba 3.6+ (Ubuntu precise) but had aother problems I wrote about in this list ending opening a bug [1]. Now I had to go back to my 3.4.7 installation. I'd like at least to bettere understand how print properties work so that I can cope better with the situation. In my setup the drivers are distributed by the server, client do realize they need the driver and server correctly serves them, the problem is that the page format is alwayes set to 'letter' rather than 'A4'. I have roaming profiles. I really need to fix this even thought some workaround. I can't answer the other questions, but I do have some instructions for setting the default paper size (note these instructions were written for XP): After you click Finish and the driver is copied, select Properties on the printer. Say No when it asks if you want to install the driver. Go to the Advanced tab and select the driver from the dropdown list. Click OK and the name of the printer will change to show the driver you just installed. Right-click the printer again. On the General Tab set it back to its original name. Select Properties again and go back into the Advanced tab. Now there is a new option Printing Defaults. Click Advanced on the Printing Defaults page. NOW you can choose the default options for your users - like A4 paper size. Nasty, isn't it? Can someone tell me which are the components that store the print properties? If this is already explained somewhere, please give me the URL, I wasn't able to find it. 1. If I browse \\server\(server and fax) and I configure properties, where are the changes saved? 2. When an end user configures the printer where does ther properties should go (I have roaming profiles)? In the profile? in a registry? 3. If the domain/local Administrator changes the properties in the printer on the client via settings | printers how does that change relate to settings in 1 and 2? 4. In a working setup, is there a way to force the paper format *after* a user has already logged in and changed the properties? thanks in advance for any explanation thanks sandro *:-) [1] https://bugzilla.samba.org/show_bug.cgi?id=9468 -- Sandro Dentella *:-) http://www.reteisi.org Soluzioni libere per le scuole http://sqlkit.argolinux.orgSQLkit home page - PyGTK/python/sqlalchemy -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba ADDS DC krb5 and samba_nsupdate
On Wed, 2013-01-02 at 03:40 +, Felipe wrote: OK now I tried to join again I saw this messages descriptor_sd_propagation_recursive: DC=DomainDnsZones,DC=*,DC=de not found under DC=*,DC=de descriptor_sd_propagation_recursive: DC=ForestDnsZones,DC=*,DC=de not found under DC=*,DC=de Unable to find group id for BIND, set permissions to sam.ldb* files manually Unable to find group id for BIND, set permissions to sam.ldb* files manually bind is running as user root Given your errors, you should check that bind can access the database and dns.keytab correctly. Are you running 9.8 or 9.9? Andrew Bartlett -- Andrew Bartletthttp://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Windows 7 adding printer
Hello All, Today I just edited below line after that x64 not advertising any more after revert the change. spoolss: architecture = Windows NT x86 Previous was... spoolss: architecture = Windows x64 Thanks Regards, Arun Sasi Venmalassery - Sr. Engineer - Server Management (UNIX), Wipro Ltd (Dubai) |Mob: +971 566489491 | E: arun.sa...@wipro.com From: Arun Sasi V (WI01 - GIS) Sent: Thursday, December 06, 2012 10:50 AM To: David Disseldorp Cc: samba@lists.samba.org Subject: RE: [Samba] Windows 7 adding printer Hello David, Thanks alot it works for me, but in my infra I have Windows XP 32 bit and Windows 7 64 bit. how to make these two can upload the drivers. Thanks From: David Disseldorp [dd...@suse.de] Sent: Wednesday, December 05, 2012 3:36 PM To: Arun Sasi V (WI01 - GIS) Cc: samba@lists.samba.org Subject: Re: [Samba] Windows 7 adding printer Hi, On Wed, 5 Dec 2012 08:35:54 + arun.sa...@wipro.com wrote: Hello Team, I am unable to add/upload Windows 7 64 bit print driver from Windows 7 64 bit laptop. It is giving me following error. The folder you specified doesn't contain a compatible software driver for your device. If the folder contains a driver,make sure it is designed to work with Windows for x64-based system. Is there any work around ? Is the [print$] path populated with a writeable x64 directory? The Samba spoolss server presents itself as 32-bit (Windows NT x86) by default, but you should still be able to upload 64-bit drivers via the \\$server\printer - server properties dialogue box. Alternatively, the spoolss server can advertise itself as 64-bit with: [global] spoolss: architecture = Windows x64 Cheers, David -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] samba4 anonymous ldap search
-Original Message- From: samba-boun...@lists.samba.org [mailto:samba-boun...@lists.samba.org] On Behalf Of Hannu Tikka Sent: Wednesday, 2 January 2013 6:24 PM To: samba@lists.samba.org Subject: [Samba] samba4 anonymous ldap search I'm using Version 4.1.0pre1-GIT-e4218e4 samba4 server. It allows nicely anonymous ldap searches, latest versions does not allow that. I have followed Microsofts kb326690 and kb320528 guides, but it seems not helpful. Is the anonymous ldap possible anymore? regards Hannu -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba Hannu, There was a change within a fortnight of the samba 4.0.0 release affecting ACL controls that restricted anonymous LDAP searches, if you are able to review the mailing lists for samba and samba-technical, you'll find the details. The intent was to restrict access to confidential password information, a good thing. I recall a release/upgrade is scheduled for January 22 which may provide more granular control for ACL's. Karolin Seeger's provides release schedule guidance at http://wiki.samba.org/index.php/Release_Planning_for_Samba_4.0 Regards, Dewayne -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Windows 8 and roaming profiles hosted on Samba - NO ONE does this?
On 20.12.2012 20:59, Nick wrote: After searching Google for many days/weeks, I've discovered that apparently NO ONE on the planet uses Windows 8 w/ roaming profiles and Samba! This is wrong. In fact I do. Or more preciesely I have tried to use Samba 3.6 with Windows 8 Roaming Profiles. In fact I did run into exactly the same problems and reported my issues here: https://lists.samba.org/archive/samba/2012-September/169080.html I have provided full debug logs as well but got no single reply yet. Looks like Roaming Profiles are not very widely used. For me this is still one of the best options to make sure user data is backed up. I am also using it for mandatory profiles in educational environment in order to enforce clean profiles on each login. Currently with Windows 8 it seems to be broken. Maybe it's related to SMB2 but Windows 8 reports The parameter is incorrect on a number of files during upload. In fact the files are stored on the server and then they disappear entirely again. I discovered that on Windows 8 there are some issues copying folders with mapped names in desktop.ini (everywhere where LocalizedResourceName attribute is used) and thought it might be related. But as said I did not get any response yet. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] (Trying) to understand Print properties saving
On Wed, Jan 02, 2013 at 11:08:40AM +, Moray Henderson wrote: From: Alessandro Dentella [mailto:san...@e-den.it] Sent: 01 January 2013 17:01 Hi, some weeks ago I wrote to this list about a problem I have saving print properties (samba 3.4.7 - ubuntu-lucid + XP-pro) I never managed to solve it, I also tried with samba 3.6+ (Ubuntu precise) but had aother problems I wrote about in this list ending opening a bug [1]. Now I had to go back to my 3.4.7 installation. I'd like at least to bettere understand how print properties work so that I can cope better with the situation. In my setup the drivers are distributed by the server, client do realize they need the driver and server correctly serves them, the problem is that the page format is alwayes set to 'letter' rather than 'A4'. I have roaming profiles. I really need to fix this even thought some workaround. I can't answer the other questions, but I do have some instructions for setting the default paper size (note these instructions were written for XP): After you click Finish and the driver is copied, select Properties on the printer. Say No when it asks if you want to install the driver. Go to the Advanced tab and select the driver from the dropdown list. Click OK and the name of the printer will change to show the driver you just installed. Right-click the printer again. On the General Tab set it back to its original name. Select Properties again and go back into the Advanced tab. Now there is a new option Printing Defaults. Click Advanced on the Printing Defaults page. NOW you can choose the default options for your users - like A4 paper size. Nasty, isn't it? Thanks for the reply but I already did all this as explained in my first post to this list [1]. As explained there I think it's related to this bug [2], but when moved to precise I met others problems that made be open this bug [3]... I'm not just asking to solve my problem but to explain the machinary so that I can figure out a possible further debug step. I really don't know where to ask for these info if not on the samba ml... So I represent the questions, hoping somene who knows the answer and didn't read the others mail can follo on this one... Can someone tell me which are the components that store the print properties? If this is already explained somewhere, please give me the URL, I wasn't able to find it. 1. If I browse \\server\(server and fax) and I configure properties, where are the changes saved? 2. When an end user configures the printer where does ther properties should go (I have roaming profiles)? In the profile? in a registry? 3. If the domain/local Administrator changes the properties in the printer on the client via settings | printers how does that change relate to settings in 1 and 2? 4. In a working setup, is there a way to force the paper format *after* a user has already logged in and changed the properties? [1] https://lists.samba.org/archive/samba/2012-December/170314.html [2] https://bugzilla.samba.org/show_bug.cgi?id=6727 [3] https://bugzilla.samba.org/show_bug.cgi?id=9468 -- Sandro Dentella *:-) http://www.reteisi.org Soluzioni libere per le scuole http://sqlkit.argolinux.orgSQLkit home page - PyGTK/python/sqlalchemy -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Windows Authentication
How are you trying to connection? From a Windows 7 machine? A Windows XP machine? Are you using the net use command in windows? On 01/01/13 14:36, samba.1...@9ox.net wrote: Greetings Samba: I thought I knew something about servers and networks but Samba has me stumped... I built a clean Fedora 17 server, disabled the firewall and then followed install instructions from http://www.howtoforge.com/fedora-17-samba-standalone-server-with-tdbsam-backend. When I try to connect I receive windows security (login) screen but no mater what I do, I never connect. I am on the same network, have tried verified my workgroups match, but do not see samba on the browser and can not get map to drive to get past UID and PW. I have tried host name and IP address for domain portion. Any suggestions on where to look next? Gerald -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] [solved] SMB2 CREATE + ACCESS_SYSTEM_SECURITY
On Tue, Dec 18, 2012 at 12:24:04PM -0600, Steve Tice wrote: Can anybody provide the expected response to an SMB2 CREATE request that includes ACCESS_SYSTEM_SECURITY in the DesiredAccess mask? I’m particularly interested in cases where the SMB client is connected as an authenticated user with administrative (superuser) privileges on the share, and has made the request on a directory. Should such a client expect full (read/change) access to the SACL (under any conditions)? The question above is theoretical in nature. Practically speaking, does any version of the Samba server respond correctly to the request described above? I have a Windows application that makes such a request, and have tested it against Samba server versions 3.5.10-125.el6 and 3.6.7. I keep seeing a response of NT_STATUS_PRIVILEGE_NOT_HELD, and think that's not the correct response when the client has superuser privileges - but perhaps my expectation is wrong. If I make the same request while connected to a share on a Windows server, the response is NT_STATUS_OK. Is there a Samba server configuration change I could make that would affect the behavior? Is there any setup work to do prior to sending the SMB2 CREATE request (for example, adding a privilege)? With all humility, please accept my apology for making a false claim on this topic. In my test bed, another factor (specifically a FUSE implementation) was found to be the root cause of the unexpected server behavior. With the root cause now corrected, my test bed with Samba 3.5.10-125.el6 is behaving as expected and is passing the previously posted test case. To summarize, there is no Samba bug associated with clients that want SYSTEM_SECURITY access to a share. -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
[Samba] .recycle folder not showing up
I have configured vfs_recycle because a team member deleted a file and could not recover it. Whenever I delete a folder under the share it is configured for, the .recycle folder does not appear as expected. Does anyone have experience with such an issue??? Much appreciated. Thank You, -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] Samba ADDS DC krb5 and samba_nsupdate
bind-9.9.2-P1 how can I check it? It have access to read dig give me results of my windows domain. I tried to set rights to 777 of the private directory with option -R samba_dnsupdate --verbose --all-names say dns_tkey_negotiategss: TKEY is unacceptable greetings -Mensaje original- De: Andrew Bartlett [mailto:abart...@samba.org] Enviado el: miércoles, 02 de enero de 2013 12:22 Para: samba CC: samba@lists.samba.org Asunto: Re: [Samba] Samba ADDS DC krb5 and samba_nsupdate On Wed, 2013-01-02 at 03:40 +, Felipe wrote: OK now I tried to join again I saw this messages descriptor_sd_propagation_recursive: DC=DomainDnsZones,DC=*,DC=de not found under DC=*,DC=de descriptor_sd_propagation_recursive: DC=ForestDnsZones,DC=*,DC=de not found under DC=*,DC=de Unable to find group id for BIND, set permissions to sam.ldb* files manually Unable to find group id for BIND, set permissions to sam.ldb* files manually bind is running as user root Given your errors, you should check that bind can access the database and dns.keytab correctly. Are you running 9.8 or 9.9? Andrew Bartlett -- Andrew Bartletthttp://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] .recycle folder not showing up
From: Jerry Birkes jerrybir...@gmail.com Date: Wed, 2 Jan 2013 15:53:32 -0600 I have configured vfs_recycle because a team member deleted a file and could not recover it. Whenever I delete a folder under the share it is configured for, the .recycle folder does not appear as expected. Does anyone have experience with such an issue??? Much appreciated. AFAIK, Samba recycle bin only affects to files only, not directories. If you set recycle:keeptree = yes, the parent directories on a deleted file are also copied to .recycle when the file is deleted. --- TAKAHASHI Motonobu mo...@monyo.com -- To unsubscribe from this list go to the following URL and read the instructions: https://lists.samba.org/mailman/options/samba
Re: [Samba] (Trying) to understand Print properties saving
1. If I browse \\server\(server and fax) and I configure properties, where are the changes saved? ( on debian /var/lib/samba ) 2. When an end user configures the printer where does ther properties should go (I have roaming profiles)? In the profile? in a registry? In the user profile and registry. If the domain/local Administrator changes the properties in the printer on the client via settings | printers how does that change relate to settings in 1 and 2? You change the settings on the server with a user who has SePrintOperatorPrivileges ( see http://www.samba.org/samba/docs/man/Samba-HOWTO-Collection/rights.html ) in most caes Administrator. when changes are made, they are for all users. users can override the settings with there own settings of the printer. 4. In a working setup, is there a way to force the paper format *after* a user has already logged in and changed the properties? best is to remove the printer ( with loginscript ) set the correct settings en reinstall the printers ( through loginscript ) ( this is a example to set SE Rights. ) net -S PDC -U root rpc rights grant DOMAIN\Domain Admins SePrintOperatorPrivilege SeAddUsersPrivilege SeDiskOperatorPrivilege also. check the rights of the printer spooller folder. i changed my folder to /home/samba/spool Good luck.. Louis -Oorspronkelijk bericht- Van: san...@e-den.it [mailto:samba-boun...@lists.samba.org] Namens 'Alessandro Dentella' Verzonden: woensdag 2 januari 2013 18:11 Aan: samba@lists.samba.org Onderwerp: Re: [Samba] (Trying) to understand Print properties saving On Wed, Jan 02, 2013 at 11:08:40AM +, Moray Henderson wrote: From: Alessandro Dentella [mailto:san...@e-den.it] Sent: 01 January 2013 17:01 Hi, some weeks ago I wrote to this list about a problem I have saving print properties (samba 3.4.7 - ubuntu-lucid + XP-pro) I never managed to solve it, I also tried with samba 3.6+ (Ubuntu precise) but had aother problems I wrote about in this list ending opening a bug [1]. Now I had to go back to my 3.4.7 installation. I'd like at least to bettere understand how print properties work so that I can cope better with the situation. In my setup the drivers are distributed by the server, client do realize they need the driver and server correctly serves them, the problem is that the page format is alwayes set to 'letter' rather than 'A4'. I have roaming profiles. I really need to fix this even thought some workaround. I can't answer the other questions, but I do have some instructions for setting the default paper size (note these instructions were written for XP): After you click Finish and the driver is copied, select Properties on the printer. Say No when it asks if you want to install the driver. Go to the Advanced tab and select the driver from the dropdown list. Click OK and the name of the printer will change to show the driver you just installed. Right-click the printer again. On the General Tab set it back to its original name. Select Properties again and go back into the Advanced tab. Now there is a new option Printing Defaults. Click Advanced on the Printing Defaults page. NOW you can choose the default options for your users - like A4 paper size. Nasty, isn't it? Thanks for the reply but I already did all this as explained in my first post to this list [1]. As explained there I think it's related to this bug [2], but when moved to precise I met others problems that made be open this bug [3]... I'm not just asking to solve my problem but to explain the machinary so that I can figure out a possible further debug step. I really don't know where to ask for these info if not on the samba ml... So I represent the questions, hoping somene who knows the answer and didn't read the others mail can follo on this one... Can someone tell me which are the components that store the print properties? If this is already explained somewhere, please give me the URL, I wasn't able to find it. 1. If I browse \\server\(server and fax) and I configure properties, where are the changes saved? 2. When an end user configures the printer where does ther properties should go (I have roaming profiles)? In the profile? in a registry? 3. If the domain/local Administrator changes the properties in the printer on the client via settings | printers how does that change relate to settings in 1 and 2? 4. In a working setup, is there a way to force the paper format *after* a user has already logged in and changed the properties? [1] https://lists.samba.org/archive/samba/2012-December/170314.html [2] https://bugzilla.samba.org/show_bug.cgi?id=6727 [3] https://bugzilla.samba.org/show_bug.cgi?id=9468 -- Sandro Dentella *:-) http://www.reteisi.org Soluzioni libere per le scuole http://sqlkit.argolinux.orgSQLkit home page - PyGTK/python/sqlalchemy -- To
[SCM] Samba Shared Repository - branch v3-6-test updated
The branch, v3-6-test has been updated
via a8658bc Fix bug #9196 - defer_open is triggered multiple times on
the same request.
from 82db35c Fix bug #9471 - SEGV when using second vfs module.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -
commit a8658bcb67927282288af5a579e3e66d3eaaac7b
Author: Jeremy Allison j...@samba.org
Date: Fri Dec 14 08:56:52 2012 -0800
Fix bug #9196 - defer_open is triggered multiple times on the same request.
get_deferred_open_message_state_smb2() is buggy in that it is checking
the wrong things to determine if an open is in the deferred state.
It checks if (smb2req-async == NULL) which is incorrect,
as we're not always async in a deferred open - remove this.
It should check instead state-open_was_deferred as this
is explicity set to 'true' when an open is going deferred,
so add this check.
Signed-off-by: Jeremy Allison j...@samba.org
---
Summary of changes:
source3/smbd/smb2_create.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
index 5a9044d..5b81099 100644
--- a/source3/smbd/smb2_create.c
+++ b/source3/smbd/smb2_create.c
@@ -893,9 +893,6 @@ bool get_deferred_open_message_state_smb2(struct
smbd_smb2_request *smb2req,
if (!smb2req) {
return false;
}
- if (!smb2req-async) {
- return false;
- }
req = smb2req-subreq;
if (!req) {
return false;
@@ -904,6 +901,9 @@ bool get_deferred_open_message_state_smb2(struct
smbd_smb2_request *smb2req,
if (!state) {
return false;
}
+ if (!state-open_was_deferred) {
+ return false;
+ }
if (p_request_time) {
*p_request_time = state-request_time;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 6cb7c4f docs: Fix typo in vfs_tsmsm.8.xml. via ab43e2d docs: Remove superfluous bracket. from f77bfed s4:drsuapi: try to behave more like windows for usn order (bug #9508) http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 6cb7c4f45e1657245443c3bcc6dab219e5f1d9b5 Author: Samba-JP oota rib...@samba.gr.jp Date: Wed Jan 2 10:21:51 2013 +0100 docs: Fix typo in vfs_tsmsm.8.xml. Reviewed-by: Karolin Seeger ksee...@samba.org Autobuild-User(master): Karolin Seeger ksee...@samba.org Autobuild-Date(master): Wed Jan 2 12:12:12 CET 2013 on sn-devel-104 commit ab43e2db64ae3ef387ceb0e7e6a6f82c9e6d301d Author: Samba-JP oota rib...@samba.gr.jp Date: Wed Jan 2 09:12:14 2013 +0100 docs: Remove superfluous bracket. Reviewed-by: Karolin Seeger ksee...@samba.org --- Summary of changes: docs-xml/manpages/samba.8.xml |2 +- docs-xml/manpages/vfs_tsmsm.8.xml |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages/samba.8.xml b/docs-xml/manpages/samba.8.xml index 9ce65c8..f6e8069 100644 --- a/docs-xml/manpages/samba.8.xml +++ b/docs-xml/manpages/samba.8.xml @@ -188,7 +188,7 @@ varlistentry termfilename/etc/rc/filename/term listitemparaor whatever initialization script your - system uses)./para + system uses./para paraIf running the server as a daemon at startup, this file will need to contain an appropriate startup diff --git a/docs-xml/manpages/vfs_tsmsm.8.xml b/docs-xml/manpages/vfs_tsmsm.8.xml index 63a5f60..de24f14 100644 --- a/docs-xml/manpages/vfs_tsmsm.8.xml +++ b/docs-xml/manpages/vfs_tsmsm.8.xml @@ -62,7 +62,7 @@ hsm script should point to a shell script which accepts two arguments: operation and filepath. the tsmsm module only uses offline for operation - to set set the file under filepath offline. + to set the file under filepath offline. /para /listitem -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-0-test updated
The branch, v4-0-test has been updated
via 04388ad Fix bug #9196 - defer_open is triggered multiple times on
the same request.
from 9b4bd43 VERSION: Bump version number up to 4.0.1.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test
- Log -
commit 04388adfe82bd0fa52c30074c501b2db87ee3c65
Author: Jeremy Allison j...@samba.org
Date: Fri Dec 14 08:39:26 2012 -0800
Fix bug #9196 - defer_open is triggered multiple times on the same request.
get_deferred_open_message_state_smb2() is buggy in that it is checking
the wrong things to determine if an open is in the deferred state.
It checks if (smb2req-async_te == NULL) which is incorrect,
as we're not always async in a deferred open - remove this.
It should check instead state-open_was_deferred as this
is explicity set to 'true' when an open is going deferred,
so add this check.
Signed-off-by: Jeremy Allison j...@samba.org
Reviewed-by: Stefan Metzmacher me...@samba.org
Autobuild-User(master): Stefan Metzmacher me...@samba.org
Autobuild-Date(master): Tue Dec 18 14:19:13 CET 2012 on sn-devel-104
(cherry picked from commit 2148d86c7a2facd6e128b753aef98722843af3e1)
Autobuild-User(v4-0-test): Karolin Seeger ksee...@samba.org
Autobuild-Date(v4-0-test): Wed Jan 2 12:18:40 CET 2013 on sn-devel-104
---
Summary of changes:
source3/smbd/smb2_create.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
index 7db6b00..ae0cdb3 100644
--- a/source3/smbd/smb2_create.c
+++ b/source3/smbd/smb2_create.c
@@ -1132,9 +1132,6 @@ bool get_deferred_open_message_state_smb2(struct
smbd_smb2_request *smb2req,
if (!smb2req) {
return false;
}
- if (smb2req-async_te == NULL) {
- return false;
- }
req = smb2req-subreq;
if (!req) {
return false;
@@ -1143,6 +1140,9 @@ bool get_deferred_open_message_state_smb2(struct
smbd_smb2_request *smb2req,
if (!state) {
return false;
}
+ if (!state-open_was_deferred) {
+ return false;
+ }
if (p_request_time) {
*p_request_time = state-request_time;
}
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 94f11e9 s3-net: Fix rpc_service_list_internal() null pointer
passing.
via 9b0c1ab s3-rpcclient: Fix cmd_eventlog_loginfo() null pointer
passing.
via 30e1dc0 s3-rpcclient: Fix cmd_eventlog_readlog() null pointer
passing.
via ab14918 s3-idmap: Check return value of string_to_sid().
from 6cb7c4f docs: Fix typo in vfs_tsmsm.8.xml.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 94f11e9d168931018125a1552f22b786ba290dd0
Author: Andreas Schneider a...@samba.org
Date: Fri Dec 21 16:03:51 2012 +0100
s3-net: Fix rpc_service_list_internal() null pointer passing.
Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Günther Deschner g...@samba.org
Found by Coverity.
Autobuild-User(master): Günther Deschner g...@samba.org
Autobuild-Date(master): Wed Jan 2 14:19:50 CET 2013 on sn-devel-104
commit 9b0c1ab07c2c9a3fce1c49ad3d476ca1301182a4
Author: Andreas Schneider a...@samba.org
Date: Fri Dec 21 15:58:49 2012 +0100
s3-rpcclient: Fix cmd_eventlog_loginfo() null pointer passing.
Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Günther Deschner g...@samba.org
Found by Coverity.
commit 30e1dc08df8d891e1ab6e17d786a7a239417947f
Author: Andreas Schneider a...@samba.org
Date: Fri Dec 21 15:52:02 2012 +0100
s3-rpcclient: Fix cmd_eventlog_readlog() null pointer passing.
Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Günther Deschner g...@samba.org
Found by Coverity.
commit ab14918ea406eed2ed79c39dea7b855e4ecbac74
Author: Andreas Schneider a...@samba.org
Date: Fri Dec 14 16:54:55 2012 +0100
s3-idmap: Check return value of string_to_sid().
Found by Coverity.
Signed-off-by: Andreas Schneider a...@samba.org
Reviewed-by: Günther Deschner g...@samba.org
Reviewed-by: Christian Ambach a...@samba.org
---
Summary of changes:
source3/rpcclient/cmd_eventlog.c | 25 -
source3/utils/net_rpc_service.c | 15 +--
source3/winbindd/idmap_autorid.c |7 ++-
3 files changed, 35 insertions(+), 12 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpcclient/cmd_eventlog.c b/source3/rpcclient/cmd_eventlog.c
index a9d971e..949e025 100644
--- a/source3/rpcclient/cmd_eventlog.c
+++ b/source3/rpcclient/cmd_eventlog.c
@@ -69,7 +69,7 @@ static NTSTATUS cmd_eventlog_readlog(struct rpc_pipe_client
*cli,
EVENTLOG_SEQUENTIAL_READ;
uint32_t offset = 0;
uint32_t number_of_bytes = 0;
- uint8_t *data = NULL;
+ uint8_t *data;
uint32_t sent_size = 0;
uint32_t real_size = 0;
@@ -84,10 +84,6 @@ static NTSTATUS cmd_eventlog_readlog(struct rpc_pipe_client
*cli,
if (argc = 4) {
number_of_bytes = atoi(argv[3]);
- data = talloc_array(mem_ctx, uint8_t, number_of_bytes);
- if (!data) {
- goto done;
- }
}
status = get_eventlog_handle(cli, mem_ctx, argv[1], handle);
@@ -95,6 +91,11 @@ static NTSTATUS cmd_eventlog_readlog(struct rpc_pipe_client
*cli,
return status;
}
+ data = talloc_array(mem_ctx, uint8_t, number_of_bytes);
+ if (data == NULL) {
+ goto done;
+ }
+
do {
enum ndr_err_code ndr_err;
@@ -118,8 +119,8 @@ static NTSTATUS cmd_eventlog_readlog(struct rpc_pipe_client
*cli,
if (NT_STATUS_EQUAL(result, NT_STATUS_BUFFER_TOO_SMALL)
real_size 0 ) {
number_of_bytes = real_size;
- data = talloc_array(mem_ctx, uint8_t, real_size);
- if (!data) {
+ data = talloc_realloc(mem_ctx, data, uint8_t,
real_size);
+ if (data == NULL) {
goto done;
}
status = dcerpc_eventlog_ReadEventLogW(b, mem_ctx,
@@ -509,6 +510,12 @@ static NTSTATUS cmd_eventlog_loginfo(struct
rpc_pipe_client *cli,
return status;
}
+ buffer = talloc_array(mem_ctx, uint8_t, bytes_needed);
+ if (buffer == NULL) {
+ status = NT_STATUS_NO_MEMORY;
+ goto done;
+ }
+
status = dcerpc_eventlog_GetLogInformation(b, mem_ctx,
handle,
0, /* level */
@@ -525,8 +532,8 @@ static NTSTATUS cmd_eventlog_loginfo(struct rpc_pipe_client
*cli,
}
buf_size = bytes_needed;
- buffer = talloc_array(mem_ctx, uint8_t, bytes_needed);
- if (!buffer) {
+ buffer =
[SCM] Samba Shared Repository - branch v4-0-test updated
The branch, v4-0-test has been updated via 0d5e2f4 docs: Fix typo in vfs_tsmsm.8.xml. via e5fe93b docs: Remove superfluous bracket. from 04388ad Fix bug #9196 - defer_open is triggered multiple times on the same request. http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v4-0-test - Log - commit 0d5e2f46eac7e1ba6011c7d53bab095bc552a921 Author: Samba-JP oota rib...@samba.gr.jp Date: Wed Jan 2 10:21:51 2013 +0100 docs: Fix typo in vfs_tsmsm.8.xml. Reviewed-by: Karolin Seeger ksee...@samba.org Autobuild-User(master): Karolin Seeger ksee...@samba.org Autobuild-Date(master): Wed Jan 2 12:12:12 CET 2013 on sn-devel-104 (cherry picked from commit 6cb7c4f45e1657245443c3bcc6dab219e5f1d9b5) Fix bug #9530 - Typo in vfs_tsmsm.8.xml. Autobuild-User(v4-0-test): Karolin Seeger ksee...@samba.org Autobuild-Date(v4-0-test): Wed Jan 2 14:25:40 CET 2013 on sn-devel-104 commit e5fe93bb26229a3ed0f0578a7fd82aeda59f87ad Author: Samba-JP oota rib...@samba.gr.jp Date: Wed Jan 2 09:12:14 2013 +0100 docs: Remove superfluous bracket. Reviewed-by: Karolin Seeger ksee...@samba.org (cherry picked from commit ab43e2db64ae3ef387ceb0e7e6a6f82c9e6d301d) Fix bug 9528 - Superfluous bracket in samba.8.xml. --- Summary of changes: docs-xml/manpages/samba.8.xml |2 +- docs-xml/manpages/vfs_tsmsm.8.xml |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/docs-xml/manpages/samba.8.xml b/docs-xml/manpages/samba.8.xml index 9ce65c8..f6e8069 100644 --- a/docs-xml/manpages/samba.8.xml +++ b/docs-xml/manpages/samba.8.xml @@ -188,7 +188,7 @@ varlistentry termfilename/etc/rc/filename/term listitemparaor whatever initialization script your - system uses)./para + system uses./para paraIf running the server as a daemon at startup, this file will need to contain an appropriate startup diff --git a/docs-xml/manpages/vfs_tsmsm.8.xml b/docs-xml/manpages/vfs_tsmsm.8.xml index 63a5f60..de24f14 100644 --- a/docs-xml/manpages/vfs_tsmsm.8.xml +++ b/docs-xml/manpages/vfs_tsmsm.8.xml @@ -62,7 +62,7 @@ hsm script should point to a shell script which accepts two arguments: operation and filepath. the tsmsm module only uses offline for operation - to set set the file under filepath offline. + to set the file under filepath offline. /para /listitem -- Samba Shared Repository
