The branch, master has been updated via 2ec93ac6f34 smbd: follow-up fix for "if close fails just log it, don't crash" from c4c086ecc00 s4:utils: Reformat shell scripts
https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log ----------------------------------------------------------------- commit 2ec93ac6f34fda745912be648148f79d2a2b0671 Author: Ralph Boehme <s...@samba.org> Date: Fri Jul 8 17:08:05 2022 +0200 smbd: follow-up fix for "if close fails just log it, don't crash" Signed-off-by: Ralph Boehme <s...@samba.org> Reviewed-by: Björn Baumbach <b...@sernet.de> Autobuild-User(master): Ralph Böhme <s...@samba.org> Autobuild-Date(master): Sat Jul 9 09:04:46 UTC 2022 on sn-devel-184 ----------------------------------------------------------------------- Summary of changes: source3/smbd/files.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Changeset truncated at 500 lines: diff --git a/source3/smbd/files.c b/source3/smbd/files.c index 45cc7ffd79f..b56130f4f04 100644 --- a/source3/smbd/files.c +++ b/source3/smbd/files.c @@ -424,7 +424,7 @@ static int smb_fname_fsp_destructor(struct smb_filename *smb_fname) fsp_set_base_fsp(fsp, NULL); status = fd_close(tmp_base_fsp); - if (NT_STATUS_IS_OK(status)) { + if (!NT_STATUS_IS_OK(status)) { DBG_ERR("Closing fd for fsp [%s] failed: %s. " "Please check your filesystem!!!\n", fsp_str_dbg(fsp), nt_errstr(status)); @@ -433,7 +433,7 @@ static int smb_fname_fsp_destructor(struct smb_filename *smb_fname) } status = fd_close(fsp); - if (NT_STATUS_IS_OK(status)) { + if (!NT_STATUS_IS_OK(status)) { DBG_ERR("Closing fd for fsp [%s] failed: %s. " "Please check your filesystem!!!\n", fsp_str_dbg(fsp), nt_errstr(status)); -- Samba Shared Repository