autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2015-10-27-0857/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2015-10-27-0857/samba.stderr http://git.samba.org/autobuild.flakey/2015-10-27-0857/samba.stdout The top commit at the time of the failure was: commit cbae31c7946fc13c3a00bc81a102e90fdec00018 Author: Martin SchwenkeDate: Tue Oct 27 12:06:25 2015 +1100 build: --picky-developer implies --enable-developer Have --picky-developer enable --enable-developer too, instead of requiring both options to be specified. This makes it obey the principle of least surprise. Signed-off-by: Martin Schwenke Reviewed-by: Andrew Bartlett Autobuild-User(master): Martin Schwenke Autobuild-Date(master): Tue Oct 27 07:19:33 CET 2015 on sn-devel-104
[SCM] Samba Shared Repository - branch v4-2-test updated
The branch, v4-2-test has been updated via 929166e VERSION: Bump version up to 4.2.6... via 851ea18 VERSION: Disable git snapshots for the 4.2.5 release. via 0c46d4a WHATSNEW: Add release notes for Samba 4.2.5. from bf344f7 dcerpc.idl: accept invalid dcerpc_bind_nak pdus https://git.samba.org/?p=samba.git;a=shortlog;h=v4-2-test - Log - commit 929166e3c7a8d3b9d88e7271107e55359b3ecbb3 Author: Karolin SeegerDate: Mon Oct 26 11:44:15 2015 +0100 VERSION: Bump version up to 4.2.6... and re-enable git snapshots. Signed-off-by: Karolin Seeger commit 851ea182cfa6521a8385d51a98f8ecdca539c831 Author: Karolin Seeger Date: Mon Oct 26 11:43:43 2015 +0100 VERSION: Disable git snapshots for the 4.2.5 release. Signed-off-by: Karolin Seeger commit 0c46d4a3f8e6a0ca316a02b674674816e2c6829e Author: Karolin Seeger Date: Mon Oct 26 11:43:03 2015 +0100 WHATSNEW: Add release notes for Samba 4.2.5. Signed-off-by: Karolin Seeger --- Summary of changes: VERSION | 2 +- WHATSNEW.txt | 95 ++-- 2 files changed, 93 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/VERSION b/VERSION index e0419c6..355ddef 100644 --- a/VERSION +++ b/VERSION @@ -25,7 +25,7 @@ SAMBA_VERSION_MAJOR=4 SAMBA_VERSION_MINOR=2 -SAMBA_VERSION_RELEASE=5 +SAMBA_VERSION_RELEASE=6 # If a official release has a serious bug # diff --git a/WHATSNEW.txt b/WHATSNEW.txt index 4d01c77..8e65255 100644 --- a/WHATSNEW.txt +++ b/WHATSNEW.txt @@ -1,4 +1,95 @@ = + Release Notes for Samba 4.2.5 + October 27, 2015 + = + + +This is the latest stable release of Samba 4.2. + + +Changes since 4.2.4: + + +o Jeremy Allison +* BUG 10252: s3: smbd: Fix our access-based enumeration on "hide unreadable" + to match Windows. +* BUG 10634: smbd: Fix file name buflen and padding in notify repsonse. +* BUG 11486: s3: smbd: Fix mkdir race condition. +* BUG 11522: s3: smbd: Fix opening/creating :stream files on the root share + directory. +* BUG 11535: s3: smbd: Fix NULL pointer bug introduced by previous 'raw' + stream fix (bug #11522). +* BUG 11555: s3: lsa: lookup_name() logic for unqualified (no DOMAIN\ + component) names is incorrect. + + +o Ralph Boehme +* BUG 11535: s3: smbd: Fix a crash in unix_convert(). +* BUG 11543: vfs_fruit: Return value of ad_pack in vfs_fruit.c. +* BUG 11549: Fix bug in smbstatus where the lease info is not printed. +* BUG 11550: s3:smbstatus: Add stream name to share_entry_forall(). +* BUG 11555: s3:lib: validate domain name in lookup_wellknown_name(). + + +o Günther Deschner +* BUG 11038: kerberos: Make sure we only use prompter type when available. + + +o Björn Jacke +* BUG 10365: nss_winbind: Fix hang on Solaris on big groups. +* BUG 11355: build: Use as-needed linker flag also on OpenBSD. + + +o Volker Lendecke +* BUG 11038: winbind: Fix 100% loop. +* BUG 11381: Fix a deadlock in tdb. + + +o Stefan Metzmacher +* BUG 11316: s3:ctdbd_conn: Make sure we destroy tevent_fd before closing + the socket. +* BUG 11327: dcerpc.idl: accept invalid dcerpc_bind_nak pdus. + + +o Har Gagan Sahai +* BUG 11509: s3: dfs: Fix a crash when the dfs targets are disabled. + + +o Andreas Schneider +* BUG 11502: pam_winbind: Fix a segfault if initialization fails. + + +o Uri Simchoni +* BUG 11528: net: Fix a crash with 'net ads keytab create'. +* BUG 11547: vfs_commit: Set the fd on open before calling SMB_VFS_FSTAT. + + +### +Reporting bugs & Development Discussion +### + +Please discuss this release on the samba-technical mailing list or by +joining the #samba-technical IRC channel on irc.freenode.net. + +If you do report problems then please try to send high quality +feedback. If you don't provide vital information to help us track down +the problem then you will probably be ignored. All bug reports should +be filed under the Samba 4.2 product in the project's Bugzilla +database (https://bugzilla.samba.org/). + + +== +== Our Code, Our Bugs,
[SCM] Samba Shared Repository - branch v4-2-stable updated
The branch, v4-2-stable has been updated via 851ea18 VERSION: Disable git snapshots for the 4.2.5 release. via 0c46d4a WHATSNEW: Add release notes for Samba 4.2.5. via bf344f7 dcerpc.idl: accept invalid dcerpc_bind_nak pdus via 4cb9657 s3:smbstatus: add stream name to share_entry_forall() via 2b1a40d s3: lsa: lookup_name() logic for unqualified (no DOMAIN\ component) names is incorrect. via 8bd6345 s3:lib: validate domain name in lookup_wellknown_name() via 8c5990a s3:locking: initialize lease pointer in share_mode_traverse_fn() via f1ea5fd s4: torture: Add SMB2 access-based enumeration test. Passes against Win2k12R2. via b13c829 lib: cli: Add accessor function smb2cli_tcon_flags() to get tcon flags. via 3695d46 s3: smbd: Fix our access-based enumeration on "hide unreadable" to match Windows. via deaa748 smbd: Fix file name buflen and padding in notify repsonse via dd39bd2 vfs_fruit: return value of ad_pack in vfs_fruit.c via 95b17d5 tdb: Fix bug 11381, deadlock via 0349f95 vfs_commit: set the fd on open before calling SMB_VFS_FSTAT via ba280e6 s3:ctdbd_conn: make sure we destroy tevent_fd before closing the socket via 5bc3a2f kerberos: make sure we only use prompter type when available. via b6f1310 winbind: Fix 100% loop via f9a820a s3: smbd: Fix NULL pointer bug introduced by previous 'raw' stream fix (bug #11522). via d69db57 s3: smbd: fix a crash in unix_convert() via 2df7b85 net: fix a crash with net ads keytab create via 2e516a7 s3: tests: smbclient test to ensure we can create and see a :foobar stream on the top level directory in a share. via 22d55ca s3: smbd: Fix opening/creating :stream files on the root share directory. via 29f057c s3: smbd: Remove unused parameter from build_stream_path(). via eb1aa45 s3: smbclient: Move cmd_setmode out of clitar.c and back into client.c via 6c6b62f pam_winbind: Fix a segfault if initialization fails via d2105b7 s4: torture: Test mkdir race condition. via d194836 s3: smbd: Fix mkdir race condition. via 105f949 s3: dfs: Fix a crash when the dfs targets are disabled. via 68801fb nss_winbind: fix hang on Solaris on big groups via f4bc73f build: use as-needed linker flag also on OpenBSD via 7cabb4c VERSION: Bump version up to 4.2.5... from 413fb83 VERSION: Disable git snapshots for the 4.2.4 release. https://git.samba.org/?p=samba.git;a=shortlog;h=v4-2-stable - Log - --- Summary of changes: VERSION | 2 +- WHATSNEW.txt | 95 +++- lib/tdb/common/traverse.c | 14 +- libcli/smb/smbXcli_base.c | 5 + libcli/smb/smbXcli_base.h | 1 + librpc/idl/dcerpc.idl | 6 +- librpc/idl/notify.idl | 4 +- librpc/ndr/ndr_dcerpc.c | 49 +++ nsswitch/pam_winbind.c| 19 ++- nsswitch/winbind_nss_solaris.c| 6 + selftest/knownfail| 2 + source3/client/client.c | 118 +++ source3/client/client_proto.h | 6 + source3/client/clitar.c | 130 - source3/lib/ctdbd_conn.c | 6 +- source3/lib/util_wellknown.c | 13 +- source3/libads/kerberos.c | 26 source3/libads/ldap.c | 7 + source3/libsmb/clidfs.c | 4 +- source3/locking/proto.h | 3 +- source3/locking/share_mode_lock.c | 21 ++- source3/modules/vfs_commit.c | 11 +- source3/modules/vfs_fruit.c | 14 +- source3/passdb/lookup_sid.c | 31 +++- source3/rpc_server/srvsvc/srv_srvsvc_nt.c | 21 ++- source3/script/tests/test_smbclient_s3.sh | 36 + source3/smbd/dir.c| 64 - source3/smbd/filename.c | 35 - source3/smbd/notify.c | 14 +- source3/smbd/open.c | 19 +++ source3/utils/status.c| 6 +- source4/heimdal_build/wscript_configure | 1 + source4/torture/smb2/acls.c | 230 ++ source4/torture/smb2/create.c | 151 wscript | 3 +- wscript_configure_system_mitkrb5 | 2 + 36 files changed, 987 insertions(+), 188 deletions(-) Changeset truncated at 500 lines: diff --git a/VERSION b/VERSION index 381f62e..967a8fa 100644 --- a/VERSION +++ b/VERSION @@ -25,7 +25,7 @@
[SCM] Samba Shared Repository - annotated tag samba-4.2.5 created
The annotated tag, samba-4.2.5 has been created at 29b592e4b03a6d767c142eee4966fa1dd4add5ab (tag) tagging 851ea182cfa6521a8385d51a98f8ecdca539c831 (commit) replaces samba-4.2.4 tagged by Karolin Seeger on Tue Oct 27 09:04:33 2015 +0100 - Log - samba: tag release samba-4.2.5 -BEGIN PGP SIGNATURE- Version: GnuPG v1 iEYEABECAAYFAlYvMBEACgkQbzORW2Vot+peCwCgp0WIqhHltOIaysYc+pzWjPPW d2cAoLw8fabEChGPa94mdJZiOVgzLchC =ovCH -END PGP SIGNATURE- Andreas Schneider (1): pam_winbind: Fix a segfault if initialization fails Björn Jacke (2): build: use as-needed linker flag also on OpenBSD nss_winbind: fix hang on Solaris on big groups Günther Deschner (1): kerberos: make sure we only use prompter type when available. Har Gagan Sahai (1): s3: dfs: Fix a crash when the dfs targets are disabled. Jeremy Allison (12): s3: smbd: Fix mkdir race condition. s4: torture: Test mkdir race condition. s3: smbclient: Move cmd_setmode out of clitar.c and back into client.c s3: smbd: Remove unused parameter from build_stream_path(). s3: smbd: Fix opening/creating :stream files on the root share directory. s3: tests: smbclient test to ensure we can create and see a :foobar stream on the top level directory in a share. s3: smbd: Fix NULL pointer bug introduced by previous 'raw' stream fix (bug #11522). smbd: Fix file name buflen and padding in notify repsonse s3: smbd: Fix our access-based enumeration on "hide unreadable" to match Windows. lib: cli: Add accessor function smb2cli_tcon_flags() to get tcon flags. s4: torture: Add SMB2 access-based enumeration test. Passes against Win2k12R2. s3: lsa: lookup_name() logic for unqualified (no DOMAIN\ component) names is incorrect. Karolin Seeger (3): VERSION: Bump version up to 4.2.5... WHATSNEW: Add release notes for Samba 4.2.5. VERSION: Disable git snapshots for the 4.2.5 release. Ralph Boehme (5): s3: smbd: fix a crash in unix_convert() vfs_fruit: return value of ad_pack in vfs_fruit.c s3:locking: initialize lease pointer in share_mode_traverse_fn() s3:lib: validate domain name in lookup_wellknown_name() s3:smbstatus: add stream name to share_entry_forall() Stefan Metzmacher (2): s3:ctdbd_conn: make sure we destroy tevent_fd before closing the socket dcerpc.idl: accept invalid dcerpc_bind_nak pdus Uri Simchoni (2): net: fix a crash with net ads keytab create vfs_commit: set the fd on open before calling SMB_VFS_FSTAT Volker Lendecke (2): winbind: Fix 100% loop tdb: Fix bug 11381, deadlock --- -- Samba Shared Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 95d1dec Add missing versions. from e6f28dc Add release notes for Samba 4.2.5. https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 95d1deca675dc153abb6479944f6ef54ab9dad0b Author: Karolin SeegerDate: Tue Oct 27 11:38:24 2015 +0100 Add missing versions. Signed-off-by: Karolin Seeger --- Summary of changes: history/header_history.html | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/history/header_history.html b/history/header_history.html index 23ab462..b12fc0a 100755 --- a/history/header_history.html +++ b/history/header_history.html @@ -9,12 +9,15 @@ Release Notes - CVE-2013-0454 + samba-4.3.1 + samba-4.3.0 + samba-4.2.4 samba-4.2.4 samba-4.2.3 samba-4.2.2 samba-4.2.1 samba-4.2.0 + samba-4.1.20 samba-4.1.20 samba-4.1.19 samba-4.1.18 -- Samba Website Repository
[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via e6f28dc Add release notes for Samba 4.2.5. via 1cbc2e2 NEWS[4.2.5]: Samba 4.2.5 Available for Download from b381034 NEWS[4.3.1]: Samba 4.3.1 Available for Download https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit e6f28dc97cf97eb7ade2f909793382dbfbad9ee2 Author: Karolin Seeger <ksee...@samba.org> Date: Tue Oct 27 11:34:39 2015 +0100 Add release notes for Samba 4.2.5. Signed-off-by: Karolin Seeger <ksee...@samba.org> commit 1cbc2e203c9c77634603ccb30df451777c9dde81 Author: Karolin Seeger <ksee...@samba.org> Date: Tue Oct 27 10:58:26 2015 +0100 NEWS[4.2.5]: Samba 4.2.5 Available for Download Signed-off-by: Karolin Seeger <ksee...@samba.org> --- Summary of changes: history/{samba-4.3.1.html => samba-4.2.5.html} | 68 - posted_news/20151027-082043.4.2.5.body.html | 16 ++ posted_news/20151027-082043.4.2.5.headline.html | 3 ++ 3 files changed, 53 insertions(+), 34 deletions(-) copy history/{samba-4.3.1.html => samba-4.2.5.html} (52%) mode change 100644 => 100755 create mode 100644 posted_news/20151027-082043.4.2.5.body.html create mode 100644 posted_news/20151027-082043.4.2.5.headline.html Changeset truncated at 500 lines: diff --git a/history/samba-4.3.1.html b/history/samba-4.2.5.html old mode 100644 new mode 100755 similarity index 52% copy from history/samba-4.3.1.html copy to history/samba-4.2.5.html index 79818d5..1b1db54 --- a/history/samba-4.3.1.html +++ b/history/samba-4.2.5.html @@ -1,82 +1,82 @@ http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;> +"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd;> http://www.w3.org/1999/xhtml;> + -Samba 4.3.1 - Release Notes +Samba - Release Notes Archive + -Samba 4.3.1 Available for Download - -https://download.samba.org/pub/samba/stable/samba-4.3.1.tar.gz;>Samba 4.3.1 (gzipped) -https://download.samba.org/pub/samba/stable/samba-4.3.1.tar.asc;>Signature - - -https://download.samba.org/pub/samba/patches/samba-4.3.0-4.3.1.diffs.gz;>Patch (gzipped) against Samba 4.3.0 -https://download.samba.org/pub/samba/patches/samba-4.3.0-4.3.1.diffs.asc;>Signature - + + Samba 4.2.5 Available for Download + = - Release Notes for Samba 4.3.1 - October 20, 2015 + Release Notes for Samba 4.2.5 + October 27, 2015 = -This is the latest stable release of Samba 4.3. +This is the latest stable release of Samba 4.2. -Changes since 4.3.0: +Changes since 4.2.4: o Jeremy Allison j...@samba.org -* BUG 10252: s3: smbd: Fix our access-based enumeration on hide unreadable +* BUG 10252: s3: smbd: Fix our access-based enumeration on "hide unreadable" to match Windows. * BUG 10634: smbd: Fix file name buflen and padding in notify repsonse. * BUG 11486: s3: smbd: Fix mkdir race condition. * BUG 11522: s3: smbd: Fix opening/creating :stream files on the root share directory. -* BUG 11535: s3: smbd: Fix NULL pointer bug introduced by previous raw -* stream fix (bug #11522). +* BUG 11535: s3: smbd: Fix NULL pointer bug introduced by previous 'raw' + stream fix (bug #11522). * BUG 11555: s3: lsa: lookup_name() logic for unqualified (no DOMAIN\ component) names is incorrect. + o Ralph Boehme s...@samba.org * BUG 11535: s3: smbd: Fix a crash in unix_convert(). * BUG 11543: vfs_fruit: Return value of ad_pack in vfs_fruit.c. -* BUG 11549: s3:locking: Initialize lease pointer in - share_mode_traverse_fn(). +* BUG 11549: Fix bug in smbstatus where the lease info is not printed. * BUG 11550: s3:smbstatus: Add stream name to share_entry_forall(). -* BUG 11555: s3:lib: Validate domain name in lookup_wellknown_name(). +* BUG 11555: s3:lib: validate domain name in lookup_wellknown_name(). + -o Gnther Deschner g...@samba.org +o Günther Deschner g...@samba.org * BUG 11038: kerberos: Make sure we only use prompter type when available. + +o Bjrn Jacke b...@sernet.de +* BUG 10365: nss_winbind: Fix hang on Solaris on big groups. +* BUG 11355: build: Use as-needed linker flag also on OpenBSD. + + o Volker Lendecke v...@samba.org * BUG 11038: winbind: Fix 100% loop. -* BUG 11053: source3/lib/msghdr.c: Fix compiling error on Solaris. +* BUG 11381: Fix a deadlock in tdb. + o Stefan Metzmacher me...@samba.org -* BUG 11316: s3:ctdbd_conn: make sure we destroy tevent_fd before closing +* BUG 11316: s3:ctdbd_conn: Make sure we destroy tevent_fd before closin
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via cbae31c build: --picky-developer implies --enable-developer via 151a7da ctdb-build: Define CTDB_SOCKET at configure time via af99846 ctdb-tool: Remove repack command via 47cddb6 ctdb-ib: Fix build for infiniband transport via 42b1d30 ctdb-daemon: Keep protocol.h in sync with ctdb_protocol.h from 84b7a9f build:wafsamba: dead code removal in gettext detection https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit cbae31c7946fc13c3a00bc81a102e90fdec00018 Author: Martin SchwenkeDate: Tue Oct 27 12:06:25 2015 +1100 build: --picky-developer implies --enable-developer Have --picky-developer enable --enable-developer too, instead of requiring both options to be specified. This makes it obey the principle of least surprise. Signed-off-by: Martin Schwenke Reviewed-by: Andrew Bartlett Autobuild-User(master): Martin Schwenke Autobuild-Date(master): Tue Oct 27 07:19:33 CET 2015 on sn-devel-104 commit 151a7dabd5f6bf7560c701cc1cfcde4c63f5b6d9 Author: Amitay Isaacs Date: Mon Oct 26 15:58:36 2015 +1100 ctdb-build: Define CTDB_SOCKET at configure time Currently only Samba is built with CTDB and since CTDB headers are not public any more, no other application can build with CTDB. So define CTDB_SOCKET only during build. In future CTDB will have public API and proper way of figuring out CTDB_SOCKET. Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit af99846ac58fed268bee8b35e331a05174f547e0 Author: Amitay Isaacs Date: Fri Oct 23 14:24:48 2015 +1100 ctdb-tool: Remove repack command The databases are repacked automatically during vacuuming when the freelist size grows beyond configured threshold (RepackLimit). Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 47cddb699a28560556ed7db8eb829628407f2e22 Author: Amitay Isaacs Date: Tue Oct 13 16:19:21 2015 +1100 ctdb-ib: Fix build for infiniband transport Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke commit 42b1d30fbb3fc6bbc06c3a9a1802cab6f2cc769c Author: Amitay Isaacs Date: Fri Oct 23 19:10:28 2015 +1100 ctdb-daemon: Keep protocol.h in sync with ctdb_protocol.h ctdb_protocol.h was modified to update default capabilities without corresponding changes in protocol.h. (Patch dfc84fdd45a9bd763289b4965bc2d0a3e7071ff0) Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke --- Summary of changes: buildtools/wafsamba/wscript | 6 +- ctdb/ib/ibw_ctdb.c | 11 +-- ctdb/ib/ibw_ctdb_init.c | 10 +-- ctdb/ib/ibwrapper_test.c | 30 +++ ctdb/include/ctdb_private.h | 3 - ctdb/include/ctdb_protocol.h | 7 -- ctdb/protocol/protocol.h | 6 +- ctdb/tests/src/ctdb_test.c | 1 - ctdb/tools/ctdb.c| 1 - ctdb/tools/ctdb_vacuum.c | 193 --- ctdb/wscript | 10 +-- 11 files changed, 33 insertions(+), 245 deletions(-) delete mode 100644 ctdb/tools/ctdb_vacuum.c Changeset truncated at 500 lines: diff --git a/buildtools/wafsamba/wscript b/buildtools/wafsamba/wscript index f3e019c..5bce17d 100755 --- a/buildtools/wafsamba/wscript +++ b/buildtools/wafsamba/wscript @@ -96,9 +96,13 @@ def set_options(opt): gr.add_option('--enable-developer', help=("Turn on developer warnings and debugging"), action="store_true", dest='developer', default=False) +def picky_developer_callback(option, opt_str, value, parser): +parser.values.developer = True +parser.values.picky_developer = True gr.add_option('--picky-developer', help=("Treat all warnings as errors (enable -Werror)"), - action="store_true", dest='picky_developer', default=False) + action="callback", callback=picky_developer_callback, + dest='picky_developer', default=False) gr.add_option('--fatal-errors', help=("Stop compilation on first error (enable -Wfatal-errors)"), action="store_true", dest='fatal_errors', default=False) diff --git a/ctdb/ib/ibw_ctdb.c b/ctdb/ib/ibw_ctdb.c index 2e70d1d..438bf69 100644 --- a/ctdb/ib/ibw_ctdb.c +++ b/ctdb/ib/ibw_ctdb.c @@ -49,17 +49,8 @@ int ctdb_ibw_node_connect(struct ctdb_node *node) assert(cn!=NULL);
autobuild: intermittent test failure detected
The autobuild test system has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey/2015-10-28-0036/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey/2015-10-28-0036/samba.stderr http://git.samba.org/autobuild.flakey/2015-10-28-0036/samba.stdout The top commit at the time of the failure was: commit cbae31c7946fc13c3a00bc81a102e90fdec00018 Author: Martin SchwenkeDate: Tue Oct 27 12:06:25 2015 +1100 build: --picky-developer implies --enable-developer Have --picky-developer enable --enable-developer too, instead of requiring both options to be specified. This makes it obey the principle of least surprise. Signed-off-by: Martin Schwenke Reviewed-by: Andrew Bartlett Autobuild-User(master): Martin Schwenke Autobuild-Date(master): Tue Oct 27 07:19:33 CET 2015 on sn-devel-104
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 0a90ed5 ctdb: open the RO tracking db with perms 0600 instead of from cbae31c build: --picky-developer implies --enable-developer https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 0a90ed51245d4a7acb23d22e47ee3fd5b83819b0 Author: Michael AdamDate: Tue Oct 27 10:20:31 2015 +0100 ctdb: open the RO tracking db with perms 0600 instead of While is possible from the UNIX/POSIX point of view, these permissions create problems in an environment with selinux enabled, which is more strict. This aligns the perms of the read only tracking db with other internal dbs. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11577 Signed-off-by: Michael Adam Reviewed-by: Amitay Isaacs Autobuild-User(master): Amitay Isaacs Autobuild-Date(master): Wed Oct 28 06:13:09 CET 2015 on sn-devel-104 --- Summary of changes: ctdb/server/ctdb_ltdb_server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/ctdb/server/ctdb_ltdb_server.c b/ctdb/server/ctdb_ltdb_server.c index 93e9041..3386bba 100644 --- a/ctdb/server/ctdb_ltdb_server.c +++ b/ctdb/server/ctdb_ltdb_server.c @@ -721,7 +721,7 @@ int ctdb_set_db_readonly(struct ctdb_context *ctdb, struct ctdb_db_context *ctdb ctdb_db->rottdb = tdb_open(ropath, ctdb->tunable.database_hash_size, TDB_NOLOCK|TDB_CLEAR_IF_FIRST|TDB_NOSYNC, - O_CREAT|O_RDWR, 0); + O_CREAT|O_RDWR, 0600); if (ctdb_db->rottdb == NULL) { DEBUG(DEBUG_CRIT,("Failed to open/create the tracking database '%s'\n", ropath)); talloc_free(ropath); -- Samba Shared Repository
[SCM] UID Wrapper Repository - branch master updated
The branch, master has been updated via 82ff081 cmake: Run threaded tests also on BSD and Solaris via 35d070c tests: Get the tests working on BSD via 77fdff7 tests: Rename test_gid to test_setgroups via 64505d6 tests: Add setresgid unprivileged user test via 4a0e9d4 tests: Move setresgid test to own executable via 246a94b tests: Move setregid test to own executable via f02727a tests: Move setegid test to own executable via 5d38a57 tests: Move setgid test to own executable via ee7795d tests: Add new test_setuid_euid1 and test_setuid_euid2 via a6eb467 tests: Create a test for threaded SYS_setuid via 0006b60 tests: Fix test_syscall_setuid to work with privilege checks via 7cde22c tests: Create a test for threaded sync SYS_setreuid via 9f45e90 tests: Create a test for threaded SYS_setreuid via 1b9b469 tests: Fix test_syscall_setreuid to work with privilege checks via f3d9e8e tests: Make syscall setresuid test from test_syscall_uid via d113176 tests: Move syscall setreuid test to own executable via 156d99a tests: Add test_getresuid out of test_uid via 2156fd0 tests: Move setresuid test to own executable via f5ddff7 tests: Move setreuid test to own executable via b0e109d tests: Move seteuid test to own executable via e459734 tests: Move setuid test to own executable via a54d1d6 cmake: Always set UID_WRAPPER_ROOT=1 for tests via caff321 uwrap: Add the EINVAL check to setegid() via e89cf7c uwrap: Allow setgid calls only for privileged users via f71da32 uwrap: Allow setregid calls only for privileged users via 38a13d2 uwrap: Allow setresgid calls only for privileged users via 7cd26ff uwrap: Move the EINVAL check down in seteuid() via 1044270 uwrap: Allow setuid calls only for privileged users via 54510cf uwrap: Allow setreuid calls only for privileged users via ac17973 uwrap: Allow setresuid calls only for privileged users via 9e2642c uwrap: Fix a possible null pointer dereference via 199b143 uwrap: Improve debug output via 0353a18 uwrap: Fix debug line in uwrap_init() from 10424ba Bump version to 1.1.1 https://git.samba.org/?p=uid_wrapper.git;a=shortlog;h=master - Log - commit 82ff0812e4287ba4786c97a1d56ce04d92d3ca6b Author: Andreas SchneiderDate: Mon Oct 12 18:41:16 2015 +0200 cmake: Run threaded tests also on BSD and Solaris Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit 35d070cb178fe07f1f902eaa5c9d91ea734dc932 Author: Andreas Schneider Date: Thu Oct 8 17:03:48 2015 +0200 tests: Get the tests working on BSD The setuid and seteuid behaviour is different to Linux and Solaris. The setuid euid tests on BSD look like a bug? Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit 77fdff705f6e82a923f0b66ea0859bbd1f1358d6 Author: Andreas Schneider Date: Fri Oct 9 13:22:35 2015 +0200 tests: Rename test_gid to test_setgroups Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit 64505d6964a52ad636ede36ab3a5f973189a954d Author: Andreas Schneider Date: Tue Oct 27 10:42:35 2015 +0100 tests: Add setresgid unprivileged user test Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit 4a0e9d4da9be669755263b68adefba507f5e3ea9 Author: Andreas Schneider Date: Fri Oct 9 13:21:20 2015 +0200 tests: Move setresgid test to own executable Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit 246a94bffd8224baa01d6a4f20cf2b58b5ff5a76 Author: Andreas Schneider Date: Fri Oct 9 13:10:23 2015 +0200 tests: Move setregid test to own executable Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit f02727a26dd5a010028057f0ed4b8744b1c5818b Author: Andreas Schneider Date: Fri Oct 9 09:40:14 2015 +0200 tests: Move setegid test to own executable Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit 5d38a571daf996f1a181c753403934188fa49c47 Author: Andreas Schneider Date: Fri Oct 9 09:31:10 2015 +0200 tests: Move setgid test to own executable Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit ee7795df63783a787e40dd5dfcf41574a0dfc3a7 Author: Andreas Schneider Date: Thu
[SCM] Socket Wrapper Repository - branch master updated
The branch, master has been updated via 21cb6c8 torture: Use a short torture socket dir via be46c97 swrap: Fix recvmsg() with UDP from 73b2b4f swrap: Fix compare of signed and unsigned integer expressions https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master - Log - commit 21cb6c86761c6a2db85a81d85395315d83f0cb52 Author: Andreas SchneiderDate: Tue Oct 27 10:03:06 2015 +0100 torture: Use a short torture socket dir This makes sure we do not run into a regression. Thanks to Grigorij Demidov Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher commit be46c97142b9e79c45c8fdf078ac5245813738ba Author: Andreas Schneider Date: Tue Oct 27 09:26:40 2015 +0100 swrap: Fix recvmsg() with UDP This worked if the unix path was bigger than sizeof(struct sockaddr_in6). With a short unix socket pathname the buffer was to small to store the address and convert_un_in() failed. Thanks to Grigorij Demidov Signed-off-by: Andreas Schneider Reviewed-by: Stefan Metzmacher --- Summary of changes: src/socket_wrapper.c | 10 ++ tests/torture.c | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) Changeset truncated at 500 lines: diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c index 6691738..3c0c279 100644 --- a/src/socket_wrapper.c +++ b/src/socket_wrapper.c @@ -4603,6 +4603,9 @@ static ssize_t swrap_recvmsg(int s, struct msghdr *omsg, int flags) struct swrap_address from_addr = { .sa_socklen = sizeof(struct sockaddr_un), }; + struct swrap_address convert_addr = { + .sa_socklen = sizeof(struct sockaddr_storage), + }; struct socket_info *si; struct msghdr msg; struct iovec tmp; @@ -4661,6 +4664,13 @@ static ssize_t swrap_recvmsg(int s, struct msghdr *omsg, int flags) } #endif + /* +* We convert the unix address to a IP address so we need a buffer +* which can store the address in case of SOCK_DGRAM, see below. +*/ + msg.msg_name = _addr.sa; + msg.msg_namelen = convert_addr.sa_socklen; + rc = swrap_recvmsg_after(s, si, , diff --git a/tests/torture.c b/tests/torture.c index 821f0ab..d3ad84a 100644 --- a/tests/torture.c +++ b/tests/torture.c @@ -55,7 +55,7 @@ #define TORTURE_ECHO_SRV_IPV6 "fd00::5357:5f0a" #define TORTURE_ECHO_SRV_PORT 7 -#define TORTURE_SOCKET_DIR "/tmp/test_socket_wrapper_XX" +#define TORTURE_SOCKET_DIR "/tmp/w_XX" #define TORTURE_ECHO_SRV_PIDFILE "echo_srv.pid" #define TORTURE_PCAP_FILE "socket_trace.pcap" -- Socket Wrapper Repository