[SCM] Samba Shared Repository - branch master updated

[Michael Adam]

The branch, master has been updated
   via  1be7e8b smbd: remove function name from a DBG_INFO in a recent 
commit
  from  d4c2395 smbd: do not disable "store dos attributes" on-the-fly

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 1be7e8b9d89fb061ca5707831b6a1151def89be4
Author: Uri Simchoni 
Date:   Sun Dec 27 07:17:58 2015 +0200

smbd: remove function name from a DBG_INFO in a recent commit

We now have  embedded automatically into DBG_XXX-
generated messages.

Signed-off-by: Uri Simchoni 
Reviewed-by: Michael Adam 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Tue Dec 29 04:18:19 CET 2015 on sn-devel-144

---

Summary of changes:
 source3/smbd/dosmode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index 942d286..ecc211c 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -279,7 +279,7 @@ static bool get_ea_dos_attribute(connection_struct *conn,
   SAMBA_XATTR_DOS_ATTRIB, attrstr,
   sizeof(attrstr));
if (sizeret == -1) {
-   DBG_INFO("get_ea_dos_attribute: Cannot get attribute "
+   DBG_INFO("Cannot get attribute "
 "from EA on file %s: Error = %s\n",
 smb_fname_str_dbg(smb_fname), strerror(errno));
return False;
@@ -413,7 +413,7 @@ static bool set_ea_dos_attribute(connection_struct *conn,
files_struct *fsp = NULL;
 
if((errno != EPERM) && (errno != EACCES)) {
-   DBG_INFO("set_ea_dos_attributes: Cannot set "
+   DBG_INFO("Cannot set "
 "attribute EA on file %s: Error = %s\n",
 smb_fname_str_dbg(smb_fname), strerror(errno));
return false;


-- 
Samba Shared Repository

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2015-12-29-0543/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2015-12-29-0543/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2015-12-29-0543/samba.stdout
  
The top commit at the time of the failure was:

commit d4c2395e6428312854b8570064bddab3a7f188ff
Author: Uri Simchoni 
Date:   Thu Dec 24 08:10:11 2015 +0200

smbd: do not disable "store dos attributes" on-the-fly

Smbd would disable "store dos attributes" on-the-fly if the
attempt to set/get user.DOSATTRIB fails with ENOTSUP or ENOSYS.
The rationale behind it was that the file system does not support
extended attributes, so there's no need to fill up the log with
failure messages.

However, a "wide symlink" could point to a spot that doesn't support
extended attributes. Even with the default banned wide links, we
currenly allow stat'ing those files and follow the symlink, and this
in turn would disable "store dos attributes" for the whole share.
The user.DOSATTRIB attribute also stores file creation time,
so that is also affected.

Another case where this behavior would turn storage of DOS attributes
off is that of the ".." entry at the root of the share, if the parent
folder for the share's root path does not support extended attributes.

On the other hand, the information on the file system and its support
of extended attributes is readily available, so the fix for explosion
of the log should be not to configure "store dos attributes" on
such a share.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11649

Signed-off-by: Uri Simchoni 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Fri Dec 25 13:20:58 CET 2015 on sn-devel-144

autobuild[sn-devel-104]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2015-12-29-0842/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2015-12-29-0842/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2015-12-29-0842/samba.stdout
  
The top commit at the time of the failure was:

commit 1be7e8b9d89fb061ca5707831b6a1151def89be4
Author: Uri Simchoni 
Date:   Sun Dec 27 07:17:58 2015 +0200

smbd: remove function name from a DBG_INFO in a recent commit

We now have  embedded automatically into DBG_XXX-
generated messages.

Signed-off-by: Uri Simchoni 
Reviewed-by: Michael Adam 

Autobuild-User(master): Michael Adam 
Autobuild-Date(master): Tue Dec 29 04:18:19 CET 2015 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
   via  73f01cd torture:smb2: fix copy'n'paste error in 
durable-open:open2:lease test
  from  1be7e8b smbd: remove function name from a DBG_INFO in a recent 
commit

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 73f01cd2f11029bde5cd789f1923342cbb1b065a
Author: Michael Adam 
Date:   Tue Dec 29 00:44:11 2015 +0100

torture:smb2: fix copy'n'paste error in durable-open:open2:lease test

Checking against the correct smb2_create object also lets us
check the correct create action (EXISTED vs CREATED).

Observed when this showed up in flakey test results.

Signed-off-by: Michael Adam 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Dec 29 08:34:03 CET 2015 on sn-devel-144

---

Summary of changes:
 source4/torture/smb2/durable_open.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/smb2/durable_open.c 
b/source4/torture/smb2/durable_open.c
index bb32f96..fe0a326 100644
--- a/source4/torture/smb2/durable_open.c
+++ b/source4/torture/smb2/durable_open.c
@@ -2112,7 +2112,7 @@ static bool test_durable_open_open2_lease(struct 
torture_context *tctx,
status = smb2_create(tree2, mem_ctx, );
CHECK_STATUS(status, NT_STATUS_OK);
h2 = io2.out.file.handle;
-   CHECK_CREATED(, CREATED, FILE_ATTRIBUTE_ARCHIVE);
+   CHECK_CREATED(, EXISTED, FILE_ATTRIBUTE_ARCHIVE);
 
/* Reconnect */
if (!torture_smb2_connection_ext(tctx, 0, , )) {


-- 
Samba Shared Repository