[SCM] Samba Shared Repository - branch master updated

2016-01-18 Thread Volker Lendecke 
The branch, master has been updated
   via  d51a635 ctdb-build: Fix -O3 developer build
  from  594778e ldb-samba: Expand testing of recursive search

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit d51a63554f5cf385af5b6e4d7aa1fc64dde3641f
Author: Amitay Isaacs 
Date:   Fri Jan 15 12:24:04 2016 +1100

ctdb-build: Fix -O3 developer build

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Mon Jan 18 14:32:05 CET 2016 on sn-devel-144

---

Summary of changes:
 ctdb/tests/src/pkt_read_test.c  | 2 +-
 ctdb/tests/src/pkt_write_test.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/tests/src/pkt_read_test.c b/ctdb/tests/src/pkt_read_test.c
index 6dfd5a0..7e089ec 100644
--- a/ctdb/tests/src/pkt_read_test.c
+++ b/ctdb/tests/src/pkt_read_test.c
@@ -39,7 +39,7 @@ static void writer(int fd)
for (i=0; i<1000; i++) {
for (j=0; j<4; j++) {
buflen = pkt_size[j];
-   *(uint32_t *)buf = buflen;
+   memcpy(buf, , sizeof(buflen));
 
ret = write(fd, buf, buflen);
if (ret < 0) {
diff --git a/ctdb/tests/src/pkt_write_test.c b/ctdb/tests/src/pkt_write_test.c
index 0a5c654..191e8b3 100644
--- a/ctdb/tests/src/pkt_write_test.c
+++ b/ctdb/tests/src/pkt_write_test.c
@@ -157,7 +157,7 @@ static void writer(int fd)
 
for (i=0; i<4; i++) {
buflen = pkt_size[i];
-   *(uint32_t *)buf = buflen;
+   memcpy(buf, , sizeof(buflen));
 
req = writer_send(mem_ctx, ev, fd, buf, buflen);
assert(req != NULL);


-- 
Samba Shared Repository

[SCM] pam wrapper repository - branch master updated

2016-01-18 Thread Michael Adam 
The branch, master has been updated
   via  31d374c Bump version to 1.0.1
   via  3b1d585 pwrap: Fix a possible timing issue in p_copy()
   via  c91b203 pwrap: Improve p_rmdirs() do avoid timing issues
   via  d3cfb7a pwrap: Remove superfloues lstat()
   via  490ae6a pwrap: Make sure we have a terminating null byte
   via  e2628f0 pam_matrix: Set a secure umask before calling mkstemp()
   via  0b43f0c pwrap: Return EPROTONOSUPPORT in audit_open()
   via  92c01c8 cmake: Link python module against the python library
   via  55ff828 cmake: Do not require a C++ compiler
  from  746496c Initial release of pam_wrapper 1.0.0

https://git.samba.org/?p=pam_wrapper.git;a=shortlog;h=master


- Log -
commit 31d374cda4e3ce1f57d290d46ef3a97d6ed0b076
Author: Andreas Schneider 
Date:   Mon Jan 18 09:18:56 2016 +0100

Bump version to 1.0.1

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 3b1d585468c7fbd6402f75e27096a19f3620b940
Author: Andreas Schneider 
Date:   Fri Jan 15 15:20:24 2016 +0100

pwrap: Fix a possible timing issue in p_copy()

Do not rely on stat before open - it is racy.
Open directly and treat failure appropriately.

CID: 47518

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit c91b2033bebe69ff5bab67c8db960ac5ec021268
Author: Jakub Hrozek 
Date:   Fri Jan 15 12:55:51 2016 +0100

pwrap: Improve p_rmdirs() do avoid timing issues

When calling stat and rmdir, we could run into timing issues that the
stat information is incorrect till we are actually running the rmdir()
command. So we open the directory and have the handle open to avoid
that we work on outdated information. It is unlikely but Coverity
complains and we thought better fix it.

CID: 47519

Signed-off-by: Jakub Hrozek 
Reviewed-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit d3cfb7af2a8f5ce844c46ce8c5fade8df1e2e429
Author: Andreas Schneider 
Date:   Fri Jan 15 11:11:50 2016 +0100

pwrap: Remove superfloues lstat()

There is no need to check if the file exists, just try to open it.

CID: 47520

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 490ae6a25ddf21963095d6d3c66a086fbc6147f9
Author: Andreas Schneider 
Date:   Fri Jan 15 11:44:14 2016 +0100

pwrap: Make sure we have a terminating null byte

This is just to silence Coverity.

CID: 47508

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit e2628f07ce78abfbe5e29b4d3b6db707c2677063
Author: Andreas Schneider 
Date:   Fri Jan 15 11:38:00 2016 +0100

pam_matrix: Set a secure umask before calling mkstemp()

CID: 47516

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 0b43f0cd311d352806f5cd4f867a4a8efb29546e
Author: Andreas Schneider 
Date:   Thu Jan 14 17:04:33 2016 +0100

pwrap: Return EPROTONOSUPPORT in audit_open()

I don't know why but returning EINVAL doesn't work. It treats it as
success and tries to write to it.

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 92c01c80103034d4a3cdd92aa4d00c34d687300d
Author: Andreas Schneider 
Date:   Thu Jan 14 17:04:07 2016 +0100

cmake: Link python module against the python library

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

commit 55ff828e58ff9a29badb19f6d5b68e7fe7a990f8
Author: Andreas Schneider 
Date:   Thu Jan 14 13:46:01 2016 +0100

cmake: Do not require a C++ compiler

Signed-off-by: Andreas Schneider 
Reviewed-by: Michael Adam 

---

Summary of changes:
 CMakeLists.txt |   4 +-
 ChangeLog  |   5 ++
 src/modules/CMakeLists.txt |   2 +-
 src/modules/pam_matrix.c   |   2 +-
 src/pam_wrapper.c  | 208 ++---
 src/python/CMakeLists.txt  |   4 +-
 6 files changed, 111 insertions(+), 114 deletions(-)


Changeset truncated at 500 lines:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8709a14..1674909 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@ set(APPLICATION_NAME ${PROJECT_NAME})
 
 set(APPLICATION_VERSION_MAJOR "1")
 set(APPLICATION_VERSION_MINOR "0")
-set(APPLICATION_VERSION_PATCH "0")
+set(APPLICATION_VERSION_PATCH "1")

[SCM] pam wrapper repository - annotated tag pam_wrapper-1.0.1 created

2016-01-18 Thread Andreas Schneider 
The annotated tag, pam_wrapper-1.0.1 has been created
at  638770c9dcbc14c877c71ff34a1f8cd5cd950b1e (tag)
   tagging  31d374cda4e3ce1f57d290d46ef3a97d6ed0b076 (commit)
 tagged by  Andreas Schneider
on  Mon Jan 18 11:12:27 2016 +0100

- Log -
pam_wrapper-1.0.1
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAABCgAGBQJWnLqPAAoJEH7g/E3MAU49N10QAIJvgKHIEL3AIhNz7x6Zp6WL
ca+Gf24/NHCUfJb304wnWk2itbgxkcy5iCb93ViYzRSAR64JChPt8rEjzarIcwY3
72QQ2cRBxd4cTy8ON6YiwgBtEUbyhqD+8TiNiWlB3cEIJkZg6cOyx8YCMkWoQSfe
Qbt0/ROi5ZNnI0nfKsfurEMYfLRtCMuGatvHmUwPrd5qd3Wvcnz+79vV5VBwFbBv
9cs8oq15dXLjBC3JLO7l0rROoUA1NTD3LDK+k9VtbRYvjAgzYzf455UqocBome3g
VDS55r2Vz6fFYfKMQQPM5oETaeUlct9go9gzPnpRWZXDhEeLKP2RTkgqet900EbK
lC1Pjw94l11eVhDNz1D4DNTLNEkHmmEKvvTb9KmwCx04T/3jsu2iftAuFMwuNG/p
wWtedYOlohxgl/ntBVwY/jiOVeMJ/wWejYCl43ZlmAOTSDbQuk/ClgYmYmE8FbPu
MorgCoEvwvJZqgIIftUSauDsNC/HsrNeFObZIRdtXkZkeHdzbRwkf+Q658+F/3Yt
IEEF5c+LXe/p+sPtVEI+NQX5w0t9Ti4gSRKMnexcJw5oe4FHtwn2GWXf+JJ1+aXi
ZADV96SIz9H0TTM+Ds72aZvCPdNYbS/vSdz2pnMboN7tLLNFqLztwCapMEBc/jov
K1r+FDr+534vIsEzezoE
=RAQ4
-END PGP SIGNATURE-

Andreas Schneider (56):
  Big bang!
  pwrap: Create pam_wrapper directory on init.
  pwrap: Remove config directory if we cleanup
  WIP copy libpam.so and edit it on the fly ...
  pwrap: Add wrapping of PAM functions
  pwrap: Fix libpam dlopen
  pwrap: Handle absolute path links
  doc: Add initial manpage so installation works
  pwrap: Improve error log message
  pwrap: Improve debug messages
  pwrap: Allow more directories
  libpamtest: add documentation, change macros to look better
  pwrap: Clean stale dirs
  s/PAM_WRAPPER_CONFDIR/PAM_WRAPPER_SERVICEDIR
  Improve build
  python: Support python2
  cmake: Set correct versions for libraries
  cmake: Ignore build directories
  cmake: Add cmake config files for libpamtest
  pam_matrix: Add OpenPAM (BSD) support
  tests: Fix printf attribute warnings
  ctest: Drop ctest results via https
  tests: Do not run python test if python is not present
  libpamtest: Make sure reply is initialized
  libpamtest: Do not call pam_end() if tc is not set
  py: Make sure we do not dereference a NULL pointer
  py: Make sure we do not use failed uninitialized
  py: Fix strict aliasing rules in set_pypamtest_exception()
  py: Fix strict aliasing rules in initpypamtest()
  pwrap: Add log message for directory cleanup
  pwrap: Close the pidfile in pwrap_init()
  pwrap: Do not fail on EOL in pwrap_clean_stale_dirs()
  pwrap: Add more debug messages if something goes wrong
  pwrap: Fix a resource leak in p_rmdirs()
  pwrap: Do not close negative fds in p_copy()
  cmake: Use python_add_module function
  cmake: Add FindPythonSiteLibs.cmake
  cmake: Find the python executable and site libs
  cmake: Install pypamtest
  cmake: Link pam_wrapper to libdl
  tests: Do not dreference key before NULL check in string_in_list()
  tests: Fix a possible memory leak in pwrap_conv()
  python: Remove dead code in test_result_list_concat()
  pwrap: Wrap audit_open() to fix sshd
  libpamtest: Make sure ri is not used uninitialized
  pwrap: Make sure pam_library is null-terminated
  pam_matrix: Call umask before mkstemp()
  Initial release of pam_wrapper 1.0.0
  cmake: Do not require a C++ compiler
  cmake: Link python module against the python library
  pwrap: Return EPROTONOSUPPORT in audit_open()
  pam_matrix: Set a secure umask before calling mkstemp()
  pwrap: Make sure we have a terminating null byte
  pwrap: Remove superfloues lstat()
  pwrap: Fix a possible timing issue in p_copy()
  Bump version to 1.0.1

Jakub Hrozek (43):
  pwrap: Add a test for pam_authenticate
  pwrap: wrap pam_acct
  pwrap: wrap pam_putenv, pam_getenv, pam_getenvlist
  pwrap: Wrap session open/close
  pwrap: Wrap pam_chauthtok
  pwrap: Wrap pam_setcred
  pwrap: wrap pam_getitem and pam_setitem
  pwrap: Wrap pam_get_data/pam_set_data
  pwrap: Wrap prompting functions
  pwrap: wrap pam_strerror
  pwrap: Rename pam_example.so to pam_matrix.so
  Build pam_matrix in src, install into libdir/pam_wrapper
  pam_matrix: Allow passing passdb as an option
  pam_matrix: Use colon-separated passdb
  pwrap: Only enable pam_wrapper if both PAM_WRAPPER and 
PAM_WRAPPER_CONFDIR are set
  pwrap: Do run destructor unless initialised
  pwrap: Remove uid_wrapper reference
  pwrap: wrap pam_syslog
  pamtest: Add libpamtest
  convert pam_wrapper tests to libpamtest
  Use find_library to find libpam.0
  Add Travis YAML file
  pwrap: Export service directory in environment variable
  pwrap: Add pam_get_items.so and pam_set_items.so
  pamtest: Capture info and error messages from conversation

autobuild[sn-devel-144]: intermittent test failure detected

2016-01-18 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-19-0540/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-19-0540/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2016-01-19-0540/samba.stdout
  
The top commit at the time of the failure was:

commit d51a63554f5cf385af5b6e4d7aa1fc64dde3641f
Author: Amitay Isaacs 
Date:   Fri Jan 15 12:24:04 2016 +1100

ctdb-build: Fix -O3 developer build

Signed-off-by: Amitay Isaacs 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Volker Lendecke 
Autobuild-Date(master): Mon Jan 18 14:32:05 CET 2016 on sn-devel-144