autobuild[sn-devel-104]: intermittent test failure detected

2016-10-25 Thread autobuild
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-26-0406/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-26-0406/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-26-0406/samba.stdout
  
The top commit at the time of the failure was:

commit 84786c83054731b8fc304289dfea7c6d0e40148c
Author: David Disseldorp 
Date:   Tue Oct 25 18:25:02 2016 +0200

libsmb: fix leak in opendir error path

Fixes CID 242325 - dir state and the talloc frame are leaked on
user_auth_info_init() failure.

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Oct 26 00:58:41 CEST 2016 on sn-devel-144



[SCM] Samba Shared Repository - branch master updated

2016-10-25 Thread Jeremy Allison
The branch, master has been updated
   via  84786c8 libsmb: fix leak in opendir error path
  from  ca5e109 waf: Cleanup deps list for smbd

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 84786c83054731b8fc304289dfea7c6d0e40148c
Author: David Disseldorp 
Date:   Tue Oct 25 18:25:02 2016 +0200

libsmb: fix leak in opendir error path

Fixes CID 242325 - dir state and the talloc frame are leaked on
user_auth_info_init() failure.

Signed-off-by: David Disseldorp 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Oct 26 00:58:41 CEST 2016 on sn-devel-144

---

Summary of changes:
 source3/libsmb/libsmb_dir.c | 6 ++
 1 file changed, 6 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/libsmb_dir.c b/source3/libsmb/libsmb_dir.c
index dd37a24..8bf3c6b 100644
--- a/source3/libsmb/libsmb_dir.c
+++ b/source3/libsmb/libsmb_dir.c
@@ -485,6 +485,12 @@ SMBC_opendir_ctx(SMBCCTX *context,
 
u_info = user_auth_info_init(frame);
if (u_info == NULL) {
+   if (dir) {
+   SAFE_FREE(dir->fname);
+   SAFE_FREE(dir);
+   }
+   TALLOC_FREE(frame);
+   errno = ENOMEM;
return NULL;
}
set_cmdline_auth_info_username(u_info, user);


-- 
Samba Shared Repository



autobuild[sn-devel-104]: intermittent test failure detected

2016-10-25 Thread autobuild
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-26-0009/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-26-0009/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-26-0009/samba.stdout
  
The top commit at the time of the failure was:

commit ca5e109353864371b051b79f05f97dbef751b49e
Author: Andreas Schneider 
Date:   Tue Oct 18 19:06:13 2016 +0200

waf: Cleanup deps list for smbd

Signed-off-by: Andreas Schneider 
Reviewed-by: Jim McDonough 

Autobuild-User(master): Jim McDonough 
Autobuild-Date(master): Tue Oct 25 21:10:37 CEST 2016 on sn-devel-144



[SCM] Socket Wrapper Repository - branch master updated

2016-10-25 Thread Michael Adam
The branch, master has been updated
   via  63d83be swrap: Fix use-after-free
  from  85c2d66 swrap: fix SWRAP_DLIST_ADD_AFTER

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit 63d83be5925bcefc64275be5ccb2312596bf5ce8
Author: Anoop C S 
Date:   Tue Oct 25 22:33:10 2016 +0530

swrap: Fix use-after-free

This was introduced by commit 9ce583b6cd6f55d473e5b54794fb06450997ebc8

Signed-off-by: Anoop C S 
Reviewed-by: Michael Adam 
Reviewed-by: Andreas Schneider 

---

Summary of changes:
 src/socket_wrapper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c
index d40f8b6..ece5a10 100644
--- a/src/socket_wrapper.c
+++ b/src/socket_wrapper.c
@@ -1733,7 +1733,7 @@ static void swrap_remove_stale(int fd)
SWRAP_DLIST_REMOVE(socket_fds, fi);
free(fi);
 
-   si = [fi->si_index];
+   si = [si_index];
si->refcount--;
 
if (si->refcount > 0) {


-- 
Socket Wrapper Repository



[SCM] Samba Shared Repository - branch master updated

2016-10-25 Thread Jim McDonough
The branch, master has been updated
   via  ca5e109 waf: Cleanup deps list for smbd
   via  dd2367d waf: Cleanup deps list for smbregistry
  from  71b69b0 Revert "ctdb-common: Use SCHED_RESET_ON_FORK when setting 
SCHED_FIFO"

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ca5e109353864371b051b79f05f97dbef751b49e
Author: Andreas Schneider 
Date:   Tue Oct 18 19:06:13 2016 +0200

waf: Cleanup deps list for smbd

Signed-off-by: Andreas Schneider 
Reviewed-by: Jim McDonough 

Autobuild-User(master): Jim McDonough 
Autobuild-Date(master): Tue Oct 25 21:10:37 CEST 2016 on sn-devel-144

commit dd2367dc12331974411c134247bb45fa5d71c2a1
Author: Andreas Schneider 
Date:   Tue Oct 18 16:05:07 2016 +0200

waf: Cleanup deps list for smbregistry

Signed-off-by: Andreas Schneider 
Reviewed-by: Jim McDonough 

---

Summary of changes:
 source3/wscript_build | 25 +
 1 file changed, 21 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/wscript_build b/source3/wscript_build
index 6918c73..1e16062 100755
--- a/source3/wscript_build
+++ b/source3/wscript_build
@@ -208,9 +208,20 @@ bld.SAMBA3_LIBRARY('smbregistry',
lib/cbuf.c
lib/srprs.c
registry/reg_init_basic.c''',
-   deps='''smbd_shim tdb-wrap3 NDR_SECURITY util_tdb talloc
-   replace util_reg samba-util samba-security
-   errors3 dbwrap samba3-util''',
+   deps='''
+smbd_shim
+tdb-wrap3
+NDR_SECURITY
+util_tdb
+talloc
+replace
+util_reg
+samba-util
+samba-security
+errors3
+dbwrap
+samba3-util
+''',
allow_undefined_symbols=True,
private_library=True)
 
@@ -852,7 +863,13 @@ bld.SAMBA3_SUBSYSTEM('LIBLSA',
 
 bld.SAMBA3_BINARY('smbd/smbd',
  source='smbd/server.c smbd/smbd_cleanupd.c',
- deps='smbd_base EPMD LSASD FSSD MDSSD',
+ deps='''
+  smbd_base
+  EPMD
+  LSASD
+  FSSD
+  MDSSD
+  ''',
  install_path='${SBINDIR}')
 
 bld.SAMBA3_BINARY('nmbd/nmbd',


-- 
Samba Shared Repository



autobuild[sn-devel-104]: intermittent test failure detected

2016-10-25 Thread autobuild
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-2008/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-2008/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-2008/samba.stdout
  
The top commit at the time of the failure was:

commit 71b69b0169dc6e2843325f1567f64b6acd43e6b8
Author: Amitay Isaacs 
Date:   Mon Oct 24 18:24:54 2016 +1100

Revert "ctdb-common: Use SCHED_RESET_ON_FORK when setting SCHED_FIFO"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12392

Feature SCHED_RESET_ON_FORK is completely broken on RHEL6 and RHEL7
distributions.  So do not rely on SCHED_RESET_ON_FORK for now.

This reverts commit 1be8564e553ce044426dbe7b3987edf514832940.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Oct 25 11:28:28 CEST 2016 on sn-devel-144



[SCM] Socket Wrapper Repository - branch master updated

2016-10-25 Thread Michael Adam
The branch, master has been updated
   via  85c2d66 swrap: fix SWRAP_DLIST_ADD_AFTER
  from  9ce583b swrap: fix use-after-free in swrap_remove_stale()

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit 85c2d663ec4dc7dc0170df676721e9a63f18fe40
Author: Anoop C S 
Date:   Tue Oct 25 15:56:20 2016 +0200

swrap: fix SWRAP_DLIST_ADD_AFTER

Pair-Programmed-With: Michael Adam 

Signed-off-by: Anoop C S 
Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 

---

Summary of changes:
 src/socket_wrapper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c
index 40e2f04..d40f8b6 100644
--- a/src/socket_wrapper.c
+++ b/src/socket_wrapper.c
@@ -211,7 +211,7 @@ enum swrap_dbglvl_e {
 
 #define SWRAP_DLIST_ADD_AFTER(list, item, el) \
 do { \
-   if ((list) != NULL || (el) != NULL) { \
+   if ((list) == NULL || (el) == NULL) { \
SWRAP_DLIST_ADD(list, item); \
} else { \
(item)->prev = (el); \


-- 
Socket Wrapper Repository



autobuild[sn-devel-104]: intermittent test failure detected

2016-10-25 Thread autobuild
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-1609/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-1609/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-1609/samba.stdout
  
The top commit at the time of the failure was:

commit 71b69b0169dc6e2843325f1567f64b6acd43e6b8
Author: Amitay Isaacs 
Date:   Mon Oct 24 18:24:54 2016 +1100

Revert "ctdb-common: Use SCHED_RESET_ON_FORK when setting SCHED_FIFO"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12392

Feature SCHED_RESET_ON_FORK is completely broken on RHEL6 and RHEL7
distributions.  So do not rely on SCHED_RESET_ON_FORK for now.

This reverts commit 1be8564e553ce044426dbe7b3987edf514832940.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Oct 25 11:28:28 CEST 2016 on sn-devel-144



[SCM] Socket Wrapper Repository - branch master updated

2016-10-25 Thread Michael Adam
The branch, master has been updated
   via  9ce583b swrap: fix use-after-free in swrap_remove_stale()
   via  ddba8cf swrap: slightly cleanup logic in swrap_close
   via  3b39c88 swrap: fix use-after-free in swrap_close
  from  d4cdce1 swrap: Fix build on Solaris

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit 9ce583b6cd6f55d473e5b54794fb06450997ebc8
Author: Michael Adam 
Date:   Tue Oct 25 13:46:18 2016 +0200

swrap: fix use-after-free in swrap_remove_stale()

Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 

commit ddba8cf2058d662d628fc62f5896b873754ba7c3
Author: Michael Adam 
Date:   Tue Oct 25 13:42:05 2016 +0200

swrap: slightly cleanup logic in swrap_close

This moves the libc_close() to one central point, thereby
grouping the fd-related operations together and the the
socket-info related operations after that.

Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 

commit 3b39c88b138f88bffc7d71572a9c6a83e54a03c9
Author: Michael Adam 
Date:   Tue Oct 25 13:41:29 2016 +0200

swrap: fix use-after-free in swrap_close

Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 

---

Summary of changes:
 src/socket_wrapper.c | 18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c
index 82d27e5..40e2f04 100644
--- a/src/socket_wrapper.c
+++ b/src/socket_wrapper.c
@@ -1721,17 +1721,19 @@ static void swrap_remove_stale(int fd)
 {
struct socket_info_fd *fi = find_socket_info_fd(fd);
struct socket_info *si;
+   int si_index;
 
if (fi == NULL) {
return;
}
 
-   si = [fi->si_index];
+   si_index = fi->si_index;
 
SWRAP_LOG(SWRAP_LOG_TRACE, "remove stale wrapper for %d", fd);
SWRAP_DLIST_REMOVE(socket_fds, fi);
free(fi);
 
+   si = [fi->si_index];
si->refcount--;
 
if (si->refcount > 0) {
@@ -1743,7 +1745,7 @@ static void swrap_remove_stale(int fd)
}
 
si->next_free = first_free;
-   first_free = fi->si_index;
+   first_free = si_index;
 }
 
 static int sockaddr_convert_to_un(struct socket_info *si,
@@ -5351,30 +5353,32 @@ static int swrap_close(int fd)
 {
struct socket_info_fd *fi = find_socket_info_fd(fd);
struct socket_info *si = NULL;
+   int si_index;
int ret;
 
if (fi == NULL) {
return libc_close(fd);
}
 
-   si = [fi->si_index];
+   si_index = fi->si_index;
 
SWRAP_DLIST_REMOVE(socket_fds, fi);
free(fi);
 
+   ret = libc_close(fd);
+
+   si = [si_index];
si->refcount--;
 
if (si->refcount > 0) {
/* there are still references left */
-   return libc_close(fd);
+   return ret;
}
 
if (si->myname.sa_socklen > 0 && si->peername.sa_socklen > 0) {
swrap_pcap_dump_packet(si, NULL, SWRAP_CLOSE_SEND, NULL, 0);
}
 
-   ret = libc_close(fd);
-
if (si->myname.sa_socklen > 0 && si->peername.sa_socklen > 0) {
swrap_pcap_dump_packet(si, NULL, SWRAP_CLOSE_RECV, NULL, 0);
swrap_pcap_dump_packet(si, NULL, SWRAP_CLOSE_ACK, NULL, 0);
@@ -5385,7 +5389,7 @@ static int swrap_close(int fd)
}
 
si->next_free = first_free;
-   first_free = fi->si_index;
+   first_free = si_index;
 
return ret;
 }


-- 
Socket Wrapper Repository



[SCM] Samba Shared Repository - branch v4-4-test updated

2016-10-25 Thread Karolin Seeger
The branch, v4-4-test has been updated
   via  d6a814c VERSION: Bump version up to 4.4.8...
   via  b2d2088 VERSION: Disable git snapshots for the 4.4.7 release.
   via  e0ebfb9 WHATSNEW: Add release notes for Samba 4.4.7.
  from  5a0b28a lib: Fix bug 12291

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-4-test


- Log -
commit d6a814c770d5888e5340a5a677c5324c2fe734f8
Author: Karolin Seeger 
Date:   Tue Oct 25 12:39:39 2016 +0200

VERSION: Bump version up to 4.4.8...

and re-enable git snapshots.

Signed-off-by: Karolin Seeger 

commit b2d208800c3c699765b06a3f101761f68f99a717
Author: Karolin Seeger 
Date:   Tue Oct 25 12:38:13 2016 +0200

VERSION: Disable git snapshots for the 4.4.7 release.

Signed-off-by: Karolin Seeger 

commit e0ebfb9957ea7b025cbce2f3c843126ae9845671
Author: Karolin Seeger 
Date:   Tue Oct 25 11:53:06 2016 +0200

WHATSNEW: Add release notes for Samba 4.4.7.

Signed-off-by: Karolin Seeger 

---

Summary of changes:
 VERSION  |   2 +-
 WHATSNEW.txt | 105 +--
 2 files changed, 104 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/VERSION b/VERSION
index ee709f3..b31b515 100644
--- a/VERSION
+++ b/VERSION
@@ -25,7 +25,7 @@
 
 SAMBA_VERSION_MAJOR=4
 SAMBA_VERSION_MINOR=4
-SAMBA_VERSION_RELEASE=7
+SAMBA_VERSION_RELEASE=8
 
 
 # If a official release has a serious bug  #
diff --git a/WHATSNEW.txt b/WHATSNEW.txt
index 7970201..7268196 100644
--- a/WHATSNEW.txt
+++ b/WHATSNEW.txt
@@ -1,4 +1,105 @@
=
+   Release Notes for Samba 4.4.7
+ October 26, 2016
+   =
+
+
+This is the latest stable release of Samba 4.4.
+
+Major enhancements in Samba 4.4.7 include:
+
+o  Let winbindd discard expired kerberos tickets when built against
+   (internal) heimdal (BUG #12369).
+o  REGRESSION: smbd segfaults on startup, tevent context being freed
+   (BUG #12283).
+
+
+Changes since 4.4.6:
+
+
+o  Jeremy Allison 
+   * BUG 11259: smbd contacts a domain controller for each session.
+   * BUG 12283: REGRESSION: smbd segfaults on startup, tevent context being
+ freed.
+   * BUG 12291: source3/lib/msghdr: Fix syntax error before or at: ;.
+   * BUG 12381: s3: cldap: cldap_multi_netlogon_send() fails with one bad IPv6
+ address.
+
+o  Christian Ambach 
+   * BUG 9945: Setting specific logger levels in smb.conf makes 'samba-tool drs
+ showrepl' crash.
+
+o  Björn Baumbach 
+   * BUG 8618: s3-printing: Fix migrate printer code.
+
+o  Ralph Boehme 
+   * BUG 12261: s3/smbd: Set FILE_ATTRIBUTE_DIRECTORY as necessary.
+
+o  Günther Deschner 
+   * BUG 12285: "DriverVersion" registry backend parsing incorrect in spoolss.
+
+o  David Disseldorp 
+   * BUG 12144: smbd/ioctl: Match WS2016 ReFS get compression behaviour.
+
+o  Amitay Isaacs 
+   * BUG 12287: CTDB PID file handling is too weak.
+
+o  Volker Lendecke 
+   * BUG 12045: gencache: Bail out of stabilize if we can not get the allrecord
+ lock.
+   * BUG 12283: glusterfs: Avoid tevent_internal.h.
+   * BUG 12374: spoolss: Fix caching of printername->sharename.
+
+o  Stefan Metzmacher 
+   * BUG 12283: REGRESSION: smbd segfaults on startup, tevent context being
+ freed.
+   * BUG 12369: Let winbindd discard expired kerberos tickets when built 
against
+ (internal) heimdal.
+
+o  Noel Power 
+   * BUG 12298: s3/winbindd: Using default domain with u...@domain.com format
+ fails.
+
+o  Jose A. Rivera 
+   * BUG 12362: ctdb-scripts: Avoid dividing by zero in memory calculation.
+
+o  Anoop C S 
+   * BUG 12377: vfs_glusterfs: Fix a memory leak in connect path.
+
+o  Andreas Schneider 
+   * BUG 12269: nss_wins has incorrect function definitions for gethostbyname*.
+   * BUG 12276: s3-lib: Fix %G substitution in AD member environment.
+   * BUG 12364: s3-utils: Fix loading smb.conf in smbcquotas.
+
+o  Martin Schwenke 
+   * BUG 12287: CTDB PID file handling is too weak.
+   * BUG 12362: ctdb-scripts: Fix incorrect variable reference.
+
+
+###
+Reporting bugs & Development Discussion
+###
+
+Please discuss this release on the samba-technical mailing list or by
+joining the 

autobuild[sn-devel-104]: intermittent test failure detected

2016-10-25 Thread autobuild
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-1208/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-1208/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-1208/samba.stdout
  
The top commit at the time of the failure was:

commit 71b69b0169dc6e2843325f1567f64b6acd43e6b8
Author: Amitay Isaacs 
Date:   Mon Oct 24 18:24:54 2016 +1100

Revert "ctdb-common: Use SCHED_RESET_ON_FORK when setting SCHED_FIFO"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12392

Feature SCHED_RESET_ON_FORK is completely broken on RHEL6 and RHEL7
distributions.  So do not rely on SCHED_RESET_ON_FORK for now.

This reverts commit 1be8564e553ce044426dbe7b3987edf514832940.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Oct 25 11:28:28 CEST 2016 on sn-devel-144



[SCM] Samba Shared Repository - branch master updated

2016-10-25 Thread Martin Schwenke
The branch, master has been updated
   via  71b69b0 Revert "ctdb-common: Use SCHED_RESET_ON_FORK when setting 
SCHED_FIFO"
  from  7594165 s3:smbd: only pass UCF_PREP_CREATEFILE to 
filename_convert() if we may create a new file

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 71b69b0169dc6e2843325f1567f64b6acd43e6b8
Author: Amitay Isaacs 
Date:   Mon Oct 24 18:24:54 2016 +1100

Revert "ctdb-common: Use SCHED_RESET_ON_FORK when setting SCHED_FIFO"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12392

Feature SCHED_RESET_ON_FORK is completely broken on RHEL6 and RHEL7
distributions.  So do not rely on SCHED_RESET_ON_FORK for now.

This reverts commit 1be8564e553ce044426dbe7b3987edf514832940.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Tue Oct 25 11:28:28 CEST 2016 on sn-devel-144

---

Summary of changes:
 ctdb/common/system_util.c | 8 +---
 1 file changed, 1 insertion(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/common/system_util.c b/ctdb/common/system_util.c
index 9fc6c44..9e897c2 100644
--- a/ctdb/common/system_util.c
+++ b/ctdb/common/system_util.c
@@ -68,14 +68,10 @@ bool set_scheduler(void)
 #else /* no AIX */
 #if HAVE_SCHED_SETSCHEDULER
struct sched_param p;
-   int policy = SCHED_FIFO;
 
p.sched_priority = 1;
 
-#ifdef SCHED_RESET_ON_FORK
-   policy |= SCHED_RESET_ON_FORK;
-#endif
-   if (sched_setscheduler(0, policy, ) == -1) {
+   if (sched_setscheduler(0, SCHED_FIFO, ) == -1) {
DEBUG(DEBUG_CRIT,("Unable to set scheduler to SCHED_FIFO 
(%s)\n",
 strerror(errno)));
return false;
@@ -108,7 +104,6 @@ void reset_scheduler(void)
 #endif
 #else /* no AIX */
 #if HAVE_SCHED_SETSCHEDULER
-#ifndef SCHED_RESET_ON_FORK
struct sched_param p;
 
p.sched_priority = 0;
@@ -117,7 +112,6 @@ void reset_scheduler(void)
}
 #endif
 #endif
-#endif
 }
 
 bool parse_ipv4(const char *s, unsigned port, struct sockaddr_in *sin)


-- 
Samba Shared Repository



autobuild[sn-devel-104]: intermittent test failure detected

2016-10-25 Thread autobuild
The autobuild test system (on sn-devel-104) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-0802/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-0802/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-104/2016-10-25-0802/samba.stdout
  
The top commit at the time of the failure was:

commit 759416582c54a16aacbef0e0dfe4649bddff8c5e
Author: Stefan Metzmacher 
Date:   Thu Oct 13 12:42:59 2016 +0200

s3:smbd: only pass UCF_PREP_CREATEFILE to filename_convert() if we may 
create a new file

This fixes a regression introduced by commit
f98d10af2a05f0261611f4cabdfe274cd9fe91c0
(smbd: Always use UCF_PREP_CREATEFILE for filename_convert calls to resolve 
a path for open)

The main problem was that Windows client seem to verify
the access to user.V2\ntuser.ini is rejected with NT_STATUS_ACCESS_DENIED,
using the machine credentials.

Passing UCF_PREP_CREATEFILE to filename_convert() triggers a code path
that implements a dropbox behaviour. A dropbox is a directory with only -wx 
permissions,
so get_real_filename fails with EACCESS, it needs to list the directory.
EACCESS is ignored with UCF_PREP_CREATEFILE.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10297

Signed-off-by: Stefan Metzmacher 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Tue Oct 25 05:33:36 CEST 2016 on sn-devel-144