autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-05-0408/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-05-0408/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-05-0408/samba.stdout The top commit at the time of the failure was: commit 815658d2db46e4accdd35f5925585ec1f1c3d74f Author: Garming SamDate: Tue Nov 1 16:29:53 2016 +1300 samba_tool/fsmo: Allocate RID Set when seizing RID manager Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira Signed-off-by: Clive Ferreira Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-05-0005/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-05-0005/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-05-0005/samba.stdout The top commit at the time of the failure was: commit 815658d2db46e4accdd35f5925585ec1f1c3d74f Author: Garming SamDate: Tue Nov 1 16:29:53 2016 +1300 samba_tool/fsmo: Allocate RID Set when seizing RID manager Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira Signed-off-by: Clive Ferreira Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-2007/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-2007/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-2007/samba.stdout The top commit at the time of the failure was: commit 815658d2db46e4accdd35f5925585ec1f1c3d74f Author: Garming SamDate: Tue Nov 1 16:29:53 2016 +1300 samba_tool/fsmo: Allocate RID Set when seizing RID manager Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira Signed-off-by: Clive Ferreira Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-1606/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-1606/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-1606/samba.stdout The top commit at the time of the failure was: commit 815658d2db46e4accdd35f5925585ec1f1c3d74f Author: Garming SamDate: Tue Nov 1 16:29:53 2016 +1300 samba_tool/fsmo: Allocate RID Set when seizing RID manager Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira Signed-off-by: Clive Ferreira Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144
[SCM] Samba Shared Repository - branch v4-5-test updated
The branch, v4-5-test has been updated via 3cbc061 ctdb-scripts: Fix calculation of CTDB_BASE via 0cc06c4 s3-winbind: Do not return NO_MEMORY if we have an empty user list from 9f2a816 provision: Add support for BIND 9.11.x https://git.samba.org/?p=samba.git;a=shortlog;h=v4-5-test - Log - commit 3cbc061b9270a951d4950319cb0962529a145264 Author: Amitay IsaacsDate: Thu Nov 3 16:03:24 2016 +1100 ctdb-scripts: Fix calculation of CTDB_BASE This is a regression introduced in f227c26178c2eaf3fae49f32a90ec905f85005f4. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12407 Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke Autobuild-User(master): Martin Schwenke Autobuild-Date(master): Thu Nov 3 10:10:31 CET 2016 on sn-devel-144 (cherry picked from commit 9c6f0dc69bd9eb2ca2bc1ca18c81762791958f88) Autobuild-User(v4-5-test): Karolin Seeger Autobuild-Date(v4-5-test): Fri Nov 4 15:46:09 CET 2016 on sn-devel-144 commit 0cc06c4cce019840402e52487d9096d29d44dba0 Author: Andreas Schneider Date: Wed Nov 2 17:19:09 2016 +0100 s3-winbind: Do not return NO_MEMORY if we have an empty user list The domain child for the MACHINE ACCOUNT might fail with NT_STATUS_NO_MEMORY because an emtpy user list is returned. *pnum_info is already set to 0 at the beginngin so we should just declare victory here! BUG: https://bugzilla.samba.org/show_bug.cgi?id=12405 Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison (cherry picked from commit e714dc03e0ccf9ec17da6bacc1bcfcaea7518e22) --- Summary of changes: ctdb/config/ctdb-crash-cleanup.sh | 2 +- ctdb/config/debug-hung-script.sh | 2 +- ctdb/config/debug_locks.sh| 2 +- ctdb/config/statd-callout | 2 +- source3/winbindd/winbindd_rpc.c | 4 5 files changed, 8 insertions(+), 4 deletions(-) Changeset truncated at 500 lines: diff --git a/ctdb/config/ctdb-crash-cleanup.sh b/ctdb/config/ctdb-crash-cleanup.sh index bcecbfe..22b0ce8 100755 --- a/ctdb/config/ctdb-crash-cleanup.sh +++ b/ctdb/config/ctdb-crash-cleanup.sh @@ -5,7 +5,7 @@ # [ -n "$CTDB_BASE" ] || \ -CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; dirname "$PWD") +CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; echo "$PWD") . "${CTDB_BASE}/functions" diff --git a/ctdb/config/debug-hung-script.sh b/ctdb/config/debug-hung-script.sh index cdf1657..da988c2 100755 --- a/ctdb/config/debug-hung-script.sh +++ b/ctdb/config/debug-hung-script.sh @@ -4,7 +4,7 @@ # for other operating systems. [ -n "$CTDB_BASE" ] || \ -CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; dirname "$PWD") +CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; echo "$PWD") . "${CTDB_BASE}/functions" diff --git a/ctdb/config/debug_locks.sh b/ctdb/config/debug_locks.sh index 8c9b466..f678724 100755 --- a/ctdb/config/debug_locks.sh +++ b/ctdb/config/debug_locks.sh @@ -8,7 +8,7 @@ # rather than mutex locks. [ -n "$CTDB_BASE" ] || \ -CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; dirname "$PWD") +CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; echo "$PWD") . "${CTDB_BASE}/functions" diff --git a/ctdb/config/statd-callout b/ctdb/config/statd-callout index 4ac354e..3f2dd39 100755 --- a/ctdb/config/statd-callout +++ b/ctdb/config/statd-callout @@ -9,7 +9,7 @@ # STATD_HOSTNAME="myhostname -H /etc/ctdb/statd-callout" [ -n "$CTDB_BASE" ] || \ -CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; dirname "$PWD") +CTDB_BASE=$(d=$(dirname "$0") ; cd -P "$d" ; echo "$PWD") . "${CTDB_BASE}/functions" diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c index 386396a..7b355ba 100644 --- a/source3/winbindd/winbindd_rpc.c +++ b/source3/winbindd/winbindd_rpc.c @@ -88,6 +88,10 @@ NTSTATUS rpc_query_user_list(TALLOC_CTX *mem_ctx, num_dom_users = disp_info.info1.count; num_info += num_dom_users; + /* If there are no user to enumerate we're done */ + if (num_info == 0) { + return NT_STATUS_OK; + } info = talloc_realloc(mem_ctx, info, -- Samba Shared Repository
[SCM] Samba Shared Repository - branch v4-4-test updated
The branch, v4-4-test has been updated via 37e476a s3-winbind: Do not return NO_MEMORY if we have an empty user list from 998ca31 provision: Add support for BIND 9.11.x https://git.samba.org/?p=samba.git;a=shortlog;h=v4-4-test - Log - commit 37e476a18a84bf0df9d383c1f09a738c8153ca2d Author: Andreas SchneiderDate: Wed Nov 2 17:19:09 2016 +0100 s3-winbind: Do not return NO_MEMORY if we have an empty user list The domain child for the MACHINE ACCOUNT might fail with NT_STATUS_NO_MEMORY because an emtpy user list is returned. *pnum_info is already set to 0 at the beginngin so we should just declare victory here! BUG: https://bugzilla.samba.org/show_bug.cgi?id=12405 Signed-off-by: Andreas Schneider Reviewed-by: Jeremy Allison (cherry picked from commit e714dc03e0ccf9ec17da6bacc1bcfcaea7518e22) Autobuild-User(v4-4-test): Karolin Seeger Autobuild-Date(v4-4-test): Fri Nov 4 15:18:16 CET 2016 on sn-devel-144 --- Summary of changes: source3/winbindd/winbindd_rpc.c | 4 1 file changed, 4 insertions(+) Changeset truncated at 500 lines: diff --git a/source3/winbindd/winbindd_rpc.c b/source3/winbindd/winbindd_rpc.c index 386396a..7b355ba 100644 --- a/source3/winbindd/winbindd_rpc.c +++ b/source3/winbindd/winbindd_rpc.c @@ -88,6 +88,10 @@ NTSTATUS rpc_query_user_list(TALLOC_CTX *mem_ctx, num_dom_users = disp_info.info1.count; num_info += num_dom_users; + /* If there are no user to enumerate we're done */ + if (num_info == 0) { + return NT_STATUS_OK; + } info = talloc_realloc(mem_ctx, info, -- Samba Shared Repository
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-1210/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-1210/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-1210/samba.stdout The top commit at the time of the failure was: commit 815658d2db46e4accdd35f5925585ec1f1c3d74f Author: Garming SamDate: Tue Nov 1 16:29:53 2016 +1300 samba_tool/fsmo: Allocate RID Set when seizing RID manager Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira Signed-off-by: Clive Ferreira Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144
[SCM] Socket Wrapper Repository - branch master updated
The branch, master has been updated via 888a62e swrap: Add sanity check in socket_wrapper_max_sockets() from 057a956 tests: Clean-up max_sockets test case https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master - Log - commit 888a62e2c81370ab32e9bc790f12419148bd8972 Author: Andreas SchneiderDate: Fri Nov 4 09:44:04 2016 +0100 swrap: Add sanity check in socket_wrapper_max_sockets() CID 153962 Signed-off-by: Andreas Schneider Reviewed-by: Michael Adam --- Summary of changes: src/socket_wrapper.c | 7 +++ 1 file changed, 7 insertions(+) Changeset truncated at 500 lines: diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c index ece5a10..186b696 100644 --- a/src/socket_wrapper.c +++ b/src/socket_wrapper.c @@ -259,6 +259,8 @@ do { \ */ #define SOCKET_WRAPPER_MAX_SOCKETS_DEFAULT 65535 +#define SOCKET_WRAPPER_MAX_SOCKETS_LIMIT 256000 + /* This limit is to avoid broadcast sendto() needing to stat too many * files. It may be raised (with a performance cost) to up to 254 * without changing the format above */ @@ -1141,6 +1143,11 @@ static size_t socket_wrapper_max_sockets(void) if (s == endp) { goto done; } + if (tmp == 0 || tmp > SOCKET_WRAPPER_MAX_SOCKETS_LIMIT) { + SWRAP_LOG(SWRAP_LOG_ERROR, + "Invalid number of sockets specified, using default."); + goto done; + } max_sockets = tmp; -- Socket Wrapper Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 815658d samba_tool/fsmo: Allocate RID Set when seizing RID manager via 2a49c74 python-libnet: Use new NTSTATUSError, WERRORError and DsExtendedError exceptions via e51256c python: Add DsExtendedError Exception via e737171 pyerrors: Add PyErr_Set{WERROR,HRESULT,NTSTATUS}_and_string() via c8505c5 python: create NTSTATUSError, HRESULTError and WERRORError via f72da5b dsdb: Catch errors in extended operations (like allocating a RID Set) via 46fefb2 dsdb: Rework DSDB code to use WERROR via fe90dad dsdb: Create RID Set as SYSTEM via 09537a6 dbcheck: Correctly initialise keep_transaction in missing_parent test via 7fd5be5 dbcheck: confirm RID Set presence and consistency via 035df7a dsdb: Add python hooks to allocate a RID set and allocate a RID pool via 1b40bb6 tests/ridalloc_exop: Add a new suite of tests for RID allocation from 9c6f0dc ctdb-scripts: Fix calculation of CTDB_BASE https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 815658d2db46e4accdd35f5925585ec1f1c3d74f Author: Garming SamDate: Tue Nov 1 16:29:53 2016 +1300 samba_tool/fsmo: Allocate RID Set when seizing RID manager Seizing the role without allocating a RID set for itself is likely prone to cause issues. Pair-programmed-with: Clive Ferreira Signed-off-by: Clive Ferreira Signed-off-by: Garming Sam Reviewed-by: Andrew Bartlett BUG: https://bugzilla.samba.org/show_bug.cgi?id=9954 Autobuild-User(master): Garming Sam Autobuild-Date(master): Fri Nov 4 08:37:05 CET 2016 on sn-devel-144 commit 2a49c7451949d42e5a4d6fce3ce607f05f9e7b71 Author: Andrew Bartlett Date: Tue Nov 1 12:38:48 2016 +1300 python-libnet: Use new NTSTATUSError, WERRORError and DsExtendedError exceptions This will allow callers to catch specific errors rather than RuntimeException As this slightly changes the exception, the timecmd test must be updated. Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 commit e51256c7d5804002fc189b55afbc58379f81 Author: Andrew Bartlett Date: Tue Nov 1 16:09:20 2016 +1300 python: Add DsExtendedError Exception This will be used for checking errors during a GetNCChanges EXOP like RID Set allocation. Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 commit e737171f6ef172de559b41d54989eca0d7663b4e Author: Andrew Bartlett Date: Tue Nov 1 16:03:09 2016 +1300 pyerrors: Add PyErr_Set{WERROR,HRESULT,NTSTATUS}_and_string() This varient allows control of the text explaination string Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 commit c8505c53da3e21f31454f121efd5961d95349a38 Author: Andrew Bartlett Date: Tue Nov 1 15:23:58 2016 +1300 python: create NTSTATUSError, HRESULTError and WERRORError The advantage of these over the previous use of just RuntimeError is that we can catch just the errors we want, without having to catch all possible RuntimeError cases and assume they decode to a tuple Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 commit f72da5ba51ae8bf9f3f54bed36b4572cd1b57adb Author: Andrew Bartlett Date: Mon Oct 31 16:25:51 2016 +1300 dsdb: Catch errors in extended operations (like allocating a RID Set) There are cases where allocating a RID Set can reasonably fail. Catch those nicely. Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam BUG: https://bugzilla.samba.org/show_bug.cgi?id=12398 commit 46fefb251f61b274cb687f6d1cb0a0a97fb36b44 Author: Andrew Bartlett Date: Mon Oct 31 16:19:37 2016 +1300 dsdb: Rework DSDB code to use WERROR The WERROR codes are more descriptive for DSDB issues, and almost all the code was converting from WERROR to NTSTATUS. This will allow us to better catch specific errors like WERR_DS_DRA_MISSING_PARENT Signed-off-by: Andrew Bartlett Reviewed-by: Garming Sam BUG:
autobuild[sn-devel-104]: intermittent test failure detected
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in the current master tree. The autobuild log of the failure is available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-0807/flakey.log The samba build logs are available here: http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-0807/samba.stderr http://git.samba.org/autobuild.flakey.sn-devel-104/2016-11-04-0807/samba.stdout The top commit at the time of the failure was: commit 9c6f0dc69bd9eb2ca2bc1ca18c81762791958f88 Author: Amitay IsaacsDate: Thu Nov 3 16:03:24 2016 +1100 ctdb-scripts: Fix calculation of CTDB_BASE This is a regression introduced in f227c26178c2eaf3fae49f32a90ec905f85005f4. BUG: https://bugzilla.samba.org/show_bug.cgi?id=12407 Signed-off-by: Amitay Isaacs Reviewed-by: Martin Schwenke Autobuild-User(master): Martin Schwenke Autobuild-Date(master): Thu Nov 3 10:10:31 CET 2016 on sn-devel-144