autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-03-18-0256/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-03-18-0256/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-03-18-0256/samba.stdout
  
The top commit at the time of the failure was:

commit ad758cb869ac83534993caa212abc9fe9905ec68
Author: Amitay Isaacs 
Date:   Tue Mar 14 16:12:55 2017 +1100

ctdb-readonly: Avoid a tight loop waiting for revoke to complete

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12697

During revoking readonly delegations, if one of the nodes disappears, then
there is no point re-trying revoking readonly delegation.  The database
needs to be recovered before the revoke operation can succeed.  So retry
only after a grace period.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Fri Mar 17 14:05:57 CET 2017 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

[autobuild]

The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-03-17-2135/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-03-17-2135/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-03-17-2135/samba.stdout
  
The top commit at the time of the failure was:

commit ad758cb869ac83534993caa212abc9fe9905ec68
Author: Amitay Isaacs 
Date:   Tue Mar 14 16:12:55 2017 +1100

ctdb-readonly: Avoid a tight loop waiting for revoke to complete

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12697

During revoking readonly delegations, if one of the nodes disappears, then
there is no point re-trying revoking readonly delegation.  The database
needs to be recovered before the revoke operation can succeed.  So retry
only after a grace period.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Fri Mar 17 14:05:57 CET 2017 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

[Martin Schwenke]

The branch, master has been updated
   via  ad758cb ctdb-readonly: Avoid a tight loop waiting for revoke to 
complete
  from  da5e256 winbindd: remove trailing spaces in get_cache()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit ad758cb869ac83534993caa212abc9fe9905ec68
Author: Amitay Isaacs 
Date:   Tue Mar 14 16:12:55 2017 +1100

ctdb-readonly: Avoid a tight loop waiting for revoke to complete

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12697

During revoking readonly delegations, if one of the nodes disappears, then
there is no point re-trying revoking readonly delegation.  The database
needs to be recovered before the revoke operation can succeed.  So retry
only after a grace period.

Signed-off-by: Amitay Isaacs 
Reviewed-by: Martin Schwenke 

Autobuild-User(master): Martin Schwenke 
Autobuild-Date(master): Fri Mar 17 14:05:57 CET 2017 on sn-devel-144

---

Summary of changes:
 ctdb/server/ctdb_call.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/server/ctdb_call.c b/ctdb/server/ctdb_call.c
index a05ec1a..8ce3928 100644
--- a/ctdb/server/ctdb_call.c
+++ b/ctdb/server/ctdb_call.c
@@ -1600,7 +1600,6 @@ static int deferred_call_destructor(struct 
revokechild_deferred_call *deferred_c
 {
struct ctdb_context *ctdb = deferred_call->ctdb;
struct revokechild_requeue_handle *requeue_handle = talloc(ctdb, struct 
revokechild_requeue_handle);
-   struct ctdb_req_call_old *c = (struct ctdb_req_call_old 
*)deferred_call->hdr;
 
requeue_handle->ctdb = ctdb;
requeue_handle->hdr  = deferred_call->hdr;
@@ -1608,9 +1607,12 @@ static int deferred_call_destructor(struct 
revokechild_deferred_call *deferred_c
requeue_handle->ctx  = deferred_call->ctx;
talloc_steal(requeue_handle, requeue_handle->hdr);
 
-   /* when revoking, any READONLY requests have 1 second grace to let 
read/write finish first */
+   /* Always delay revoke requests.  Either wait for the read/write
+* operation to complete, or if revoking failed wait for recovery to
+* complete
+*/
tevent_add_timer(ctdb->ev, requeue_handle,
-timeval_current_ofs(c->flags & CTDB_WANT_READONLY ? 1 
: 0, 0),
+timeval_current_ofs(1, 0),
 deferred_call_requeue, requeue_handle);
 
return 0;


-- 
Samba Shared Repository

[SCM] Socket Wrapper Repository - branch master updated

[Andreas Schneider]

The branch, master has been updated
   via  7ca7d61 tests: Fix test_close_failure test case
  from  6e1a3b5 swrap: use proper blocks for early returns

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit 7ca7d61c07d9dc884f06d2c77879694deac77b90
Author: Michael Adam 
Date:   Thu Mar 16 11:18:28 2017 +

tests: Fix test_close_failure test case

Found by valgrind.

Signed-off-by: Michael Adam 
Reviewed-by: Andreas Schneider 

---

Summary of changes:
 tests/test_close_failure.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/tests/test_close_failure.c b/tests/test_close_failure.c
index 0c9d6a7..8a6d40e 100644
--- a/tests/test_close_failure.c
+++ b/tests/test_close_failure.c
@@ -23,14 +23,12 @@ static int teardown(void **state)
 static void test_close_failure(void **state)
 {
int s;
-   int rc;
 
(void) state; /* unused */
-   (void) s; /*set but not used */
 
s = socket(AF_INET, SOCK_STREAM, IPPROTO_TCP);
 
-   assert_int_not_equal(rc, -1);
+   assert_int_not_equal(s, -1);
 
/* Do not close the socket here so that destructor
 * handles it and no hang should be observed.*/


-- 
Socket Wrapper Repository