autobuild[sn-devel-144]: intermittent test failure detected

2017-10-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-14-0605/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-14-0605/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-14-0605/samba.stdout
  
The top commit at the time of the failure was:

commit 5f52a0fbe8c9f52c6fed206fd5cd47bd0de867a1
Author: Ralph Boehme 
Date:   Wed Oct 11 16:04:58 2017 +0200

s4/torture: vfs_fruit: test xattr unpacking

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Fri Oct 13 21:44:02 CEST 2017 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2017-10-13 Thread Ralph Böhme 
The branch, master has been updated
   via  7abf0ac selftest: prevent interpretation of escape sequences in 
test_give_owner.sh
  from  5f52a0f s4/torture: vfs_fruit: test xattr unpacking

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 7abf0acef48cb585fa8e5666fd4c27692b9c8ae3
Author: Ralph Boehme 
Date:   Fri Oct 13 14:32:58 2017 +0200

selftest: prevent interpretation of escape sequences in test_give_owner.sh

Bug: https://bugzilla.samba.org/show_bug.cgi?id=7933

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Sat Oct 14 06:02:50 CEST 2017 on sn-devel-144

---

Summary of changes:
 source3/script/tests/test_give_owner.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/script/tests/test_give_owner.sh 
b/source3/script/tests/test_give_owner.sh
index c8f437e..7ee3734 100755
--- a/source3/script/tests/test_give_owner.sh
+++ b/source3/script/tests/test_give_owner.sh
@@ -72,7 +72,7 @@ add_ace() {
 local fname=$2
 local ace=$3
 
-local_ace=$(echo $ace | sed 's|\\|/|')
+local_ace=$(printf '%s' "$ace" | sed 's|\\|/|')
 
 # avoid duplicate
 out=$($SMBCACLS //$SERVER/$share $fname -U $USERNAME%$PASSWORD)


-- 
Samba Shared Repository

autobuild[sn-devel-144]: intermittent test failure detected

2017-10-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-14-0038/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-14-0038/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-14-0038/samba.stdout
  
The top commit at the time of the failure was:

commit 5f52a0fbe8c9f52c6fed206fd5cd47bd0de867a1
Author: Ralph Boehme 
Date:   Wed Oct 11 16:04:58 2017 +0200

s4/torture: vfs_fruit: test xattr unpacking

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Fri Oct 13 21:44:02 CEST 2017 on sn-devel-144

[SCM] Samba Shared Repository - branch master updated

2017-10-13 Thread Ralph Böhme 
The branch, master has been updated
   via  5f52a0f s4/torture: vfs_fruit: test xattr unpacking
   via  c5b25d4 s4/torture: vfs_fruit: replace AppleDouble data blob with 
xattr data
   via  d706832 vfs_fruit: on-access conversion of AppleDouble xattr data
   via  ce516a3 vfs_fruit: static string fruit_catia_maps
   via  386249e vfs_fruit: pass smb_fname to ad_convert
   via  fb137d6 vfs_fruit: unpack AppleDouble xattr header if present
   via  ab8d019 vfs_fruit: allocate ad_data buffer up to 
AD_XATTR_MAX_HDR_SIZE bytes
   via  b5a664e vfs_fruit: add AppleDouble xattr structure definitions
   via  3d7932a vfs_fruit: fix ftruncating resource fork
   via  f8bd63e vfs_catia: factor out mapping functions
  from  156015a selftest: add some debugging to test_give_owner.sh

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 5f52a0fbe8c9f52c6fed206fd5cd47bd0de867a1
Author: Ralph Boehme 
Date:   Wed Oct 11 16:04:58 2017 +0200

s4/torture: vfs_fruit: test xattr unpacking

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

Autobuild-User(master): Ralph Böhme 
Autobuild-Date(master): Fri Oct 13 21:44:02 CEST 2017 on sn-devel-144

commit c5b25d40e1ab3906805538abdb8f07a934c629f7
Author: Ralph Boehme 
Date:   Mon Oct 9 16:18:18 2017 +0200

s4/torture: vfs_fruit: replace AppleDouble data blob with xattr data

The osx_adouble_w_xattr datablob is used to test conversion from sidecar
._ file metdata to Samba compatible ._ file.

The previous data blob didn't contain xattr data, the new one does.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit d7068324407a9a0b94d992b539631246e97c9098
Author: Ralph Boehme 
Date:   Wed Oct 11 12:58:59 2017 +0200

vfs_fruit: on-access conversion of AppleDouble xattr data

This finally adds on-access conversion of xattr data stored in sidecar
AppleDouble files.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit ce516a34972f51eda48c1536858d47dc230ea99a
Author: Ralph Boehme 
Date:   Tue Oct 10 19:13:36 2017 +0200

vfs_fruit: static string fruit_catia_maps

In a later commit these will be used somewhere else too.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit 386249eea3a13303744dbab88480e80790138329
Author: Ralph Boehme 
Date:   Tue Oct 10 16:15:49 2017 +0200

vfs_fruit: pass smb_fname to ad_convert

This will be needed in a later commit when converting xattrs in sidecar
AppleDouble files.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit fb137d6070c8cd872a66a4628b0e392cf40c180e
Author: Ralph Boehme 
Date:   Tue Oct 10 16:06:33 2017 +0200

vfs_fruit: unpack AppleDouble xattr header if present

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit ab8d01959b906d0b2873357f836bff72d209ff98
Author: Ralph Boehme 
Date:   Tue Oct 10 16:04:29 2017 +0200

vfs_fruit: allocate ad_data buffer up to AD_XATTR_MAX_HDR_SIZE bytes

This is in preperation of reading potential xattr header data from the
AppleDouble file, not just reading a fixed amount of bytes.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit b5a664e2580d8823f4f2d3e7e516b576317eb290
Author: Ralph Boehme 
Date:   Tue Oct 10 16:03:13 2017 +0200

vfs_fruit: add AppleDouble xattr structure definitions

Reference:
https://opensource.apple.com/source/xnu/xnu-4570.1.46/bsd/vfs/vfs_xattr.c

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13076

Signed-off-by: Ralph Boehme 
Reviewed-by: Volker Lendecke 

commit 3d7932a33263514785fa3e95e2d5502bc02b4ea4
Author: Ralph Boehme 
Date:   Wed Oct 11 18:11:12 2017 +0200

vfs_fruit: fix ftruncating resource fork

fruit_ftruncate_rsrc_adouble() is called to effectively ftruncate() the
._ AppleDouble file to the requested size.

The VFS function SMB_VFS_NEXT_FTRUNCATE() otoh would attempt to

autobuild[sn-devel-144]: intermittent test failure detected

2017-10-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1809/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1809/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1809/samba.stdout
  
The top commit at the time of the failure was:

commit 156015aed0b5a72b2f7150beb5cdaffa32b554e5
Author: Ralph Boehme 
Date:   Thu Oct 12 17:07:15 2017 +0200

selftest: add some debugging to test_give_owner.sh

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Oct 13 01:22:05 CEST 2017 on sn-devel-144

autobuild[sn-devel-144]: intermittent test failure detected

2017-10-13 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1240/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1240/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1240/samba.stdout
  
The top commit at the time of the failure was:

commit 156015aed0b5a72b2f7150beb5cdaffa32b554e5
Author: Ralph Boehme 
Date:   Thu Oct 12 17:07:15 2017 +0200

selftest: add some debugging to test_give_owner.sh

Signed-off-by: Ralph Boehme 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Fri Oct 13 01:22:05 CEST 2017 on sn-devel-144

[SCM] NSS Wrapper Repository - branch master updated

2017-10-13 Thread Andreas Schneider 
The branch, master has been updated
   via  4298e3f nwrap: Fix strotoul checks for NSS_WRAPPER_MAX_HOSTENTS
  from  7523b05 testsuite: Add compatibility for musl-libc 1.1

https://git.samba.org/?p=nss_wrapper.git;a=shortlog;h=master


- Log -
commit 4298e3f08fed7be612155ef7e03998c1aaf9a2ac
Author: Douglas Bagnall 
Date:   Wed Aug 16 10:35:28 2017 +1200

nwrap: Fix strotoul checks for NSS_WRAPPER_MAX_HOSTENTS

The env and endptr pointers need to be dereferenced, but that is not
enough: we don't really want to regard an empty string (*env == '\0')
as a valid number.

Found by GCC 8.0.0 20170705 (experimental).

[2095/4103] Compiling lib/nss_wrapper/nss_wrapper.c
../lib/nss_wrapper/nss_wrapper.c: In function ‘nwrap_init’:
../lib/nss_wrapper/nss_wrapper.c:1571:13: warning: comparison between 
pointer and zero character constant [-Wpointer-compare]
   if (((env != '\0') && (endptr == '\0')) ||
^~
../lib/nss_wrapper/nss_wrapper.c:1571:9: note: did you mean 
to dereference the pointer?
   if (((env != '\0') && (endptr == '\0')) ||
^
../lib/nss_wrapper/nss_wrapper.c:1571:33: warning: comparison 
between pointer and zero character constant [-Wpointer-compare]
   if (((env != '\0') && (endptr == '\0')) ||
^~

../lib/nss_wrapper/nss_wrapper.c:1571:26: note: did you mean to dereference the 
pointer?
   if (((env != '\0') && (endptr == '\0')) ||

Signed-off-by: Douglas Bagnall 
Reviewed-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

---

Summary of changes:
 src/nss_wrapper.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/src/nss_wrapper.c b/src/nss_wrapper.c
index 70a5989..835bc87 100644
--- a/src/nss_wrapper.c
+++ b/src/nss_wrapper.c
@@ -1576,8 +1576,9 @@ static void nwrap_init(void)
 
env = getenv("NSS_WRAPPER_MAX_HOSTENTS");
if (env != NULL) {
-   max_hostents_tmp = (size_t)strtol(env, , 10);
-   if (((env != '\0') && (endptr == '\0')) ||
+   max_hostents_tmp = (size_t)strtoul(env, , 10);
+   if ((*env == '\0') ||
+   (*endptr != '\0') ||
(max_hostents_tmp == 0)) {
NWRAP_LOG(NWRAP_LOG_DEBUG,
  "Error parsing NSS_WRAPPER_MAX_HOSTENTS "


-- 
NSS Wrapper Repository

[SCM] Socket Wrapper Repository - branch master updated

2017-10-13 Thread Andreas Schneider 
The branch, master has been updated
   via  230a8a0 Bump version to 1.1.8
  from  c777417 swrap: Fix prototype of open[64] to prevent segfault on 
ppc64le

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit 230a8a002b2017e76f5acb3c19ad919914e5d9fc
Author: Andreas Schneider 
Date:   Thu Oct 12 16:47:49 2017 +0200

Bump version to 1.1.8

Signed-off-by: Andreas Schneider 
Reviewed-by: Ralph Boehme 

---

Summary of changes:
 CMakeLists.txt |  4 ++--
 ChangeLog  | 10 ++
 2 files changed, 12 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4d7c12e..f332cac 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -8,7 +8,7 @@ set(APPLICATION_NAME ${PROJECT_NAME})
 
 set(APPLICATION_VERSION_MAJOR "1")
 set(APPLICATION_VERSION_MINOR "1")
-set(APPLICATION_VERSION_PATCH "7")
+set(APPLICATION_VERSION_PATCH "8")
 
 set(APPLICATION_VERSION 
"${APPLICATION_VERSION_MAJOR}.${APPLICATION_VERSION_MINOR}.${APPLICATION_VERSION_PATCH}")
 
@@ -19,7 +19,7 @@ set(APPLICATION_VERSION 
"${APPLICATION_VERSION_MAJOR}.${APPLICATION_VERSION_MINO
 # Increment AGE. Set REVISION to 0
 #   If the source code was changed, but there were no interface changes:
 # Increment REVISION.
-set(LIBRARY_VERSION "0.1.7")
+set(LIBRARY_VERSION "0.1.8")
 set(LIBRARY_SOVERSION "0")
 
 # where to look first for cmake modules, before ${CMAKE_ROOT}/Modules/ is 
checked
diff --git a/ChangeLog b/ChangeLog
index dd03665..cfbcbe7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,16 @@
 ChangeLog
 ==
 
+version 1.1.8 (released 2017-10-13)
+  * Added support for openat()
+  * Added support for open64() and fopen64()
+  * Always enabled logging support
+  * Increased maximum for wrapped interfaces to 64
+  * Improved fd duplication code
+  * Fixed strict-aliasing issues
+  * Fixed some use after free issues
+  * Fixed issues on ppc64le
+
 version 1.1.7 (released 2016-05-20)
   * Added support for accept4()
   * Added support for OpenBSD


-- 
Socket Wrapper Repository

[SCM] Socket Wrapper Repository - annotated tag socket_wrapper-1.1.8 created

2017-10-13 Thread Andreas Schneider 
The annotated tag, socket_wrapper-1.1.8 has been created
at  58f7d55a8d5e6e23b38cfe663daa244576364d77 (tag)
   tagging  230a8a002b2017e76f5acb3c19ad919914e5d9fc (commit)
  replaces  socket_wrapper-1.1.7
 tagged by  Andreas Schneider
on  Fri Oct 13 10:49:00 2017 +0200

- Log -
socket_wrapper-1.1.8
-BEGIN PGP SIGNATURE-

iQIzBAABCAAdFiEEjf9T4Y8qvI2PPJIjfuD8TcwBTj0FAlngfgUACgkQfuD8TcwB
Tj0iww//eB+DQmFiXuZ2VqZcC6FHq4h2u7No7ZD2YissGde3ixO6GOhJ9zRfY+C3
WQ58rgPuEVhYtmWJK7PA9jAn11yRccUpyeH8hDe57swfwxtlF/Ovide7To05LBFV
RJ2g31OZY6cuiyQjVd+EQ209Sbmtn71/BPBrUrHl6VQErYSt3nKNa/0TZ1inBkfI
4KzKokCRMl7TRCZM1QJB8sJ9Z05Jt7B81mjUfCr8doQoMbH6poKajI6BzZh64fwp
0Oc1Uogm7qyKRmkgAsBQAsQADE7C4IYu/ahvfWJ3/kJU01oeXkreemUFPg2hJFhi
ixlxtCWHRHxDM0MNyltKBJCm2toYXxaaSMYjUiFUcD+GeYtXxegf5hcY9ogMnO+g
EOPKqCShi0b7p5R6ad9truqwipbCOp2U7ojv51fPJOq1jw1wEuGYJhySCGDGf6ab
yruLRN8Rd1p2fo9zr+z2XcKdm0eMS4QtnyM7MO5uOszE71yReGshVJRggWPAgmz6
LpMH1kzQFxlhjQmelAcNTGd2DzesTGNoYfsQViwkc/ddmNvE00KW4EAtvGKV1h6t
F3jEuZi2RmgwMvvPLgS1stm6pYbYKvrQ4cHA02xW1hqBo7XXXF53jHP1s+ddUC0Z
UOoPoBfpXe1DS1DSw6azY1XYrxXfFW4/ub6a11oyw7C4dWPfKfg=
=AjXO
-END PGP SIGNATURE-

Andreas Schneider (26):
  swrap: Fix strict-aliasing issues while loading symbols
  swrap: Make symbol loading thread-safe
  cmake: Check for constructor attribute
  swrap: Handle threads that fork
  swrap: Fix the build on BSD and Solaris
  swrap: Mark flags in swrap_accept4 as unused
  swrap: Fix build on Solaris
  swrap: Add sanity check in socket_wrapper_max_sockets()
  swrap: Add support for openat()
  swrap: Increase max wrapped interfaces
  cmake: Do not check for LFS support
  cmake: Check for open64() function
  swrap: Add open64() on systems which provide it
  cmake: Check for fopen64() function
  swrap: Add fopen64() on systems which provide it
  cmake: Replace deprecated get_target_property()
  swrap: Protect the FALL_THROUGH define
  swrap: Always enable logging
  swrap: Do an early return if log level doesn't match
  swrap: Simplify printing different log prefixes
  tests: Add a simple fnctl() test
  swrap: Improve argument handling for libc_fcntl()
  swrap: Improve argument handling for libc_vioctl()
  swrap: Improve argument handling for libc_vopen*()
  swrap: Fix prototype of open[64] to prevent segfault on ppc64le
  Bump version to 1.1.8

Anoop C S (16):
  swrap: Simplify swrap_remove_stale by early return
  swrap: Remove redunant check in swrap_socket
  swrap: Delay addition of child socket_info_fd into socket_info list
  swrap: Add test case to validate oldfd = newfd case in dup2()
  swrap: Untangle socket_info_fd from socket_info structure.
  swrap: Replace linked list of socket_info with preallocated array of 
structures
  swrap: fix SWRAP_DLIST_ADD_AFTER
  swrap: Fix use-after-free
  tests: Clean-up max_sockets test case
  Avoid mutex lock wait in socket close failure
  Increase wait time during echo_server's pid-file check
  swrap: Suppress intentional fall through warning
  swrap: Add common exit point to swrap_auto_bind
  swrap: Add common exit point to swrap_connect
  swrap: Add common exit point to swrap_getsockopt
  swrap: Add common exit point to swrap_setsockopt

Michael Adam (16):
  swrap: Treat the case of fd == newfd correctly in dup2()
  swrap: remove ununsed members from struct swrap.
  swrap: Add SWRAP_DLIST_ADD_AFTER macro
  swrap: Improve dup to add the dup'd fd after the source fd
  swrap: Improve dup2 to add the dup'd fd after the source fd
  swrap: Improve vfcntl to add the dup'd fd after the source fd
  swrap: Optimization in (commented out) check_addr_port_in_use()
  swrap: Introduce a freelist in the socket_info array
  tests: Add a test for max_sockets
  cmake: Link pthread library headers
  swrap: fix use-after-free in swrap_close
  swrap: slightly cleanup logic in swrap_close
  swrap: fix use-after-free in swrap_remove_stale()
  swrap: use proper blocks for early returns
  tests: Fix test_close_failure test case
  swrap: Fix tab vs space in swrap_auto_bind

---


-- 
Socket Wrapper Repository