[SCM] Samba Shared Repository - branch master updated

2018-02-20 Thread Andrew Bartlett 
The branch, master has been updated
   via  0b63f26 selftest: change technique for running specific envs
   via  962e8a0 selftest: move to declaratively specifying environments and 
their dependencies
   via  41085ad selftest: remove prototypes from some subroutine templates
  from  6f9c6d3 s3:auth: Pass mem_ctx to init_system_session_info()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 0b63f26bf72e5f5ce5ab6d052bc899375818a235
Author: Jamie McClymont 
Date:   Thu Feb 1 17:46:37 2018 +1300

selftest: change technique for running specific envs

Currently testsuites excluded with --exclude/--include-env are skipped when
encountered in the middle of a run, so they are included in progress 
reporting,
and the @todo list does not accurately show what will be done.

This change skips them earlier, preventing them from being added to @todo, 
as is
done with pattern-based including/excluding.

As well as making the progress indicator more accurate, this means that
selftest.pl can use @todo to determine when we are finished with an 
environment.

Signed-off-by: Jamie McClymont 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Wed Feb 21 07:47:58 CET 2018 on sn-devel-144

commit 962e8a0ea7db79b96dddec06a4bde211eea0d1d6
Author: Jamie McClymont 
Date:   Wed Feb 21 13:33:49 2018 +1300

selftest: move to declaratively specifying environments and their 
dependencies

This removes the tangle of code for starting up dependencies, and allows
selftest.pl to query dependencies (hence it can know when things can be shut
down early and how to order environments for optimal memory usage - that 
patch
not yet submitted).

It also removes the slightly hacky special-casing of the ad_members, and 
sets
$target->{vars} centrally (so each setup_ function does not need to).

Signed-off-by: Jamie McClymont 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

commit 41085ad37de56504467a0014b70f6a708dcde91b
Author: Jamie McClymont 
Date:   Thu Feb 8 16:51:23 2018 +1300

selftest: remove prototypes from some subroutine templates

Rationale, as sent to samba-technical:

  > Why do you remove the explicit argument declarations for so many 
functions?
  > These declarations help catch usage errors, i.e. wrong number of calling
  > arguments, especially when you add arguments to functions.

  My understanding is that because these are object methods, the prototypes
  actually were not providing the checking benefits [see PERLSUB(1) (section
  "Prototypes")] -- this is evidenced by the fact that some of the 
prototypes I
  removed actually had the wrong number of arguments!

  Now that the subroutines are being dynamically called by function 
references,
  the checking also appears not to apply [see the same source].

  There was also a more concrete reason: the setup code will automatically 
set
  up multiple environment dependencies and pass each of their vars as an
  individual parameter. Accomplishing this was [seemingly] impossible with 
the
  prototypes in place.

  Additionally, there seems to be a consensus among perl devs that 
prototypes
  are generally harmful: see this post (by my colleague) for example:
  http://www.perlmonks.org/?node_id=406231

Signed-off-by: Jamie McClymont 
Reviewed-by: Douglas Bagnall 
Reviewed-by: Andrew Bartlett 

---

Summary of changes:
 selftest/selftest.pl  |  50 
 selftest/target/Samba.pm  |  72 
 selftest/target/Samba3.pm | 105 
 selftest/target/Samba4.pm | 203 +-
 4 files changed, 159 insertions(+), 271 deletions(-)


Changeset truncated at 500 lines:

diff --git a/selftest/selftest.pl b/selftest/selftest.pl
index 0e56e6a..fad0191 100755
--- a/selftest/selftest.pl
+++ b/selftest/selftest.pl
@@ -83,9 +83,20 @@ sub find_in_list($$)
return undef;
 }
 
-sub skip($)
+sub skip
 {
-   my ($name) = @_;
+   my ($name, $envname) = @_;
+   my ($env_basename, $env_localpart) = split(/:/, $envname);
+
+   if ($opt_target eq "samba3" && $Samba::ENV_NEEDS_AD_DC{$env_basename}) {
+   return "environment $envname is disabled as this

[SCM] Samba Shared Repository - branch master updated

2018-02-20 Thread Jeremy Allison 
The branch, master has been updated
   via  6f9c6d3 s3:auth: Pass mem_ctx to init_system_session_info()
   via  7f47cec s3:auth: Pass mem_ctx to init_guest_session_info()
   via  b2aec11 s3:auth: Pass a mem_ctx to make_new_session_info_guest()
   via  9abe972 tldap: Dump unnecessary includes
  from  a6eac8f smbspool: Improve URI handling code

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit 6f9c6d369f4aa4a5c861f51041dd663e81e2ec4e
Author: Andreas Schneider 
Date:   Tue Feb 13 12:12:06 2018 +0100

s3:auth: Pass mem_ctx to init_system_session_info()

We have a stackframe we can use for the lifetime of the session.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

Autobuild-User(master): Jeremy Allison 
Autobuild-Date(master): Wed Feb 21 02:46:40 CET 2018 on sn-devel-144

commit 7f47cec2343ca7658460cc14fa613fdd2611677a
Author: Andreas Schneider 
Date:   Tue Feb 13 12:09:12 2018 +0100

s3:auth: Pass mem_ctx to init_guest_session_info()

Use a mem_ctx which gets freed if possible.

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

commit b2aec11c76904bf6a8f67f0634cce5e443e77d8b
Author: Andreas Schneider 
Date:   Tue Feb 13 12:05:29 2018 +0100

s3:auth: Pass a mem_ctx to make_new_session_info_guest()

Signed-off-by: Andreas Schneider 
Reviewed-by: Jeremy Allison 

commit 9abe97285b7e1de25bf1c1f4fde8fd481a31a6bb
Author: Volker Lendecke 
Date:   Thu Feb 15 12:30:23 2018 +0100

tldap: Dump unnecessary includes

Signed-off-by: Volker Lendecke 
Reviewed-by: Jeremy Allison 

---

Summary of changes:
 source3/auth/auth_util.c| 36 +++-
 source3/auth/proto.h|  4 ++--
 source3/lib/tldap_util.c|  2 --
 source3/smbd/server.c   |  4 ++--
 source3/torture/vfstest.c   |  2 +-
 source3/winbindd/winbindd.c |  2 +-
 6 files changed, 29 insertions(+), 21 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/auth/auth_util.c b/source3/auth/auth_util.c
index f543b33..4b20261 100644
--- a/source3/auth/auth_util.c
+++ b/source3/auth/auth_util.c
@@ -798,8 +798,12 @@ static NTSTATUS get_guest_info3(TALLOC_CTX *mem_ctx,
  left as-is for now.
 ***/
 
-static NTSTATUS make_new_session_info_guest(struct auth_session_info 
**session_info, struct auth_serversupplied_info **server_info)
+static NTSTATUS make_new_session_info_guest(TALLOC_CTX *mem_ctx,
+   struct auth_session_info **_session_info,
+   struct auth_serversupplied_info **_server_info)
 {
+   struct auth_session_info *session_info = NULL;
+   struct auth_serversupplied_info *server_info = NULL;
const char *guest_account = lp_guest_account();
const char *domain = lp_netbios_name();
struct netr_SamInfo3 info3;
@@ -823,7 +827,7 @@ static NTSTATUS make_new_session_info_guest(struct 
auth_session_info **session_i
status = make_server_info_info3(tmp_ctx,
guest_account,
domain,
-   server_info,
+   _info,
);
if (!NT_STATUS_IS_OK(status)) {
DEBUG(0, ("make_server_info_info3 failed with %s\n",
@@ -831,25 +835,26 @@ static NTSTATUS make_new_session_info_guest(struct 
auth_session_info **session_i
goto done;
}
 
-   (*server_info)->guest = true;
+   server_info->guest = true;
 
/* This should not be done here (we should produce a server
 * info, and later construct a session info from it), but for
 * now this does not change the previous behavior */
-   status = create_local_token(tmp_ctx, *server_info, NULL,
-   
(*server_info)->info3->base.account_name.string,
-   session_info);
+   status = create_local_token(tmp_ctx, server_info, NULL,
+   
server_info->info3->base.account_name.string,
+   _info);
if (!NT_STATUS_IS_OK(status)) {
DEBUG(0, ("create_local_token failed: %s\n",
  nt_errstr(status)));
goto done;
}
-   talloc_steal(NULL, *session_info);
-   talloc_steal(NULL, *server_info);
 
/* annoying, but the Guest really does have a session key, and it is
   all zeros! */
-

[SCM] Samba Shared Repository - branch master updated

2018-02-20 Thread Andreas Schneider 
The branch, master has been updated
   via  a6eac8f smbspool: Improve URI handling code
  from  7573b2a tests: Add tests for parsing LDAPv3 and LDAPv2 filter 
strings

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -
commit a6eac8f64989235e7a297c14e349d98a3fc70e47
Author: Andreas Schneider 
Date:   Fri Jan 5 10:50:57 2018 +0100

smbspool: Improve URI handling code

This also checks that the URI given via the environment variables
starts with smb://

Signed-off-by: Andreas Schneider 
Reviewed-by: Alexander Bokovoy 
Reviewed-by: David Disseldorp 

Autobuild-User(master): Andreas Schneider 
Autobuild-Date(master): Tue Feb 20 21:46:38 CET 2018 on sn-devel-144

---

Summary of changes:
 source3/client/smbspool.c | 29 ++---
 1 file changed, 18 insertions(+), 11 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/client/smbspool.c b/source3/client/smbspool.c
index 949cdb4..152492e 100644
--- a/source3/client/smbspool.c
+++ b/source3/client/smbspool.c
@@ -100,6 +100,8 @@ main(int argc,  /* I - Number of 
command-line arguments */
const char *dev_uri;
const char *config_file = NULL;
TALLOC_CTX *frame = talloc_stackframe();
+   int cmp;
+   int len;
 
if (argc == 1) {
/*
@@ -153,20 +155,25 @@ main(int argc,/* I - Number of 
command-line arguments */
}
 
/*
- * Find the URI...
- */
-
+* Find the URI ...
+*/
dev_uri = getenv("DEVICE_URI");
-   if (dev_uri) {
-   strncpy(uri, dev_uri, sizeof(uri) - 1);
-   } else if (strncmp(argv[1], "smb://", 6) == 0) {
-   strncpy(uri, argv[1], sizeof(uri) - 1);
-   } else {
-   fputs("ERROR: No device URI found in DEVICE_URI environment 
variable or arg1 !\n", stderr);
-   goto done;
+   if (dev_uri == NULL || strlen(dev_uri) == 0) {
+   dev_uri = argv[1];
}
 
-   uri[sizeof(uri) - 1] = '\0';
+   cmp = strncmp(dev_uri, "smb://", 6);
+   if (cmp != 0) {
+   fprintf(stderr,
+   "ERROR: No valid device URI has been specified\n");
+   goto done;
+   }
+   len = snprintf(uri, sizeof(uri), "%s", dev_uri);
+   if (len >= sizeof(uri)) {
+   fprintf(stderr,
+   "ERROR: The URI is too long.\n");
+   goto done;
+   }
 
/*
  * Extract the destination from the URI...


-- 
Samba Shared Repository

autobuild[sn-devel-144]: intermittent test failure detected

2018-02-20 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-20-2023/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-20-2023/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-20-2023/samba.stdout
  
The top commit at the time of the failure was:

commit 7573b2a960c5bd32ac6d42b10bb46329ff7fa7b7
Author: Andreas Schneider 
Date:   Mon Feb 19 12:08:26 2018 +0100

tests: Add tests for parsing LDAPv3 and LDAPv2 filter strings

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Feb 19 23:47:08 CET 2018 on sn-devel-144

[SCM] Socket Wrapper Repository - branch master updated

2018-02-20 Thread Andreas Schneider 
The branch, master has been updated
   via  986684f swrap: Avoid double semicolons in the code
  from  9a23836 Bump version to 1.1.9

https://git.samba.org/?p=socket_wrapper.git;a=shortlog;h=master


- Log -
commit 986684ffa03f15f270c4deec2068ac3d2a450dea
Author: Andreas Schneider 
Date:   Tue Feb 20 17:52:00 2018 +0100

swrap: Avoid double semicolons in the code

Compilers that don't support fallthrough will end up with an empty
FALL_THROUGH define and just see a semicolon. The probably will warn
that there are double semicolons in the code.

Signed-off-by: Andreas Schneider 

---

Summary of changes:
 src/socket_wrapper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/src/socket_wrapper.c b/src/socket_wrapper.c
index 539d27d..02fe970 100644
--- a/src/socket_wrapper.c
+++ b/src/socket_wrapper.c
@@ -111,7 +111,7 @@ enum swrap_dbglvl_e {
 # ifdef HAVE_FALLTHROUGH_ATTRIBUTE
 #  define FALL_THROUGH __attribute__ ((fallthrough))
 # else /* HAVE_FALLTHROUGH_ATTRIBUTE */
-#  define FALL_THROUGH
+#  define FALL_THROUGH ((void)0)
 # endif /* HAVE_FALLTHROUGH_ATTRIBUTE */
 #endif /* FALL_THROUGH */
 


-- 
Socket Wrapper Repository

[SCM] Samba Shared Repository - branch v4-8-test updated

2018-02-20 Thread Karolin Seeger 
The branch, v4-8-test has been updated
   via  a46dc61 subnet: Avoid a segfault when renaming subnet objects
  from  f093cdd ctdb-tests: Set test timeout to an hour

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-8-test


- Log -
commit a46dc61351121b625a715463dcd9f9b372f45d0f
Author: Garming Sam 
Date:   Wed Sep 20 14:55:11 2017 +1200

subnet: Avoid a segfault when renaming subnet objects

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13031

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall 

Autobuild-User(v4-8-test): Karolin Seeger 
Autobuild-Date(v4-8-test): Tue Feb 20 17:54:43 CET 2018 on sn-devel-144

---

Summary of changes:
 python/samba/subnets.py | 33 
 source4/dsdb/samdb/ldb_modules/samldb.c |  8 +++---
 source4/dsdb/tests/python/sites.py  | 45 +
 3 files changed, 82 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/python/samba/subnets.py b/python/samba/subnets.py
index e859f06..72eeb0f 100644
--- a/python/samba/subnets.py
+++ b/python/samba/subnets.py
@@ -127,6 +127,39 @@ def delete_subnet(samdb, configDn, subnet_name):
 
 samdb.delete(dnsubnet)
 
+def rename_subnet(samdb, configDn, subnet_name, new_name):
+"""Rename a subnet.
+
+:param samdb: A samdb connection
+:param configDn: The DN of the configuration partition
+:param subnet_name: Name of the subnet to rename
+:param new_name: New name for the subnet
+:return: None
+:raise SubnetNotFound: if the subnet to be renamed does not exist.
+:raise SubnetExists: if the subnet to be created already exists.
+"""
+dnsubnet = ldb.Dn(samdb, "CN=Subnets,CN=Sites")
+if dnsubnet.add_base(configDn) == False:
+raise SubnetException("dnsubnet.add_base() failed")
+if dnsubnet.add_child("CN=X") == False:
+raise SubnetException("dnsubnet.add_child() failed")
+dnsubnet.set_component(0, "CN", subnet_name)
+
+newdnsubnet = ldb.Dn(samdb, str(dnsubnet))
+newdnsubnet.set_component(0, "CN", new_name)
+try:
+samdb.rename(dnsubnet, newdnsubnet)
+except LdbError as (enum, estr):
+if enum == ldb.ERR_NO_SUCH_OBJECT:
+raise SubnetNotFound('Subnet %s does not exist' % subnet)
+elif enum == ldb.ERR_ENTRY_ALREADY_EXISTS:
+raise SubnetAlreadyExists('A subnet with the CIDR %s already 
exists'
+  % new_name)
+elif enum == ldb.ERR_INVALID_DN_SYNTAX:
+raise SubnetInvalid("%s is not a valid subnet: %s" % (new_name,
+  estr))
+else:
+raise
 
 def set_subnet_site(samdb, configDn, subnet_name, site_name):
 """Assign a subnet to a site.
diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c 
b/source4/dsdb/samdb/ldb_modules/samldb.c
index 971048d..3e429e1 100644
--- a/source4/dsdb/samdb/ldb_modules/samldb.c
+++ b/source4/dsdb/samdb/ldb_modules/samldb.c
@@ -3351,13 +3351,13 @@ static int verify_cidr(const char *cidr)
 }
 
 
-static int samldb_verify_subnet(struct samldb_ctx *ac)
+static int samldb_verify_subnet(struct samldb_ctx *ac, struct ldb_dn *dn)
 {
struct ldb_context *ldb = ldb_module_get_ctx(ac->module);
const char *cidr = NULL;
const struct ldb_val *rdn_value = NULL;
 
-   rdn_value = ldb_dn_get_rdn_val(ac->msg->dn);
+   rdn_value = ldb_dn_get_rdn_val(dn);
if (rdn_value == NULL) {
ldb_set_errstring(ldb, "samldb: ldb_dn_get_rdn_val "
  "failed");
@@ -3588,7 +3588,7 @@ static int samldb_add(struct ldb_module *module, struct 
ldb_request *req)
 
if (samdb_find_attribute(ldb, ac->msg,
 "objectclass", "subnet") != NULL) {
-   ret = samldb_verify_subnet(ac);
+   ret = samldb_verify_subnet(ac, ac->msg->dn);
if (ret != LDB_SUCCESS) {
talloc_free(ac);
return ret;
@@ -3991,7 +3991,7 @@ static int check_rename_constraints(struct ldb_message 
*msg,
 
/* subnet objects */
if (samdb_find_attribute(ldb, msg, "objectclass", "subnet") != NULL) {
-   ret = samldb_verify_subnet(ac);
+   ret = samldb_verify_subnet(ac, newdn);
if (ret != LDB_SUCCESS) {
talloc_free(ac);
return ret;
diff --git a/source4/dsdb/tests/python/sites.py 
b/source4/dsdb/tests/python/sites.py
index a894da3..123e1ec 100755
--- a/source4/dsdb/tests/python/sites.py
+++ b/source4/dsdb/tests/python/sites.py
@@ -183,6 +183,51 @@ class

[SCM] Samba Shared Repository - branch v4-7-test updated

2018-02-20 Thread Karolin Seeger 
The branch, v4-7-test has been updated
   via  4978ee1 subnet: Avoid a segfault when renaming subnet objects
  from  1fa65b4 build: fix ceph_statx check when configured with 
libcephfs_dir

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-7-test


- Log -
commit 4978ee103d7474015e98bff5654d0d4f834e6dcd
Author: Garming Sam 
Date:   Wed Sep 20 14:55:11 2017 +1200

subnet: Avoid a segfault when renaming subnet objects

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13031

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall 

Autobuild-User(v4-7-test): Karolin Seeger 
Autobuild-Date(v4-7-test): Tue Feb 20 17:48:35 CET 2018 on sn-devel-144

---

Summary of changes:
 python/samba/subnets.py | 33 
 source4/dsdb/samdb/ldb_modules/samldb.c |  8 +++---
 source4/dsdb/tests/python/sites.py  | 45 +
 3 files changed, 82 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/python/samba/subnets.py b/python/samba/subnets.py
index e859f06..72eeb0f 100644
--- a/python/samba/subnets.py
+++ b/python/samba/subnets.py
@@ -127,6 +127,39 @@ def delete_subnet(samdb, configDn, subnet_name):
 
 samdb.delete(dnsubnet)
 
+def rename_subnet(samdb, configDn, subnet_name, new_name):
+"""Rename a subnet.
+
+:param samdb: A samdb connection
+:param configDn: The DN of the configuration partition
+:param subnet_name: Name of the subnet to rename
+:param new_name: New name for the subnet
+:return: None
+:raise SubnetNotFound: if the subnet to be renamed does not exist.
+:raise SubnetExists: if the subnet to be created already exists.
+"""
+dnsubnet = ldb.Dn(samdb, "CN=Subnets,CN=Sites")
+if dnsubnet.add_base(configDn) == False:
+raise SubnetException("dnsubnet.add_base() failed")
+if dnsubnet.add_child("CN=X") == False:
+raise SubnetException("dnsubnet.add_child() failed")
+dnsubnet.set_component(0, "CN", subnet_name)
+
+newdnsubnet = ldb.Dn(samdb, str(dnsubnet))
+newdnsubnet.set_component(0, "CN", new_name)
+try:
+samdb.rename(dnsubnet, newdnsubnet)
+except LdbError as (enum, estr):
+if enum == ldb.ERR_NO_SUCH_OBJECT:
+raise SubnetNotFound('Subnet %s does not exist' % subnet)
+elif enum == ldb.ERR_ENTRY_ALREADY_EXISTS:
+raise SubnetAlreadyExists('A subnet with the CIDR %s already 
exists'
+  % new_name)
+elif enum == ldb.ERR_INVALID_DN_SYNTAX:
+raise SubnetInvalid("%s is not a valid subnet: %s" % (new_name,
+  estr))
+else:
+raise
 
 def set_subnet_site(samdb, configDn, subnet_name, site_name):
 """Assign a subnet to a site.
diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c 
b/source4/dsdb/samdb/ldb_modules/samldb.c
index 971048d..3e429e1 100644
--- a/source4/dsdb/samdb/ldb_modules/samldb.c
+++ b/source4/dsdb/samdb/ldb_modules/samldb.c
@@ -3351,13 +3351,13 @@ static int verify_cidr(const char *cidr)
 }
 
 
-static int samldb_verify_subnet(struct samldb_ctx *ac)
+static int samldb_verify_subnet(struct samldb_ctx *ac, struct ldb_dn *dn)
 {
struct ldb_context *ldb = ldb_module_get_ctx(ac->module);
const char *cidr = NULL;
const struct ldb_val *rdn_value = NULL;
 
-   rdn_value = ldb_dn_get_rdn_val(ac->msg->dn);
+   rdn_value = ldb_dn_get_rdn_val(dn);
if (rdn_value == NULL) {
ldb_set_errstring(ldb, "samldb: ldb_dn_get_rdn_val "
  "failed");
@@ -3588,7 +3588,7 @@ static int samldb_add(struct ldb_module *module, struct 
ldb_request *req)
 
if (samdb_find_attribute(ldb, ac->msg,
 "objectclass", "subnet") != NULL) {
-   ret = samldb_verify_subnet(ac);
+   ret = samldb_verify_subnet(ac, ac->msg->dn);
if (ret != LDB_SUCCESS) {
talloc_free(ac);
return ret;
@@ -3991,7 +3991,7 @@ static int check_rename_constraints(struct ldb_message 
*msg,
 
/* subnet objects */
if (samdb_find_attribute(ldb, msg, "objectclass", "subnet") != NULL) {
-   ret = samldb_verify_subnet(ac);
+   ret = samldb_verify_subnet(ac, newdn);
if (ret != LDB_SUCCESS) {
talloc_free(ac);
return ret;
diff --git a/source4/dsdb/tests/python/sites.py 
b/source4/dsdb/tests/python/sites.py
index a894da3..123e1ec 100755
--- a/source4/dsdb/tests/python/sites.py
+++ b/source4/dsdb/tests/python/sites.py
@@ -183,6 +183,51 @@

[SCM] Samba Shared Repository - branch v4-6-test updated

2018-02-20 Thread Karolin Seeger 
The branch, v4-6-test has been updated
   via  56a40ab samba: Only use async signal-safe functions in signal 
handler
   via  670af37 subnet: Avoid a segfault when renaming subnet objects
   via  f2e21e6 HEIMDAL:kdc: use the correct authtime from addtitional 
ticket for S4U2Proxy tickets
   via  ffda28e TODO s4:kdc: indicate support for new encryption types by 
adding empty keys
   via  075f061 TODO s4:kdc: msDS-SupportedEncryptionTypes only on computers
   via  7d0559e s4:kdc: use the strongest possible tgs session key
   via  2a7392d HEIMDAL:hdb: export a hdb_enctype_supported() helper 
function
   via  8ac00b0 HEIMDAL:kdc: let _kdc_encode_reply() use the encryption 
type based on the server key
   via  9f3571a s4:kdc: fix the principal names in 
samba_kdc_update_delegation_info_blob
   via  312bf1c HEIMDAL:kdc: if we don't have an authenticator subkey for 
S4U2Proxy we need to use the additional tickets key
   via  3dd52dd HEIMDAL:kdc: decrypt b->enc_authorization_data in 
tgs_build_reply()
   via  9ec1a52 HEIMDAL:kdc: fix memory leak when decryption 
AuthorizationData
  from  2ed8741 VERSION: Bump version up to 4.6.14...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-6-test


- Log -
commit 56a40ab005671fd6ce3c55cd91eddcbcc925891d
Author: Volker Lendecke 
Date:   Thu Jan 4 21:06:02 2018 +0100

samba: Only use async signal-safe functions in signal handler

Otherwise shutdown can hang

Signed-off-by: Volker Lendecke 
Reviewed-by: Andreas Schneider 

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13240

Signed-off-by: Björn Baumbach 
(similar to commit 361ea743576cf125d7957a97ed78a0446dab1a19)

Autobuild-User(v4-6-test): Karolin Seeger 
Autobuild-Date(v4-6-test): Tue Feb 20 17:03:44 CET 2018 on sn-devel-144

commit 670af37291bc75481ac89efff62760d74377536f
Author: Garming Sam 
Date:   Wed Sep 20 14:55:11 2017 +1200

subnet: Avoid a segfault when renaming subnet objects

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13031

Signed-off-by: Garming Sam 
Reviewed-by: Douglas Bagnall 

commit f2e21e692640308c003bd851da0c627af73a9451
Author: Stefan Metzmacher 
Date:   Wed Nov 8 13:18:29 2017 +0100

HEIMDAL:kdc: use the correct authtime from addtitional ticket for S4U2Proxy 
tickets

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13137

Signed-off-by: Stefan Metzmacher 

commit ffda28e9b14a6d0464cc2b931105a4d43712dcba
Author: Stefan Metzmacher 
Date:   Tue Nov 7 12:23:31 2017 +0100

TODO s4:kdc: indicate support for new encryption types by adding empty keys

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13135

commit 075f061ca337d516a82b0fb19b001ff8cff61915
Author: Stefan Metzmacher 
Date:   Tue Nov 7 12:23:31 2017 +0100

TODO s4:kdc: msDS-SupportedEncryptionTypes only on computers

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13135

commit 7d0559e0eb5d533a5f5764a39d04fb05d8d34633
Author: Stefan Metzmacher 
Date:   Tue Nov 7 18:03:45 2017 +0100

s4:kdc: use the strongest possible tgs session key

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13135

Signed-off-by: Stefan Metzmacher 

commit 2a7392d3b216d4a79d81fd6a31bb2294b70c9a35
Author: Stefan Metzmacher 
Date:   Tue Nov 7 15:47:25 2017 +0100

HEIMDAL:hdb: export a hdb_enctype_supported() helper function

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13135

Signed-off-by: Stefan Metzmacher 

commit 8ac00b066c893f9da5ac44f9391e41ad018d08bc
Author: Stefan Metzmacher 
Date:   Wed Nov 8 11:57:08 2017 +0100

HEIMDAL:kdc: let _kdc_encode_reply() use the encryption type based on the 
server key

Currently the value is the same anyway as the session key is always of the
same type as server key up to now, but that will change shortly.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13135

Signed-off-by: Stefan Metzmacher 

commit 9f3571aa20a209901c6ab7c776200afeac54eca4
Author: Stefan Metzmacher 
Date:   Thu Sep 28 14:51:43 2017 +0200

s4:kdc: fix the principal names in samba_kdc_update_delegation_info_blob

We need the target service without realm, but the proxy services with realm.

I have a domain with an w2008r2 server and a samba and now both generate
the same S4U_DELEGATION_INFO.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133

Signed-off-by: Stefan Metzmacher 

commit 312bf1c331038059698d14d7026387079a49bb61
Author: Stefan

autobuild[sn-devel-144]: intermittent test failure detected

2018-02-20 Thread autobuild 
The autobuild test system (on sn-devel-144) has detected an intermittent 
failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-20-1439/flakey.log

The samba build logs are available here:

   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-20-1439/samba.stderr
   
http://git.samba.org/autobuild.flakey.sn-devel-144/2018-02-20-1439/samba.stdout
  
The top commit at the time of the failure was:

commit 7573b2a960c5bd32ac6d42b10bb46329ff7fa7b7
Author: Andreas Schneider 
Date:   Mon Feb 19 12:08:26 2018 +0100

tests: Add tests for parsing LDAPv3 and LDAPv2 filter strings

Signed-off-by: Andreas Schneider 
Reviewed-by: Andrew Bartlett 

Autobuild-User(master): Andrew Bartlett 
Autobuild-Date(master): Mon Feb 19 23:47:08 CET 2018 on sn-devel-144