[SCM] Samba Shared Repository - branch v4-10-test updated
The branch, v4-10-test has been updated via f19881f6198 fault.c: improve fault_report message text pointing to our wiki via 56379945161 selftest/Samba3.pm: use "winbind use krb5 enterprise principals = yes" for ad_member via abd2d22cdda selftest/Samba3.pm: use "winbind scan trusted domains = no" for ad_member via fd097f0b3bb selftest/tests.py: test pam_winbind with a lot of username variations via fe13bfcdfdc selftest/tests.py: test pam_winbind with krb5_auth via 9bb73edc69c selftest/tests.py: prepare looping over pam_winbindd tests via 8118fc89262 test_pam_winbind.sh: allow different pam_winbindd config options to be specified via 6bc0549bfde tests/pam_winbind.py: allow upn names to be used in USERNAME with an empty DOMAIN value via f2283616011 tests/pam_winbind.py: turn pypamtest.PamTestError into a failure via 956618ac6da s3:winbindd: implement the "winbind use krb5 enterprise principals" logic via 4760bbaae22 docs-xml: add "winbind use krb5 enterprise principals" option via aa1e8e53551 krb5_wrap: let smb_krb5_parse_name() accept enterprise principals via d7f0baf2f54 s3:libads: ads_krb5_chg_password() should always use the canonicalized principal via 73608fced20 s4:auth: kinit_to_ccache() should always use the canonicalized principal via be9ea381530 krb5_wrap: smb_krb5_kinit_password_ccache() should always use the canonicalized principal via 03477632b62 s3:libads/kerberos: always use the canonicalized principal after kinit via aeaffacb9c8 s3:libsmb: let cli_session_creds_prepare_krb5() update the canonicalized principal to cli_credentials via 45a078db792 s3:libsmb: avoid wrong debug message in cli_session_creds_prepare_krb5() via e620cad350e s3:libads: let kerberos_kinit_password_ext() return the canonicalized principal/realm via 9f2d5ae0c59 s4:auth: use the correct client realm in gensec_gssapi_update_internal() via 05eb45e1d37 s3/libads: clang: Fix Value stored to 'canon_princ' is never read from eaecffd63db classicupgrade: fix a a bytes-like object is required, not 'str' error https://git.samba.org/?p=samba.git;a=shortlog;h=v4-10-test - Log - commit f19881f6198a006a281a11ea2f2952213c213e08 Author: Björn Jacke Date: Mon Sep 23 08:57:33 2019 +0200 fault.c: improve fault_report message text pointing to our wiki BUG: https://bugzilla.samba.org/show_bug.cgi?id=14139 Signed-off-by: Bjoern Jacke Reviewed-by: Alexander Bokovoy (cherry picked from commit ec4c5975528f3d3ab9c8813e176c6d1a2f1ca506) Autobuild-User(v4-10-test): Karolin Seeger Autobuild-Date(v4-10-test): Thu Sep 26 04:49:25 UTC 2019 on sn-devel-144 commit 563799451611d0c452cd639a1c31c03474252672 Author: Stefan Metzmacher Date: Wed Sep 18 08:10:26 2019 +0200 selftest/Samba3.pm: use "winbind use krb5 enterprise principals = yes" for ad_member This demonstrates that can do krb5_auth in winbindd without knowning about trusted domains. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124 Signed-off-by: Stefan Metzmacher Reviewed-by: Guenther Deschner Autobuild-User(master): Günther Deschner Autobuild-Date(master): Tue Sep 24 19:51:29 UTC 2019 on sn-devel-184 (similar to commit 0ee085b594878f5e0e83839f465303754f015459) commit abd2d22cdda79baf89a9115c17aeae2d91695e26 Author: Stefan Metzmacher Date: Wed Sep 18 08:02:38 2019 +0200 selftest/Samba3.pm: use "winbind scan trusted domains = no" for ad_member This demonstrates that we rely on knowning about trusted domains before we can do krb5_auth in winbindd. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124 Signed-off-by: Stefan Metzmacher Reviewed-by: Guenther Deschner (similar to commit e2737a74d4453a3d65e5466ddc4405d68444df27) commit fd097f0b3bb9560a59f7d7e6ef50d113fcff6641 Author: Stefan Metzmacher Date: Wed Sep 18 14:03:34 2019 +0200 selftest/tests.py: test pam_winbind with a lot of username variations BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124 Signed-off-by: Stefan Metzmacher Reviewed-by: Guenther Deschner (cherry picked from commit f07b542c61f84a97c097208e10bf9375ddfa9a15) commit fe13bfcdfdcb3590df1da5fd592c6c2e15935d53 Author: Stefan Metzmacher Date: Wed Sep 18 08:08:57 2019 +0200 selftest/tests.py: test pam_winbind with krb5_auth BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124 Signed-off-by: Stefan Metzmacher Reviewed-by: Guenther Deschner (cherry picked from commit 36e95e42ea8a7e5a4091a647215d06d2ab47fab6) commit 9bb73edc69c1b8d58f56ce7ad0f55c3373fd5d4c Author: Stefan Metzmacher Date: Wed Sep 18 01:25:23 2019 +0200 selftest/tests.py: prepare looping over pam_winbindd tests
[SCM] Samba Shared Repository - branch v4-9-test updated
The branch, v4-9-test has been updated
via c788ff56bae fault.c: improve fault_report message text pointing to
our wiki
from 9a5bdc6c9e6 ctdb-tools: Stop deleted nodes from influencing ctdb
nodestatus exit code
https://git.samba.org/?p=samba.git;a=shortlog;h=v4-9-test
- Log -
commit c788ff56bae20dad25391698876343801b4afbf2
Author: Björn Jacke
Date: Mon Sep 23 08:57:33 2019 +0200
fault.c: improve fault_report message text pointing to our wiki
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14139
Signed-off-by: Bjoern Jacke
Reviewed-by: Alexander Bokovoy
(cherry picked from commit ec4c5975528f3d3ab9c8813e176c6d1a2f1ca506)
Autobuild-User(v4-9-test): Karolin Seeger
Autobuild-Date(v4-9-test): Thu Sep 26 04:30:04 UTC 2019 on sn-devel-144
---
Summary of changes:
lib/util/fault.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/lib/util/fault.c b/lib/util/fault.c
index 1b56361aa62..0e6c0b1f1ee 100644
--- a/lib/util/fault.c
+++ b/lib/util/fault.c
@@ -78,7 +78,11 @@ static void fault_report(int sig)
DEBUGSEP(0);
DEBUG(0,("INTERNAL ERROR: Signal %d in pid %d
(%s)",sig,(int)getpid(),SAMBA_VERSION_STRING));
- DEBUG(0,("\nPlease read the Trouble-Shooting section of the Samba
HOWTO\n"));
+ DEBUG(0,("\nIf you are running a recent Samba version, and "
+"if you think this problem is not yet fixed in the "
+"latest versions, please consider reporting this "
+"bug, see "
+"https://wiki.samba.org/index.php/Bug_Reporting\n;));
DEBUGSEP(0);
smb_panic("internal error");
--
Samba Shared Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via ab232ca77f8 waf: Use waf function to add for -Wl,--as-needed via 9499db075b7 waf:replace: Do not link against libpthread if not necessary via bd0cd8e1323 third_party: Link uid_wrapper against pthread via 68d8a02ef57 third_party: Link nss_wrapper against pthread via 36e8d715bc8 third_party: Only link cmocka against librt if really needed via 4b28239d13b pthreadpool: Only link pthreadpool against librt if we have to via 480152dd672 replace: Only link against librt if really needed via 952e1812fa9 s3:waf: Do not check for nanosleep() as we don't use it anywhere from 3bb7ccb4635 s4:scripting: make samba-gpupdate heed --disable-python https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit ab232ca77f8f08879d99f88cfcd554500717075e Author: Andreas Schneider Date: Mon Sep 23 17:21:51 2019 +0200 waf: Use waf function to add for -Wl,--as-needed Signed-off-by: Andreas Schneider Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Wed Sep 25 16:56:40 UTC 2019 on sn-devel-184 commit 9499db075b72b147e2ff9bb78e9d5edbaac14e69 Author: Andreas Schneider Date: Mon Sep 23 16:53:12 2019 +0200 waf:replace: Do not link against libpthread if not necessary On Linux we should avoid linking everything against libpthread. Symbols used my most application are provided by glibc and code which deals with threads has to explicitly link against libpthread. This avoids setting LDFLAGS=-pthread globally. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Andreas Schneider Signed-off-by: Isaac Boukris Pair-Programmed-With: Isaac Boukris Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy commit bd0cd8e13234d684da77a65f6fdaea2572625369 Author: Andreas Schneider Date: Mon Sep 23 17:40:13 2019 +0200 third_party: Link uid_wrapper against pthread uid_wrapper uses pthread_atfork() which is only provided by libpthread. │ So we need an explicit dependency. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Andreas Schneider Signed-off-by: Isaac Boukris Pair-Programmed-With: Isaac Boukris Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy commit 68d8a02ef57cce29e4ff3ef1b792adfc10d0b916 Author: Andreas Schneider Date: Mon Sep 23 17:39:29 2019 +0200 third_party: Link nss_wrapper against pthread nss_wrapper uses pthread_atfork() which is only provided by libpthread. So we need an explicit dependency. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Andreas Schneider Signed-off-by: Isaac Boukris Pair-Programmed-With: Isaac Boukris Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy commit 36e8d715bc8dc1e8466f5a5c9798df76310b7572 Author: Andreas Schneider Date: Mon Sep 23 17:04:57 2019 +0200 third_party: Only link cmocka against librt if really needed cmocka also uses clock_gettime(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Andreas Schneider Signed-off-by: Isaac Boukris Pair-Programmed-With: Isaac Boukris Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy commit 4b28239d13b17e42eb5aa4b405342f46347f3de4 Author: Andreas Schneider Date: Mon Sep 23 16:10:35 2019 +0200 pthreadpool: Only link pthreadpool against librt if we have to This calls clock_gettime() which is available in glibc on Linux. If the wscript in libreplace detected that librt is needed for clock_gettime() we have to link against it. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Andreas Schneider Signed-off-by: Isaac Boukris Pair-Programmed-With: Isaac Boukris Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy commit 480152dd6729d4c58faca6f3e4fa91ff4614c272 Author: Andreas Schneider Date: Mon Sep 23 15:14:24 2019 +0200 replace: Only link against librt if really needed fdatasync() and clock_gettime() are provided by glibc on Linux, so there is no need to link against librt. Checks have been added so if there are platforms which require it are still functional. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140 Signed-off-by: Andreas Schneider Signed-off-by: Isaac Boukris Pair-Programmed-With: Isaac Boukris Reviewed-by: Matthias Dieter Wallnöfer Reviewed-by: Alexander Bokovoy commit
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 3bb7ccb4635 s4:scripting: make samba-gpupdate heed --disable-python
via 018c93f35a8 s3/librpc/crypto: clang: Fixes Value stored to 'ret' is
never read
via 40ddcf7bdce s3/libads: clang: Fix Array access results in a null
pointer dereference
via d3371d8545b s3/librpc/crypto: clang: warning: Value stored to
'gss_maj' is never read
via f755de54135 s4/libcli/clideltree.c: clang: Value stored to 'status'
is never read
via ba55c022076 s4/libcli/smb2: clang: Fix 'value stored to 'status' is
never read'
via 076216da796 s4/libcli/smb2: clang: Fix Passed-by-value arg contains
uninitialized data
via 088a345f6ac s4/libcli/raw: clang: Fix 'Value stored to 'p' is never
read'
via a1a448b19b9 s4/libcli/raw: clang: Fix 'Dereference of null pointer'
via 55c6e4bcc1b s4/libcli/raw: clang: Fix 'Access to field results in a
deref of a null ptr
from 517ec63004f vfs_fileid: add "fsname_norootdir_ext" option
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 3bb7ccb4635535cb9dd9333220222dcfffb2aed9
Author: Philipp Gesang
Date: Thu Sep 19 09:03:45 2019 +0200
s4:scripting: make samba-gpupdate heed --disable-python
Signed-off-by: Philipp Gesang
Reviewed-by: Andrew Bartlett
Reviewed-by: Noel Power
Autobuild-User(master): Noel Power
Autobuild-Date(master): Wed Sep 25 11:06:04 UTC 2019 on sn-devel-184
commit 018c93f35a80daef74e44e32ff0ff7437eed8547
Author: Noel Power
Date: Thu Aug 8 13:15:14 2019 +
s3/librpc/crypto: clang: Fixes Value stored to 'ret' is never read
Fixes:
source3/librpc/crypto/gse_krb5.c:63:3: warning: Value stored to 'ret' is
never read <--[clang]
ret = smb_krb5_kt_free_entry(krbctx, _entry);
^ ~
1 warning generated.
Signed-off-by: Noel Power
Reviewed-by: Andreas Schneider
commit 40ddcf7bdcec547acdba090f43651cc5b953aded
Author: Noel Power
Date: Thu Aug 8 13:12:39 2019 +
s3/libads: clang: Fix Array access results in a null pointer dereference
Fixes:
source3/libads/cldap.c:400:6: warning: Array access (from variable
'responses') results in a null pointer dereference <--[clang]
if (responses[0] == NULL) {
^
1 warning generated.
Signed-off-by: Noel Power
Reviewed-by: Andreas Schneider
commit d3371d8545bb4303e866e991453a0bbb05dd7656
Author: Noel Power
Date: Fri Aug 2 10:45:48 2019 +
s3/librpc/crypto: clang: warning: Value stored to 'gss_maj' is never read
Fixes: Value stored to 'gss_maj' is never read
source3/librpc/crypto/gse.c:562:3: warning: Value stored to 'gss_maj' is
never read <--[clang]
gss_maj = gss_release_buffer(_min, _data);
^ ~~~
source3/librpc/crypto/gse.c:687:3: warning: Value stored to 'gss_maj' is
never read <--[clang]
gss_maj = gss_release_buffer(_min, _data);
^ ~~~
source3/librpc/crypto/gse.c:739:3: warning: Value stored to 'gss_maj' is
never read <--[clang]
gss_maj = gss_release_buffer(_min, _min);
^ ~~
source3/librpc/crypto/gse.c:742:3: warning: Value stored to 'gss_maj' is
never read <--[clang]
gss_maj = gss_release_buffer(_min, _maj);
^ ~~
4 warnings generated.
Signed-off-by: Noel Power
Reviewed-by: Andreas Schneider
commit f755de54135ab5900209d093a45d9b824687a3bf
Author: Noel Power
Date: Thu Aug 8 15:10:30 2019 +0100
s4/libcli/clideltree.c: clang: Value stored to 'status' is never read
Fixes:
source4/libcli/clideltree.c:113:3: warning: Value stored to 'status' is
never read <--[clang]
status = smbcli_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
^
source4/libcli/clideltree.c:131:3: warning: Value stored to 'status' is
never read <--[clang]
status = smbcli_setatr(dstate.tree, dname,
FILE_ATTRIBUTE_NORMAL, 0);
^
~~~
2 warnings generated.
Signed-off-by: Noel Power
Reviewed-by: Andreas Schneider
commit ba55c0220767358656be125e6cecedef97317e9f
Author: Noel Power
Date: Mon Jul 29 11:44:26 2019 +
s4/libcli/smb2: clang: Fix 'value stored to 'status' is never read'
Fixes:
source4/libcli/smb2/util.c:134:3: warning: Value stored to 'status' is
never read <--[clang]
