[SCM] Samba Website Repository - branch master updated
The branch, master has been updated via 7045c7c Remove OpenIQ support listing via 0a34402 Update listing for Commercial IT Services Ltd from 515f7a4 Update Pacific ESI e-mail https://git.samba.org/?p=samba-web.git;a=shortlog;h=master - Log - commit 7045c7c98e4b78b0bee1d5cf4ffec70a9b1d33b7 Author: Andrew Bartlett Date: Tue Mar 10 13:27:49 2020 +1300 Remove OpenIQ support listing e-mail to them bounces, the domain redirects to another organisation where the e-mail also bounces. Web enquiry also not responded to. Signed-off-by: Andrew Bartlett commit 0a34402d63f64544216bfc006c699c62ee67c522 Author: Andrew Bartlett Date: Tue Mar 10 13:26:22 2020 +1300 Update listing for Commercial IT Services Ltd Roland requested by e-mail that the old phone number be removed. Signed-off-by: Andrew Bartlett --- Summary of changes: support/australia.html | 19 --- support/newzealand.html | 1 - 2 files changed, 20 deletions(-) Changeset truncated at 500 lines: diff --git a/support/australia.html b/support/australia.html index 8bf38cf..85fe923 100644 --- a/support/australia.html +++ b/support/australia.html @@ -88,25 +88,6 @@ We encourage you to contact Loftus IT to explore the benefits of an Open Source - - -OpenIQ Pty Ltd - -50 York St, -Sydney, NSW 2000 - -http://www.OpenIQ.com.au;>http://www.OpenIQ.com.au -+61-2-8001-6199 -mailto:he...@openiq.com.au;>he...@openiq.com.au -Lee Curtis - - -A crack team of enterprise architects and certified engineers with a bias towards data centre-grade Linux. - -High availability installation of NAS setups backed by enterprise single sign-on. - - - Pacific ESI diff --git a/support/newzealand.html b/support/newzealand.html index 2b6b0b6..38ea67b 100644 --- a/support/newzealand.html +++ b/support/newzealand.html @@ -40,7 +40,6 @@ beyond. PO Box 301094, Albany http://www.cits.co.nz -+64-9-448 2711 i...@cits.co.nz Roland Venter -- Samba Website Repository
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 54f26cfcf25 autobuild: Run the none env in the samba-o3 build via 609c9903473 Require Python 3.6 for Samba 4.13 via e9ce0f13e69 .gitlab-ci.yml: Do not build Samba for Ubuntu 16.04 or Debian 9 any longer via d048d7e17d7 bootstrap: Remove long-unsupported OS versions from 0ae4f368c6c smbd: reuse close_free_pending_aio() in close_directory() https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 54f26cfcf2587a2b1d97f466a886fa89a116eea1 Author: Andreas Schneider Date: Fri Nov 22 15:23:35 2019 +0100 autobuild: Run the none env in the samba-o3 build This includes tests which should make sure that certain code is not optimized away, like memset_s(). Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Mon Mar 9 23:42:26 UTC 2020 on sn-devel-184 commit 609c9903473b139fdf1b2ed02b9c93b648eeea8c Author: Andrew Bartlett Date: Wed Mar 4 13:51:23 2020 +1300 Require Python 3.6 for Samba 4.13 This allows Samba to use formatted string literals, which are quite handy. REF: https://docs.python.org/3/whatsnew/3.6.html#whatsnew36-pep498 Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider commit e9ce0f13e695f1d7e719923628255ea786a90c20 Author: Andrew Bartlett Date: Wed Mar 4 13:55:27 2020 +1300 .gitlab-ci.yml: Do not build Samba for Ubuntu 16.04 or Debian 9 any longer These only have Python 3.5 and we want to increase the minimum to Python 3.6. Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider commit d048d7e17d756099e208fa4d6b931a147b0b1489 Author: Andrew Bartlett Date: Wed Mar 4 13:58:48 2020 +1300 bootstrap: Remove long-unsupported OS versions Samba has not built on these versions for quite some time due to the need for Python 3.5 and GnuTLS 3.4.7 These were always marked as broken, but given the requirements these are never likely to come back. Signed-off-by: Andrew Bartlett Reviewed-by: Andreas Schneider --- Summary of changes: .gitlab-ci.yml| 14 +-- WHATSNEW.txt | 11 +++ bootstrap/.gitlab-ci.yml | 18 bootstrap/config.py | 83 bootstrap/generated-dists/Vagrantfile | 42 - bootstrap/generated-dists/centos6/Dockerfile | 27 -- bootstrap/generated-dists/centos6/bootstrap.sh| 109 -- bootstrap/generated-dists/centos6/locale.sh | 55 --- bootstrap/generated-dists/centos6/packages.yml| 89 -- bootstrap/generated-dists/debian7/Dockerfile | 27 -- bootstrap/generated-dists/debian7/bootstrap.sh| 101 bootstrap/generated-dists/debian7/locale.sh | 55 --- bootstrap/generated-dists/debian7/packages.yml| 86 - bootstrap/generated-dists/debian8/Dockerfile | 27 -- bootstrap/generated-dists/debian8/bootstrap.sh| 105 - bootstrap/generated-dists/debian8/locale.sh | 55 --- bootstrap/generated-dists/debian8/packages.yml| 90 -- bootstrap/generated-dists/debian9/Dockerfile | 27 -- bootstrap/generated-dists/debian9/bootstrap.sh| 105 - bootstrap/generated-dists/debian9/locale.sh | 55 --- bootstrap/generated-dists/debian9/packages.yml| 90 -- bootstrap/generated-dists/ubuntu1404/Dockerfile | 27 -- bootstrap/generated-dists/ubuntu1404/bootstrap.sh | 103 bootstrap/generated-dists/ubuntu1404/locale.sh| 55 --- bootstrap/generated-dists/ubuntu1404/packages.yml | 88 - bootstrap/generated-dists/ubuntu1604/Dockerfile | 27 -- bootstrap/generated-dists/ubuntu1604/bootstrap.sh | 104 - bootstrap/generated-dists/ubuntu1604/locale.sh| 55 --- bootstrap/generated-dists/ubuntu1604/packages.yml | 89 -- bootstrap/sha1sum.txt | 2 +- buildtools/wafsamba/samba_python.py | 2 +- script/autobuild.py | 11 +-- 32 files changed, 16 insertions(+), 1818 deletions(-) delete mode 100644 bootstrap/generated-dists/centos6/Dockerfile delete mode 100755 bootstrap/generated-dists/centos6/bootstrap.sh delete mode 100755 bootstrap/generated-dists/centos6/locale.sh delete mode 100644 bootstrap/generated-dists/centos6/packages.yml delete mode 100644 bootstrap/generated-dists/debian7/Dockerfile delete mode 100755
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 0ae4f368c6c smbd: reuse close_free_pending_aio() in
close_directory()
via f94cd10a211 smbd: call tevent_req_nterror() for directories when
cleaning up pending aio
via acb0b017613 smbd: move pending aio cleanup to a helper function
via 95cfcda13fe vfs_default: Protect vfs_getxattrat_done() from
accessing a freed req pointer
via 0e894f3e482 vfs_default: pass in state as the callback data to the
subreq
from 54c21a99e6c winexe: add configure option to control whether to
build it (default: auto)
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 0ae4f368c6c8d2c8c7aa34069007a984055df0da
Author: Ralph Boehme
Date: Mon Mar 9 11:18:23 2020 +0100
smbd: reuse close_free_pending_aio() in close_directory()
A directory fsp can have outstanding aio requests as well.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
Autobuild-User(master): Jeremy Allison
Autobuild-Date(master): Mon Mar 9 19:34:27 UTC 2020 on sn-devel-184
commit f94cd10a211e2eae966ba4bd26921556bbe513fc
Author: Ralph Boehme
Date: Mon Mar 9 11:31:00 2020 +0100
smbd: call tevent_req_nterror() for directories when cleaning up pending aio
smbd_smb2_query_directory_recv() calls tevent_req_is_nterror() which
requires a
NTSTATUS error code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
commit acb0b01761330864a23932f643f7ad4e3d374634
Author: Ralph Boehme
Date: Mon Mar 9 11:16:37 2020 +0100
smbd: move pending aio cleanup to a helper function
We'll be reusing this from close_directory() in the next commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
commit 95cfcda13fe9a70b9955a7c44173d619eacb34c1
Author: Ralph Boehme
Date: Mon Mar 9 11:54:37 2020 +0100
vfs_default: Protect vfs_getxattrat_done() from accessing a freed req
pointer
If the fsp is forced closed by a SHUTDOWN_CLOSE whilst the request is in
flight (share forced closed by smbcontrol), then we set state->req = NULL
in the
state destructor.
The existing state destructor prevents the state memory from being freed, so
when the thread completes and calls vfs_getxattrat_done(), just throw away
the result
if state->req == NULL.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
commit 0e894f3e48285415f72cf7a68e26f1802fe8045d
Author: Ralph Boehme
Date: Mon Mar 9 11:54:28 2020 +0100
vfs_default: pass in state as the callback data to the subreq
Find the req we're finishing off by looking inside the state. In a shutdown
close the caller calls talloc_free(req), so we can't access it directly as
callback data.
The next commit will NULL out the state->req pointer when a caller calls
talloc_free(req), and the request is still in flight.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301
Signed-off-by: Ralph Boehme
Reviewed-by: Jeremy Allison
---
Summary of changes:
source3/modules/vfs_default.c | 28 ++--
source3/smbd/close.c | 152 --
2 files changed, 94 insertions(+), 86 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c
index fac7fa30ab7..cf24e66e048 100644
--- a/source3/modules/vfs_default.c
+++ b/source3/modules/vfs_default.c
@@ -3289,6 +3289,15 @@ struct vfswrap_getxattrat_state {
static int vfswrap_getxattrat_state_destructor(
struct vfswrap_getxattrat_state *state)
{
+ /*
+* This destructor only gets called if the request is still
+* in flight, which is why we deny it by returning -1. We
+* also set the req pointer to NULL so the _done function
+* can detect the caller doesn't want the result anymore.
+*
+* Forcing the fsp closed by a SHUTDOWN_CLOSE can cause this.
+*/
+ state->req = NULL;
return -1;
}
@@ -3408,7 +3417,7 @@ static struct tevent_req *vfswrap_getxattrat_send(
if (tevent_req_nomem(subreq, req)) {
return tevent_req_post(req, ev);
}
- tevent_req_set_callback(subreq, vfswrap_getxattrat_done, req);
+ tevent_req_set_callback(subreq, vfswrap_getxattrat_done, state);
talloc_set_destructor(state, vfswrap_getxattrat_state_destructor);
@@ -3503,10 +3512,9 @@ end_profile:
static void vfswrap_getxattrat_done(struct tevent_req *subreq)
{
- struct tevent_req *req
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via 54c21a99e6c winexe: add configure option to control whether to
build it (default: auto)
via ebda529b591 librpc: fix IDL for svcctl_ChangeServiceConfigW
via c3fa0b2df9f s4-torture: add ndr svcctl testsuite
via 0825324bc75 s4-torture: add rpc test for ChangeServiceConfigW
from f92af661902 vfs_recycle: prevent flooding the log if we're called
on non-existant paths
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit 54c21a99e6ca54bdb963c70d322f6778b57a384f
Author: Günther Deschner
Date: Wed Mar 4 18:51:01 2020 +0100
winexe: add configure option to control whether to build it (default: auto)
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Andreas Schneider
Autobuild-User(master): Andreas Schneider
Autobuild-Date(master): Mon Mar 9 16:27:21 UTC 2020 on sn-devel-184
commit ebda529b59105e9b70cc74377fe4d54cc16b4f37
Author: Günther Deschner
Date: Wed Mar 4 15:23:43 2020 +0100
librpc: fix IDL for svcctl_ChangeServiceConfigW
Found while trying to run winexe against Windows Server 2019.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14313
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Andreas Schneider
commit c3fa0b2df9fc53dddcc3160b6a3dc751bbb389a4
Author: Günther Deschner
Date: Thu Mar 5 20:42:21 2020 +0100
s4-torture: add ndr svcctl testsuite
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14313
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Andreas Schneider
commit 0825324bc75d2ab10164a1f137be782d84c822b8
Author: Günther Deschner
Date: Thu Mar 5 22:45:48 2020 +0100
s4-torture: add rpc test for ChangeServiceConfigW
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14313
Guenther
Signed-off-by: Guenther Deschner
Reviewed-by: Andreas Schneider
---
Summary of changes:
examples/winexe/winexe.c | 2 +
examples/winexe/wscript_build | 3 +-
librpc/idl/svcctl.idl | 25 +---
selftest/knownfail| 3 ++
source3/wscript | 17 +
source4/torture/ndr/ndr.c | 1 +
source4/torture/ndr/svcctl.c | 88 +++
source4/torture/rpc/svcctl.c | 81 ++-
source4/torture/wscript_build | 1 +
9 files changed, 213 insertions(+), 8 deletions(-)
create mode 100644 source4/torture/ndr/svcctl.c
Changeset truncated at 500 lines:
diff --git a/examples/winexe/winexe.c b/examples/winexe/winexe.c
index 22f748b1d45..fc6b15f8e52 100644
--- a/examples/winexe/winexe.c
+++ b/examples/winexe/winexe.c
@@ -625,8 +625,10 @@ static NTSTATUS winexe_svc_install(
NULL, /* load_order_group */
NULL, /* tag_id */
NULL, /* dependencies */
+ 0, /* dwDependSize */
NULL, /* service_start_name */
NULL, /* password */
+ 0, /* dwPwSize */
NULL, /* display_name */
);
diff --git a/examples/winexe/wscript_build b/examples/winexe/wscript_build
index 43c09717e3d..559ed3fc706 100644
--- a/examples/winexe/wscript_build
+++ b/examples/winexe/wscript_build
@@ -106,4 +106,5 @@ if winexesvc_binaries != '':
LOADPARM_CTX
libsmb
msrpc3
- ''')
+ ''',
+ enabled=bld.env.build_winexe)
diff --git a/librpc/idl/svcctl.idl b/librpc/idl/svcctl.idl
index 671a1dc47be..a9dd3dec990 100644
--- a/librpc/idl/svcctl.idl
+++ b/librpc/idl/svcctl.idl
@@ -13,6 +13,17 @@ import "misc.idl", "security.idl";
helpstring("Service Control")
] interface svcctl
{
+ const int MAX_SERVICE_NAME_LENGTH = 256;
+ const short SC_MAX_DEPEND_SIZE = 4 * 1024;
+ const short SC_MAX_NAME_LENGTH = MAX_SERVICE_NAME_LENGTH + 1;
+ const short SC_MAX_PATH_LENGTH = 32 * 1024;
+ const short SC_MAX_PWD_SIZE = 514;
+ const short SC_MAX_COMPUTER_NAME_LENGTH = 1024;
+ const short SC_MAX_ACCOUNT_NAME_LENGTH = 2 * 1024;
+ const short SC_MAX_COMMENT_LENGTH = 128;
+ const short SC_MAX_ARGUMENT_LENGTH = 1024;
+ const short SC_MAX_ARGUMENTS = 1024;
+
typedef struct {
uint32 is_locked;
[string,charset(UTF16)] uint16 *lock_owner;
@@ -188,18 +199,20 @@ import "misc.idl", "security.idl";
SVCCTL_DISABLED = 0x0004
} svcctl_StartType;
- WERROR svcctl_ChangeServiceConfigW(
+ [public] WERROR svcctl_ChangeServiceConfigW(
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated
via f92af661902 vfs_recycle: prevent flooding the log if we're called
on non-existant paths
from be90ab01bb4 ctdb-docs: Improve recovery lock documentation
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -
commit f92af66190281a04c6687eb91fea3b41c616c19e
Author: Ralph Boehme
Date: Fri Mar 6 12:22:25 2020 +0100
vfs_recycle: prevent flooding the log if we're called on non-existant paths
vfs_recycle is assuming that any path passed to unlink must exist,
otherwise it
logs this error. Turn this into a DEBUG level message.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14316
See also: https://bugzilla.redhat.com/show_bug.cgi?id=1780802
Signed-off-by: Ralph Boehme
Reviewed-by: Isaac Boukris
Autobuild-User(master): Isaac Boukris
Autobuild-Date(master): Mon Mar 9 14:15:06 UTC 2020 on sn-devel-184
---
Summary of changes:
source3/modules/vfs_recycle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c
index a1d32bf10cb..ab1e6aa4dcf 100644
--- a/source3/modules/vfs_recycle.c
+++ b/source3/modules/vfs_recycle.c
@@ -236,8 +236,8 @@ static off_t recycle_get_file_size(vfs_handle_struct
*handle,
}
if (SMB_VFS_STAT(handle->conn, smb_fname_tmp) != 0) {
- DEBUG(0,("recycle: stat for %s returned %s\n",
-smb_fname_str_dbg(smb_fname_tmp), strerror(errno)));
+ DBG_DEBUG("stat for %s returned %s\n",
+smb_fname_str_dbg(smb_fname_tmp), strerror(errno));
size = (off_t)0;
goto out;
}
--
Samba Shared Repository
