[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via f214a3ba5a3 selftest: Windows 2019 implements the RemoveDollar behaviour for Enterprise principals via fc77ece0e2b selftest: Add in encrypted-pa-data from RFC 6806 via ab8c0a181be selftest: Fix formatting of failure (traceback and options swapped in format string) via 2693f12fbe3 selftest: Make as_canonicalization_tests.py auto-detect the NT4 domain name via d79218dbba3 samdb: Add samdb.domain_netbios_name() via d85e71f4490 selftest: Make as_canonicalization_tests.py easier to run outside "make test" via 579a3c641c7 selftest: Fix flipped machine and user constants via d7f731ed357 selftest: Send enterprise principals tagged as such from d762ab558ae locking: hide share_mode_lock definition https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit f214a3ba5a3e9f129f10062392ae03edd62d8186 Author: Andrew Bartlett Date: Tue Nov 10 13:50:37 2020 +1300 selftest: Windows 2019 implements the RemoveDollar behaviour for Enterprise principals This is documented in MS-KILE. Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer Autobuild-User(master): Gary Lockyer Autobuild-Date(master): Wed Nov 11 02:38:46 UTC 2020 on sn-devel-184 commit fc77ece0e2b5fd324809e17a9b208cc7854cee4b Author: Andrew Bartlett Date: Tue Nov 10 11:27:06 2020 +1300 selftest: Add in encrypted-pa-data from RFC 6806 This comes from Windows 2019 which supports FAST. Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer commit ab8c0a181bebe17a597af49790f6e7b17e13c29b Author: Andrew Bartlett Date: Tue Nov 10 11:21:24 2020 +1300 selftest: Fix formatting of failure (traceback and options swapped in format string) Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer commit 2693f12fbe321e0f4932b1f74d7006dbac140e8e Author: Andrew Bartlett Date: Tue Nov 10 13:47:30 2020 +1300 selftest: Make as_canonicalization_tests.py auto-detect the NT4 domain name Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer commit d79218dbba3d0f26d6a0e22b3c91b0731bf641dd Author: Andrew Bartlett Date: Tue Nov 10 13:46:28 2020 +1300 samdb: Add samdb.domain_netbios_name() Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer commit d85e71f449037fa035fa2fae6b64caf695c53cb3 Author: Andrew Bartlett Date: Tue Nov 10 11:12:13 2020 +1300 selftest: Make as_canonicalization_tests.py easier to run outside "make test" This takes the realm from the LDAP base DN and so avoids one easy mistake to make. So far the NT4 domain name is not auto-detected, so much be read from the smb.conf. By using .guess() the smb.conf is read for the unspecified parts (eg workstation for an NTLM login to the LDAP server if the target server is an IP address). Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer commit 579a3c641c72b65f6ba39141a55c765b517bd7f8 Author: Andrew Bartlett Date: Tue Nov 10 11:09:59 2020 +1300 selftest: Fix flipped machine and user constants This naturally does not change the test, but reduces developer confusion. Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer commit d7f731ed3577b407370d8fe7a62b4c3ee2dd9c75 Author: Andrew Bartlett Date: Tue Nov 10 11:09:13 2020 +1300 selftest: Send enterprise principals tagged as such This test passed against Samba but failed against Windows when an enterprise principal (u...@domain.com@REALM) was encoded as NT_PRINCIPAL. Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer --- Summary of changes: python/samba/netcmd/user.py| 10 +--- python/samba/samdb.py | 15 ++ .../samba/tests/krb5/as_canonicalization_tests.py | 62 ++ python/samba/tests/krb5/rfc4120.asn1 | 3 +- python/samba/tests/krb5/rfc4120_pyasn1.py | 19 +++ python/samba/tests/samdb.py| 13 +++-- selftest/knownfail.d/kdc-enterprise| 37 + selftest/knownfail_mit_kdc | 28 ++ selftest/tests.py | 1 + 9 files changed, 144 insertions(+), 44 deletions(-) create mode 100644 selftest/knownfail.d/kdc-enterprise Changeset truncated at 500 lines: diff --git a/python/samba/netcmd/user.py b/python/samba/netcmd/user.py index b483dcf5591..7e8204462d1 100644 --- a/python/samba/netcmd/user.py +++ b/python/samba/netcmd/user.py @@ -3210,14 +3210,8 @@ The users gecos field will be set to 'User4 test' if unix_home is None: # obtain nETBIOS Domain Name -filter = "(&(objectClass=cr
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via d762ab558ae locking: hide share_mode_lock definition via df2ffaaa209 locking: move share_mode_flags_[gs]et to share_mode_lock.c via 4b6f4ee43e3 smbd: Avoid references to share_mode_data->id via d220bae5a9d smbd: Remove a variable used just once via 271a369fb94 smbd: Don't set share_mode_lock modified in grant_new_fsp_lease() via f6abe33dd17 net_tdb: Use share_mode_data_dump() via 5c3a18e5145 locking: Add share_mode_data_dump() accessor function via ce64b3caf39 net_tdb: Use share_mode_filename() via affce737dc9 net_tdb: Use share_mode_servicepath() via 2337c1e3f80 net_tdb: Slightly restructure net_tdb_locking() via ee41ec8afe0 smbd: Use share_mode_servicepath() in scavenger.c via 5aab299dff2 locking: Add share_mode_servicepath() accessor function via 3d33eee5366 smbd: Avoid share_mode_lock dereference in scavenger via 53059dc6cbf smbd: Use share_mode_filename() in scavenger.c via d2662dff7e0 smbstatus: Use share_mode_filename() via 701da78cc84 locking: Add share_mode_filename() accessor function via ec387d04816 smbd: Use share_mode_changed_write_time() in smbd/close.c via 60f24079a90 smbd: Use share_mode_changed_write_time() in durable_disconnect() via a01cb7faa34 locking: Add share_mode_changed_write_time() accessor function via 3f54fcaffd7 smbd: Move setting d->modified=true to reset_share_mode_entry() via 84dba041a35 locking: Make share_mode_watch_send() take "share_mode_lock" via 2fe1e601c90 smbd: Move "struct share_mode_lock" to share_mode_lock.h via 13217e6eb91 smbd: Move share_mode_cleanup_disonnected() to scavenger.c via 15e9e2945c2 smbd: Give locking/share_mode_lock.c its own header file via 4da7de80d56 smbd: Align integer types via 401c5132a40 passdb: Align integer types via daa9d98cf80 auth: Align an integer type via fc88f2e0e43 vfs_error_inject: Align integer types via 76043ccb7f0 lib: Slightly optimize smb_fname_str_dbg() via 30c917c215c lib: Fix a theoretical out-of-bounds write via 1af086d23cf lib: Fix a signed/unsigned warning via be381fd4547 smbd: Use ISDOT[DOT] in can_delete_directory_fsp() via a342cf2cb89 locking: Remove an unused anonymous struct reference via 5ac44b83ee9 lib: Move generate_unique_u64_state into generate_unique_u64() via 6598e00e129 lib: talloc: Remove the ALWAYS_REALLOC code paths. from 18fdfe8c102 winbind: alternatively use prama fini for destructors if supported https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit d762ab558ae6c16ba5007fb38e44c9667d952e2b Author: Volker Lendecke Date: Wed Nov 4 12:39:48 2020 +0100 locking: hide share_mode_lock definition This makes "struct share_mode_lock" an opaque data structure opened up only to the code in locking/. This makes it much safer to modify the data structure with defined accessor functions in share_mode_lock.c. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Nov 10 21:12:48 UTC 2020 on sn-devel-184 commit df2ffaaa2097676cc1ddfc4239f53aef6afc4869 Author: Volker Lendecke Date: Thu Nov 5 15:39:51 2020 +0100 locking: move share_mode_flags_[gs]et to share_mode_lock.c These routines parse and marshall the uint16 summary flag in share_mode_data. open_file_ntcreate() and open_directory() are the only real users of this. The user in oplock.c is just the lazy reset of the "read lease exists somewhere" after asynchronously breaking read oplocks after a write request. This moves handling the flags into locking/ to consolidate data structure handling of "share_mode_data" there. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 4b6f4ee43e376104f6a7f6556c135ff729f5d40b Author: Volker Lendecke Date: Thu Nov 5 10:42:10 2020 +0100 smbd: Avoid references to share_mode_data->id When calling open_mode_check() we know the file id. We can pass it to the lower levels without dereferencing struct share_mode_lock. Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit d220bae5a9d7f248c3611210c6e79c5ad8f95095 Author: Volker Lendecke Date: Thu Nov 5 10:39:10 2020 +0100 smbd: Remove a variable used just once Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison commit 271a369fb94fb4affdd8725c9cce829bb5d85c93 Author: Volker Lendecke Date: Wed Nov 4 15:51:51 2020 +0100 smbd: Don't set share_mode_lock modified in grant_new_fsp_lease() A new lease never triggers a retry. Setting d->modified to true just triggered the watchers needlessly.
[SCM] Samba Shared Repository - branch master updated
The branch, master has been updated via 18fdfe8c102 winbind: alternatively use prama fini for destructors if supported via f13e1ca54a2 talloc: alternatively use prama init for constructors if supported via c32eb006108 waf: check for pragma init/fini support for constructors/destructors via 37b81f91168 util_net: fix a statement not reached warning via c305ab07709 ldb_parse_test: studio compiler doesn't like empty struct definitions via 918317124ac ldb_key_value_test: studio compiler doesn't like empty struct definitions via c862ad64aea ldb_kv_index: fix empty initializer compile warning via e4f3354821a torture/sharemode: fix empty initializer compile warning via aa8d6c779ca pidl: use unused attribute only if supported by feature macro via 3c1013caf4b tdb: fix studio compiler build via 268fcfdd5aa talloc/pytalloc: fix studio compler build via 6b855429b96 talloc: fix studio compiler build via cce4e8012c5 auth_generic: fix empty initializer compile warning via a4e90cfec49 http_conn.c: fix "void function cannot return value" error via bbfd93f7b63 debug: remove a cast, which makes the Solaris Studio compiler unhappy via a223c5b5b7f waf: use _POSIX_PTHREAD_SEMANTIC on Solaris via 104b3545e08 heimdal_build: silence warning: macro redefined via edb1012536e replace: define BOOL_DEFINED to fix header yp_prot header check on Solaris via b9e8959c3d5 waf/texpect: add required nsl dependency for Solaris via 96e2cf7905e replace/waf: fix libnsl checking on Solaris from be03ce7d8bb manpages/vfs_glusterfs: Mention silent skipping of write-behind translator https://git.samba.org/?p=samba.git;a=shortlog;h=master - Log - commit 18fdfe8c10291e04b6a54499d74a6ee15652f5db Author: Björn Jacke Date: Fri Oct 30 12:59:06 2020 +0100 winbind: alternatively use prama fini for destructors if supported Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Tue Nov 10 08:17:53 UTC 2020 on sn-devel-184 commit f13e1ca54a2a448dd87809496e4b6da5af1589e8 Author: Björn Jacke Date: Fri Oct 30 12:57:42 2020 +0100 talloc: alternatively use prama init for constructors if supported Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit c32eb006108c69a99c651e11a0a4160359e52145 Author: Björn Jacke Date: Fri Oct 30 12:55:54 2020 +0100 waf: check for pragma init/fini support for constructors/destructors Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit 37b81f9116825e0fc0fcd62aa957655fe5c83f19 Author: Björn Jacke Date: Mon Oct 26 11:30:06 2020 +0100 util_net: fix a statement not reached warning Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit c305ab07709bcb5eba11568ac2fd625410f441e2 Author: Björn Jacke Date: Mon Oct 26 12:49:05 2020 +0100 ldb_parse_test: studio compiler doesn't like empty struct definitions Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit 918317124acbb4b0f0d12eeeae79eafdfddaa49c Author: Björn Jacke Date: Sun Oct 25 17:13:57 2020 +0100 ldb_key_value_test: studio compiler doesn't like empty struct definitions Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit c862ad64aea31d1d5ec66385bb50d9b97e609071 Author: Björn Jacke Date: Mon Oct 19 02:39:46 2020 +0200 ldb_kv_index: fix empty initializer compile warning Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit e4f3354821a919ec60eb3af55709e7055513cc24 Author: Björn Jacke Date: Mon Oct 19 02:35:02 2020 +0200 torture/sharemode: fix empty initializer compile warning Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit aa8d6c779ca89d6be1c8b973d3ea60e6073bf899 Author: Björn Jacke Date: Mon Oct 19 02:03:02 2020 +0200 pidl: use unused attribute only if supported by feature macro Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit 3c1013caf4b57c6af5a5d210df232c08a1227a17 Author: Björn Jacke Date: Thu Mar 7 12:50:29 2019 +0100 tdb: fix studio compiler build Solaris Studio compiler 12.4 is pedantic about prototypes in headers having the external visibility declarations too. It throws errors like: redeclaration must have the same or more restrictive linker scoping: ... Signed-off-by: Bjoern Jacke Reviewed-by: Andrew Bartlett commit 268fcfdd5aa3adbcd6486090ee56aad6e6902a12 Author: Björn Jacke Date: Sun Oct 18 21:55:22 2020 +0200 talloc/pytalloc: fix studio compler build Solaris Studio compiler 12.4 is pedantic about prototypes in headers having the external visibility declarations too. It throws errors like:
