[PATCH] Better fix for devicetype?

2003-03-25 Thread Andrew Bartlett
Would this be a better fix for the devicetype problem? It looks like we are putting the strings into the buffer twice, and we are not returning the 'fixed' devicetype for both protocol levels ( NT1 and NT1). What happened here is that jermey 'fixed' a const warning. This meant that this

Re: [PATCH] Better fix for devicetype?

2003-03-25 Thread jra
On Tue, Mar 25, 2003 at 10:02:13PM +1100, Andrew Bartlett wrote: Would this be a better fix for the devicetype problem? It looks like we are putting the strings into the buffer twice, and we are not returning the 'fixed' devicetype for both protocol levels ( NT1 and NT1). What happened

Re: [PATCH] Better fix for devicetype?

2003-03-25 Thread Andrew Bartlett
On Wed, 2003-03-26 at 03:28, Gerald (Jerry) Carter wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 25 Mar 2003, Andrew Bartlett wrote: Would this be a better fix for the devicetype problem? I may be blind here, but the only difference in your patch that I see is some

Re: [PATCH] Better fix for devicetype?

2003-03-25 Thread Gerald (Jerry) Carter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26 Mar 2003, Andrew Bartlett wrote: I may be blind here, but the only difference in your patch that I see is some rewritten debug messages. What am I overlooking? The second half of the patch? Ah...you mean adding the server_devicetype

Re: [PATCH] Better fix for devicetype?

2003-03-25 Thread Andrew Bartlett
On Wed, 2003-03-26 at 09:28, Gerald (Jerry) Carter wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26 Mar 2003, Andrew Bartlett wrote: I may be blind here, but the only difference in your patch that I see is some rewritten debug messages. What am I overlooking? The

Re: [PATCH] Better fix for devicetype?

2003-03-25 Thread Gerald (Jerry) Carter
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26 Mar 2003, Andrew Bartlett wrote: And removing the second set of push_string()s. It looked like you had some kind of merge error - your patch added new push_string() calls, rather than modified the original push_string() lines. Ahh...yes.

Re: [PATCH] Better fix for devicetype?

2003-03-25 Thread Andrew Bartlett
On Tue, Mar 25, 2003 at 05:02:58PM -0600, Gerald (Jerry) Carter wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26 Mar 2003, Andrew Bartlett wrote: And removing the second set of push_string()s. It looked like you had some kind of merge error - your patch added new