Re: [patch] Allow chown of directories from W2k domain clients

2003-02-19 Thread Andrew Bartlett
On Wed, 2003-02-19 at 19:18, Andrew Furey wrote: Hi all, I never did get any replies to my original postings to this list (as well as samba@), so I wrote my own patch. I just _know_ that there are going to be several folks point out that this is a hack, and would never survive an audit,

Re: [patch] Allow chown of directories from W2k domain clients

2003-02-19 Thread Andrew Furey
+ if (strcmp(strerror(errno),Is a directory) == 0) { + fd = conn-vfs_ops.opendir(conn,dos_to_unix_static(fname)); + } This needs some serious flamage... Why can't you just use the errno directly? Because I couldn't find it :( The closest I could come was #21 (listed in asm/errno.h), but

Re: [patch] Allow chown of directories from W2k domain clients

2003-02-19 Thread David Collier-Brown -- Customer Engineering
Andrew Furey wrote: Because I couldn't find it :( The closest I could come was #21 (listed in asm/errno.h), but I couldn't confirm it - whenever I tried to access the errno variable (by logging it) smbd would segfault :( My C is a bit (OK, a lot) rusty... I think you may have missed a