Re: Ignoring printer errors

2003-02-11 Thread Martin Zielinski
This might be a bit off-topic (and for samba-general) but when thinking about handling such error codes - what about providing an api to communicate printer settings? CUPS currently does not support the IPP_SET_PRINTER_ATTRIBUTES call, but if implemented, SAMBA could e.g. pass options from the

Re: Ignoring printer errors

2003-02-11 Thread Michael B. Allen
On Mon, 10 Feb 2003 18:44:00 + [EMAIL PROTECTED] wrote: Don't change the printing code. You'll regret it :-) :-). I was also thinking this morning in the shower of moving the error returns to full NTSTATUS for all printing returns... That would make me want to take a shower too. Mike --

Re: Ignoring printer errors

2003-02-11 Thread Michael Sweet
Martin Zielinski wrote: ... CUPS currently does not support the IPP_SET_PRINTER_ATTRIBUTES call, but if implemented, SAMBA could e.g. pass options from the printer_info_2 struct to the spooler. I'm not sure how well such things would translate, but in the broader scope this would only work if

Ignoring printer errors

2003-02-10 Thread Andrew Bartlett
I'm wondering, why (in HEAD and 3.0) rpc_server/srv_spoolss_nt.c:_spoolss_enddocprinter_internal() doesn't handle any errors? It sort of makes sense if we don't check the output of running the unix 'lpr' command (due to the separate thread of execution), but now we have back-ends like CUPS, that

Re: Ignoring printer errors

2003-02-10 Thread Michael Sweet
Andrew Bartlett wrote: I'm wondering, why (in HEAD and 3.0) rpc_server/srv_spoolss_nt.c:_spoolss_enddocprinter_internal() doesn't handle any errors? It sort of makes sense if we don't check the output of running the unix 'lpr' command (due to the separate thread of execution), but now we have

Re: Ignoring printer errors

2003-02-10 Thread jra
On Mon, Feb 10, 2003 at 11:35:01PM +1100, Andrew Bartlett wrote: I'm wondering, why (in HEAD and 3.0) rpc_server/srv_spoolss_nt.c:_spoolss_enddocprinter_internal() doesn't handle any errors? It sort of makes sense if we don't check the output of running the unix 'lpr' command (due to the

Re: Ignoring printer errors

2003-02-10 Thread Andrew Bartlett
On Tue, 2003-02-11 at 00:15, Michael Sweet wrote: Andrew Bartlett wrote: I'm wondering, why (in HEAD and 3.0) rpc_server/srv_spoolss_nt.c:_spoolss_enddocprinter_internal() doesn't handle any errors? It sort of makes sense if we don't check the output of running the unix 'lpr'

Re: Ignoring printer errors

2003-02-10 Thread Michael Sweet
Andrew Bartlett wrote: ... I'll volunteer my time with an IPP-Windows error code mapping function... Unless you have an official table we can (legally) get a copy of, I would suggest this method to find the 'correct' mapping: Well, there is no official table for mapping from IPP codes to