Re: [sane-devel] Restore support WorkCentre 3510 (may be 3520) in sane-backend-1.0.27

[Olaf Meeuwissen]

Hi Youry,

Sorry for not following up on your related comment on GitLab.com[1]
earlier.

 [1]: 
https://gitlab.com/sane-project/backends/commit/c9027378a12a6f67b22ee5fe203df1739486e3ad#note_37105915

Youry Metlitsky writes:

> On WorkCentre 3515 dev->compressionTypes is 0x51 and (dev->compressionTypes & 
> (1 << 6)) is true.
> On WorkCentre 3510 dev->compressionTypes is 0x41, but this device don't 
> support jpeg - this is error!

Is the commit you commented on, which only conditionalizes compilation
of the JPEG specific bits in the code, the cause of breakage or is the
problem with the dev->compressionTypes checking?

That is do things work when you build from the commit immediately before
c9027378 or not?

Hope this helps,
--
Olaf Meeuwissen, LPIC-2FSF Associate Member since 2004-01-27
 GnuPG key: F84A2DD9/B3C0 2F47 EA19 64F4 9F13  F43E B8A4 A88A F84A 2DD9
 Support Free Softwarehttps://my.fsf.org/donate
 Join the Free Software Foundation  https://my.fsf.org/join

-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org

Re: [sane-devel] Restore support WorkCentre 3510 (may be 3520) in sane-backend-1.0.27

[ABC]

Youry,

That code was submitted by SAMSUNG developer(s). I will forward your
email to them.

-abc


On Wed, Aug 09, 2017 at 01:42:45AM +0300, Youry Metlitsky wrote:
> 
> On WorkCentre 3515 dev->compressionTypes is 0x51 and (dev->compressionTypes & 
> (1 << 6)) is true.
> On WorkCentre 3510 dev->compressionTypes is 0x41, but this device don't 
> support jpeg - this is error!
> 
> -- 
> With best regards

> diff -Nurp sane-backends-1.0.27-old/backend/xerox_mfp.c 
> sane-backends-1.0.27/backend/xerox_mfp.c
> --- sane-backends-1.0.27-old/backend/xerox_mfp.c  2017-03-19 
> 02:19:04.0 +0300
> +++ sane-backends-1.0.27/backend/xerox_mfp.c  2017-08-09 01:31:56.117414319 
> +0300
> @@ -206,7 +206,7 @@ static int isSupportedDevice(struct devi
>  {
>  #ifdef HAVE_LIBJPEG
>  /* Checking device which supports JPEG Lossy compression for color 
> scanning*/
> -if (dev->compressionTypes & (1 << 6))
> +if ((dev->compressionTypes & 0x50) == 0x50)
>  return 1;
>  else
>  return 0;

> -- 
> sane-devel mailing list: sane-devel@lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
> Unsubscribe: Send mail with subject "unsubscribe your_password"
>  to sane-devel-requ...@lists.alioth.debian.org


-- 
sane-devel mailing list: sane-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/sane-devel
Unsubscribe: Send mail with subject "unsubscribe your_password"
 to sane-devel-requ...@lists.alioth.debian.org