[Savannah-hackers-public] Running Savannah Locally (round 2)

[Assaf Gordon]

Hello,

I've added some files to make running savannah's PHP code
locally much easier (requiring only PHP and some standard tools,
without local apache2 or mysql servers).

Details here:
https://savannah.gnu.org/maintenance/RunningSavaneLocally/
https://git.savannah.gnu.org/cgit/administration/savane.git/commit/?id=be53e21e00d330e

Please give it a try and send feedback
(or better yet - send patches!)

regards,
- assaf

Re: [Savannah-hackers-public] bzr post-commit email hook

[Glenn Morris]

Assaf Gordon wrote:

> I assume it happens because over long period of time,
> various savannah admins changed various files
> (e.g. scripts on 'vcs'), but never checked them into the 'savane'
> repository.

I never knew anything about the repository. :)

> I'll have some time tomorrow, so I'll commit your updates
> to the repository as needed - otherwise we'll lose them
> again the next time savane in updated/installed.

Thanks. For the record, I also patched the installed bzr-email plugin
as shown at the end of this message.

>> I no longer have any writable bzr repos on Savannah to test with.
>
> I took the liberty of adding you (Glenn) to our dedicated test-project
>   https://savannah.nongnu.org/projects/test-project/

Thanks, but probably not needed.
I see there are only 8 bzr projects on Savannah that updated in the past
year (frankly, this is more than I expected). Only 3 Savannah projects
ever seem to have used the bzr-email plugin, and gsrc is the only one
still active. So I expect never to have to go through any of this again. :)

*** /usr/share/pyshared/bzrlib/plugins/email/emailer.py.ORIG2012-07-13 
08:57:32.0 -0400
--- /usr/share/pyshared/bzrlib/plugins/email/emailer.py 2017-02-10 
22:07:52.808398220 -0500
***
*** 58,63 
--- 58,64 
  fields = {
  'committer': self.revision.committer,
  'message': self.revision.get_summary(),
+ 'nick': self.branch._get_nick(local=True),
  'revision': '%d' % self.revno,
  'url': self.url()
  }
***
*** 92,98 
 to_file=outf
 )
  
! if len(self.revision.parent_ids) <= 1:
  # This is not a merge, so we can special case the display of one
  # revision, and not have to encur the show_log overhead.
  lr = log.LogRevision(self.revision, self.revno, 0, None)
--- 93,101 
 to_file=outf
 )
  
! # rgm: hack to always get the effect of verbose=True.
! # https://bugs.launchpad.net/bzr-email/+bug/1189292
! if len(self.revision.parent_ids) <= 0:
  # This is not a merge, so we can special case the display of one
  # revision, and not have to encur the show_log overhead.
  lr = log.LogRevision(self.revision, self.revno, 0, None)
***
*** 188,194 
  return
  for line in headers:
  key, value = line.split(": ", 1)
! result[key] = value
  return result
  
  def send(self):
--- 191,197 
  return
  for line in headers:
  key, value = line.split(": ", 1)
! result[key] = self._format(value)
  return result
  
  def send(self):
***
*** 205,212 
  mailer = self.mailer()
  if mailer == 'smtplib':
  self._send_using_smtplib()
! else:
  self._send_using_process()
  finally:
  self.repository.unlock()
  self.branch.unlock()
--- 208,217 
  mailer = self.mailer()
  if mailer == 'smtplib':
  self._send_using_smtplib()
! elif mailer == '/usr/bin/mail':
  self._send_using_process()
+ else:
+ raise errors.BzrError("Bad value for post_commit_mailer")
  finally:
  self.repository.unlock()
  self.branch.unlock()
***
*** 247,253 
  msg = EmailMessage(from_addr, to_addrs, subject, body)
  
  if diff:
! msg.add_inline_attachment(diff, self.diff_filename())
  
  # Add revision_mail_headers to the headers
  if header != None:
--- 252,258 
  msg = EmailMessage(from_addr, to_addrs, subject, body)
  
  if diff:
! msg.add_inline_attachment(diff, self.diff_filename(), 'x-diff')
  
  # Add revision_mail_headers to the headers
  if header != None:
***
*** 291,300 
  opt_post_commit_log_format = Option('post_commit_log_format',
  default='long', help="Log format for option.")
  opt_post_commit_difflimit = Option('post_commit_difflimit',
! default=1000, from_unicode=int_from_store,
  help="Maximum number of lines in diffs.")
  opt_post_commit_push_pull = Option('post_commit_push_pull',
! from_unicode=bool_from_store,
  help="Whether to send emails on push and pull.")
  opt_post_commit_diffoptions = Option('post_commit_diffoptions',
  help="Diff options to use.")
--- 296,305 
  opt_post_commit_log_format = Option('post_commit_log_format',
  default='long', help="Log format for option.")
  opt_post_commit_difflimit = Option('post_commit_difflimit',
! default=1, from_unicode=int_from_store,
  help="Maximum 

Re: [Savannah-hackers-public] bzr post-commit email hook

[Glenn Morris]

Bob Proulx wrote:

> I just made a big edit, import, cleanup to the authorized keys file.
> Try it again now.  I it should allow you in.  You should be able to
> log in from fencepost to mgt0 now.

Thanks. If security is a concern you should probably all disable my
Savannah ssh access, since I don't foresee a need for me to login again.

[Savannah-hackers-public] savannah's git repository updates

[Assaf Gordon]

Hello,

We are far enough into the migration, so I've updated
the master branch of savannah's git repository to
the latest revision (the ones that runs on 
frontend0):

https://git.savannah.gnu.org/cgit/administration/savane.git/

Previously these commits were on separate branches 
(nextgen and sv-test-2017-02-1).


I've ensured that the latest 'master' revision is
used on all servers (frontend0,vcs0,mgt0,download0)
in /opt/savannah/savane .

Note that the /opt/savannah/savane repostiory is cloned from the read
only URL git://git.savannah.gnu.org/administration/savane.git .

Meaning,
it is expected that we make modifications elsewhere
(e.g. a local copy), then push, then pull updates
on the servers.
Whether we'll be able to actually do it remains to be seen :)

I understand that the nature of many savannah volunteers
means sometimes changes are "quick and dirty".
If someone does make emergency changes directly
to the PHP files on frontend0:/opt/savannah/savane/frontend/php ,
please at least send a message to savannah-hackers-public@gnu.org,
and we'll import the changes post-hoc.


This also means that in the (very unlikely) event
of having to roll-back to the old 'frontend',
we should *not* pull the latest changes. They won't
work cleanly on the old machine.

regards,
 -assaf

Re: [Savannah-hackers-public] bzr post-commit email hook

[Assaf Gordon]

Hi,

I've incorporated your changes here:
https://git.savannah.gnu.org/cgit/administration/savane.git/commit/?id=d23caef7bd0ec7bbddf06

Thanks for your help in fixing bzr!

-assaf

Re: [Savannah-hackers-public] Visible PHP warnings on savannah's webpages

[Assaf Gordon]

On Fri, Feb 10, 2017 at 04:24:45PM +, Assaf Gordon wrote:

Benno Schulenberg reported that some PHP warnings are
rendered visible on the html pages:
 https://savannah.gnu.org/support/?109253


I turned off php's "display error" settings
in apache's config file:

===
--- a/apache2/sites-available/sv.inc
+++ b/apache2/sites-available/sv.inc
@@ -12 +12 @@ DocumentRoot /var/www/savane/frontend/php
-  php_admin_flag display_errors on
+  php_admin_flag display_errors off
===

The errors will still appear in the error log,
but at least won't bother users.

-assaf

Re: [Savannah-hackers-public] New guix-patches mailing list not showing up on Mailman

[Karl Berry]

I created a new œôòøguix-patchesœôòù mailing lists ~48h ago on Savannah.  

I just created it by hand. Assaf is looking into the PHP<->Savannah
linkage/breakage. --best, karl.

Re: [Savannah-hackers-public] New guix-patches mailing list not showing up on Mailman

[Assaf Gordon]

Hello,

On Sat, Feb 11, 2017 at 03:37:43PM +0100, Ludovic Courtès wrote:

I created a new ‘guix-patches’ mailing lists ~48h ago on Savannah.  The
list shows up on  but still
not on lists.gnu.org.

Did something go wrong?


Perhaps the required cron-jobs on mgt0 (or internal0) are not working
properly. On the old 'internal', it was the 'sv_mailman' cronjob.

source: https://savannah.gnu.org/maintenance/SavannahInternals/
under sections "Project administration - mailing lists (frontend)"
and "Cron jobs on internal".

I'll look into it.

-assaf

[Savannah-hackers-public] Downstream questions about Savannah and HTTPS

[Leo Famulari]

GNU Guix is discussing the possibilities created by Savannah's offering
of Git-over-HTTPS:

http://lists.gnu.org/archive/html/guix-devel/2017-02/msg00386.html

If anyone from Savannah has anything to add to the discussion, feel free
to jump in :)

[Savannah-hackers-public] New guix-patches mailing list not showing up on Mailman

[Ludovic Courtès]

Hello!

I created a new ‘guix-patches’ mailing lists ~48h ago on Savannah.  The
list shows up on  but still
not on lists.gnu.org.

Did something go wrong?

TIA!
Ludo’.