Re: [Savonet-users] [savonet/liquidsoap] Liquidsoap CPU to 100% and then crashes (#628)

2018-09-19 Thread Romain Beauxis
Hi, Quick testing here seems fine with `1.3.4`. * What version of `liquidsoap` are you using? * Do you have some reproduction steps/logs to share? Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Ok, I pushed a fix. Essentially, it does the following: * Try to parse as: ``` #EXTINF:, - ``` If any of `artist` or `title` contains the string `" - "` then it falls back to parsing: ``` #EXTINF:, ``` `song` is a metadata that is used in `output.{icecast,shoutcast}` `mp3` metadata. It is

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Closed #625 via 97671c072606a6880f3ceed235168e5a45f1678d. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/savonet/liquidsoap/issues/625#event-1855183531___

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Ok, my bad, I hadn't looked at this code for a long time. Yes, liquidsoap parses metadata from the `m3u` playlist and it follows this pattern: ``` #EXTINF,- ``` So, your case indeed exhibits the two ambiguous cases, where `` or `` contains a dash `-` or a comma `,`. For the comma, there's an

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Have you checked the file's metadata? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/savonet/liquidsoap/issues/625#issuecomment-422808789___ Savonet-users

Re: [Savonet-users] [savonet/liquidsoap] input.gstreamer.video is never defined, despite gstreamer being installed (#629)

2018-09-19 Thread Romain Beauxis
Glad to know it's fixed! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/savonet/liquidsoap/issues/629#issuecomment-422806036___ Savonet-users mailing list

Re: [Savonet-users] [savonet/liquidsoap] input.gstreamer.video is never defined, despite gstreamer being installed (#629)

2018-09-19 Thread MCOfficer
Closed #629. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/savonet/liquidsoap/issues/629#event-1854970717___ Savonet-users mailing list

Re: [Savonet-users] [savonet/liquidsoap] input.gstreamer.video is never defined, despite gstreamer being installed (#629)

2018-09-19 Thread MCOfficer
i wiped my entire opam and everything it had installed, then reinstalled everything. this time, it worked. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Savonet-users] [savonet/liquidsoap] ON_METADATA not called when live show is broadcast. (#624)

2018-09-19 Thread djazz
I have a similar issue with Liquidsoap 1.3.4 where `on_metadata` and `map_metadata` doesn't always get called after a `smart_crossfade`. I tested this by running skip multiple times. [code](https://github.com/daniel-j/parasprite-radio/blob/ebddb2fd275249056026d6f681b6a939c1a48cb4/liq/radio.liq)