Re: [Savonet-users] [savonet/liquidsoap] GStreamer Memory Leak (#511)

2018-08-05 Thread dromer
So I tried an ```opam reinstall gstreamer``` (and also ```uninstall 
gstreamer``` followed by ``install```), and how I can test is that on the 
telnet interface I run ```output(dot)gstreamer.skip``` and I still see the 
memory use increase steadily.

Maybe you have to up the version so opam picks it up?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/issues/511#issuecomment-410594524--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users


Re: [Savonet-users] [savonet/liquidsoap] GStreamer Memory Leak (#511)

2018-08-05 Thread dromer
Ah, you didn't change the version number. Not sure if opam is installing the 
new ocaml-gstreamer now ..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/issues/511#issuecomment-410594006--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users


Re: [Savonet-users] [savonet/liquidsoap] massive memory leak (#516)

2018-08-05 Thread Romain Beauxis
Hey,

Could you try with the latest `ocaml-gstreamer`? I've made some fixes that 
could very well solve this issue..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/issues/516#issuecomment-410556109--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users


Re: [Savonet-users] [savonet/liquidsoap] GStreamer Memory Leak (#511)

2018-08-05 Thread Romain Beauxis
Hey,

Could you try with the latest `ocaml-gstreamer`? I've made some changes that 
could very well solve this issue..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/issues/511#issuecomment-410556117--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users


Re: [Savonet-users] [savonet/liquidsoap] Remove useless data copy in ffmpeg_decoder (#591)

2018-08-05 Thread Romain Beauxis
Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/pull/591#issuecomment-410518291--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users


Re: [Savonet-users] [savonet/liquidsoap] Remove useless data copy in ffmpeg_decoder (#591)

2018-08-05 Thread Romain Beauxis
Merged #591 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/pull/591#event-1771596014--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users


[Savonet-users] [savonet/liquidsoap] Remove useless data copy in ffmpeg_decoder (#591)

2018-08-05 Thread gndl
Ocaml-ffmpeg no longer reuses output buffers by default. So it is not necessary 
to copy the output data anymore.

You can view, comment on, or merge this pull request online at:

  https://github.com/savonet/liquidsoap/pull/591

-- Commit Summary --

  * Use the current ffmpeg API
  * Revert "Use the current ffmpeg API"
  * Adapt to new Ffmpeg API
  * Remove useless data copy in ffmpeg_decoder
  * Merge branch 'master' of https://github.com/gndl/liquidsoap

-- File Changes --

M src/decoder/ffmpeg_decoder.ml (2)

-- Patch Links --

https://github.com/savonet/liquidsoap/pull/591.patch
https://github.com/savonet/liquidsoap/pull/591.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/savonet/liquidsoap/pull/591
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Savonet-users mailing list
Savonet-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/savonet-users