Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Ok, I pushed a fix. Essentially, it does the following: * Try to parse as: ``` #EXTINF:, - ``` If any of `artist` or `title` contains the string `" - "` then it falls back to parsing: ``` #EXTINF:, ``` `song` is a metadata that is used in `output.{icecast,shoutcast}` `mp3` metadata. It is

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Closed #625 via 97671c072606a6880f3ceed235168e5a45f1678d. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/savonet/liquidsoap/issues/625#event-1855183531___

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Ok, my bad, I hadn't looked at this code for a long time. Yes, liquidsoap parses metadata from the `m3u` playlist and it follows this pattern: ``` #EXTINF,- ``` So, your case indeed exhibits the two ambiguous cases, where `` or `` contains a dash `-` or a comma `,`. For the comma, there's an

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-19 Thread Romain Beauxis
Have you checked the file's metadata? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/savonet/liquidsoap/issues/625#issuecomment-422808789___ Savonet-users

Re: [Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-17 Thread Romain Beauxis
Hi, I'm not sure what context you are referring. Could elaborate a bit more? Thks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Savonet-users] [savonet/liquidsoap] Metadata bug (#625)

2018-09-14 Thread Euguar
I found some bugs with metadata tag parsing: 1. The _Artist_ field has _Title_ field, and the _Title_ field has _Artist_ field (ex.: "Pink - Aerosmith". It must be "Aerosmith - Pink"). Temporarily solution is map_metadata function using to replace fields. 2. If the field _Artist_ or _Title_