Re: [SC-L] Conditional Compile statements-- coding standards, and code review

2009-02-22 Thread David Crocker
] On Behalf Of Bennett, Jason Sent: 16 February 2009 09:46 To: 'sc-l@securecoding.org' Subject: Re: [SC-L] Conditional Compile statements-- coding standards,and code review Robert/Sean, It's a good question and one that I've never seen a really good answer to! Robert your option certain works but I

Re: [SC-L] Conditional Compile statements-- coding standards, and code review

2009-02-16 Thread Bennett, Jason
Robert/Sean, It's a good question and one that I've never seen a really good answer to! Robert your option certain works but I feel that it somewhat prone to error if deployed on a large source base. So for example if a developer actually uses: #ifdef FRED # define MACRO(x) (x + 5) #endif ...

[SC-L] Conditional Compile statements-- coding standards, and code review

2009-02-13 Thread smurray1
I am reviewing a QA team's procedures for code review. I have an issue with conditional compile statements (#ifdef in the C world). My issue is that it is very difficult to have complete confidence that a piece of code inside the condition (the controlled text) does indeed not get compiled

Re: [SC-L] Conditional Compile statements-- coding standards, and code review

2009-02-13 Thread Robert Seacord
@securecoding.org Subject: [SC-L] Conditional Compile statements-- coding standards, and code review I am reviewing a QA team's procedures for code review. I have an issue with conditional compile statements (#ifdef in the C world). My issue is that it is very difficult to have complete confidence